Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCHv2] config: Fix memory leak when realloc fails
(Nishant Chaprana)
2. Re: [PATCH] delete STORAGEDIR folders when services are
removed (Patrik Flykt)
3. Re: Disabling the network on Disconnect Notification
(Patrik Flykt)
4. Configuration file for Connman AP mode (Lamsoge, Abhijit)
5. Re: Configuration file for Connman AP mode (Patrik Flykt)
6. [PATCH] Add AlwaysUseFallbackNameservers flag in the
configuration file. When it is enabled, the fallback name servers
will be used even though some name servers are provided by the
service. (Feng Wang)
7. Re: [PATCH] Add AlwaysUseFallbackNameservers flag in the
configuration file. When it is enabled, the fallback name servers
will be used even though some name servers are provided by the
service. (wangfe-nestlabs)
----------------------------------------------------------------------
Message: 1
Date: Thu, 25 Feb 2016 12:30:35 +0530
From: Nishant Chaprana <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: [PATCHv2] config: Fix memory leak when realloc fails
Message-ID: <[email protected]>
This patch fixes realloc failure case, when realloc fails it
returns NULL and previously allocated memory was getting lost in
this scenario, So all memory should be freed before returning.
v2: corrected tmp_entries as a double pointer in earlier patch.
struct connman_config *config_file = value;
+ struct connman_config_entry **tmp_entries = entries;
---
src/config.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/config.c b/src/config.c
index 344b8ce..7cf3cf4 100644
--- a/src/config.c
+++ b/src/config.c
@@ -1550,13 +1550,16 @@ struct connman_config_entry
**connman_config_get_entries(const char *type)
g_hash_table_iter_init(&iter_file, config_table);
while (g_hash_table_iter_next(&iter_file, &key, &value)) {
struct connman_config *config_file = value;
+ struct connman_config_entry **tmp_entries = entries;
count = g_hash_table_size(config_file->service_table);
entries = g_try_realloc(entries, (i + count + 1) *
sizeof(struct connman_config_entry *));
- if (!entries)
+ if (!entries) {
+ g_free(tmp_entries);
return NULL;
+ }
g_hash_table_iter_init(&iter_config,
config_file->service_table);
@@ -1589,10 +1592,14 @@ struct connman_config_entry
**connman_config_get_entries(const char *type)
}
if (entries) {
+ struct connman_config_entry **tmp_entries = entries;
+
entries = g_try_realloc(entries, (i + 1) *
sizeof(struct connman_config_entry *));
- if (!entries)
+ if (!entries) {
+ g_free(tmp_entries);
return NULL;
+ }
entries[i] = NULL;
--
1.9.1
------------------------------
Message: 2
Date: Thu, 25 Feb 2016 09:46:39 +0200
From: Patrik Flykt <[email protected]>
To: "MANIEZZO Marco (MM)" <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: [PATCH] delete STORAGEDIR folders when services are
removed
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-02-24 at 17:39 +0200, Patrik Flykt wrote:
> On Wed, 2016-02-24 at 15:14 +0000, MANIEZZO Marco (MM) wrote:
> > Please find below the modifications (also attached in case of issues
> > in email indentation):
>
> No. Use 'git format-patch -o ../patch-series-XXXXX --cover-letter
> HEAD~xxx..', edit the cover letter in ../patch-series-XXXXX/0000-YYYY
> and do a 'git send-email --to=connman@... ../patch-series-XXXXX' so that
> 1) the cover letter contains the explanation about the patch series, 2)
> the individual patches that are going to show up upstream containing the
> summary of why this is done in each patch and 3) not to eat the
> indentation...
And BTW, make the documentation and the implementation as separate
patches. One for the definition, one for the actual fix/implementations.
Patrik
------------------------------
Message: 3
Date: Thu, 25 Feb 2016 09:56:43 +0200
From: Patrik Flykt <[email protected]>
To: Naveen Singh <[email protected]>
Cc: [email protected]
Subject: Re: Disabling the network on Disconnect Notification
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-02-24 at 16:49 -0800, Naveen Singh wrote:
> > This connect always is for the same service (even though I have two
> > service configured as favorite) I always see that this connect
> request
> > is issued for the same service. Do you think it makes sense to honor
> > this connect request only in the case wpa_supplicant is not trying
> to
> > get device connected. If the supplicant state is CONNECTED or
> > ASSOCIATING then we should not honor this request and probably drop
> > this additional connect request. Let me know your thought on this.
> >
> > Regards
> > Naveen
>
> This:
> I always see that this connect request is issued for the same
> service.
> should be read as:
> I always see that this connect request is issued for the previously
> connected service.
I'm not 100% sure I know of all the details for this situation. When the
network disconnects, ConnMan marks it as being ignored. While ignored,
the service will not be part of autoconnect procedures. The ignore
status of a service exists as long as the service exists, i.e. if
wpa_supplicant decides that the network is no longer available, the
service will be removed. When wpa_supplicant finds it again, the service
will be recreated afresh without being affected by being previously
ignored and can be autoconnected normally. So what you're seeing above,
depends on what wpa_supplicant managed or did not manage to do.
Cheers,
Patrik
------------------------------
Message: 4
Date: Thu, 25 Feb 2016 09:25:06 +0000
From: "Lamsoge, Abhijit" <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Configuration file for Connman AP mode
Message-ID:
<3261e8fc74193743a7498db5c1deb85ea05db...@hikawsexmb01.ad.harman.com>
Content-Type: text/plain; charset="iso-8859-1"
Hi Patrick,
I have a few queries regarding connman's configuration file.
I am trying to configure connman as access point using tether commands.
But What I want to do is change the range of IP-Address's for the clients
connecting it.
I mentioned some options in wifi.config file dumped in /var/lib/connman,
Like
[General]
TetheringTechnologies = wifi
Now how do I mention a DHCP IP address range in this.
As far as options in the config-format.txt is concerned, I believe, in wifi
context it talks about STAtion role and not AP/Tether mode.
Let me know how to specify IP-Address Pool for DHCP server for wifi AP mode ?
Abhijit
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20160225/73e40c25/attachment-0001.html>
------------------------------
Message: 5
Date: Thu, 25 Feb 2016 14:07:02 +0200
From: Patrik Flykt <[email protected]>
To: "Lamsoge, Abhijit" <[email protected]>
Cc: "[email protected]" <[email protected]>
Subject: Re: Configuration file for Connman AP mode
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Thu, 2016-02-25 at 09:25 +0000, Lamsoge, Abhijit wrote:
> Hi Patrick,
> I have a few queries regarding connman's configuration file.
>
> I am trying to configure connman as access point using tether
> commands.
>
> But What I want to do is change the range of IP-Address's for the
> clients connecting it.
>
> I mentioned some options in wifi.config file dumped
> in /var/lib/connman,
> Like
> [General]
> TetheringTechnologies = wifi
>
> Now how do I mention a DHCP IP address range in this.
>
> As far as options in the config-format.txt is concerned, I believe, in
> wifi context it talks about STAtion role and not AP/Tether mode.
>
> Let me know how to specify IP-Address Pool for DHCP server for wifi AP
> mode ?
The IP range to use for DHCP cannot be configured. ConnMan picks an
unused /24 subnet and starts a DHCP server there. If that subnet or
parts thereof suddenly appear on a uplink connection, tethering will be
restarted which causes another /24 subnet to be selected that does not
conflict with any of the uplink ones.
Deciding in the configuration file which subnet to use for tethering
introduces an interesting problem. What will now happen when the
tethered subnet starts to conflict with the uplink prefix? Half the
people will argue that the uplink connection is more important, while
the other half will argue that the tethered subnet prefix must not
change. Moreover, how is an unsuspecting user that belongs to neither
camp informed why either the uplink connection won't work or why the
subnet used for tethering won't stay the same all the time when all he
did was to (unnecessarily) pick an IPv4 subnet for tethering?
Anyway, as we're dealing with IPv4, DHCP is the only decent option
handing out IPv4 adresses used for connecting to remote systems. The
other option is not IPv4 link local addresses, as by definition they are
not routable outside of the subnetwork. Therefore the question really is
why ConnMan should ever think about allowing the user to nail down a
certain block of private IPv4 addresses to use, as it is a promise that
cannot be kept all times.
Cheers,
Patrik
------------------------------
Message: 6
Date: Thu, 25 Feb 2016 10:41:50 -0800
From: Feng Wang <[email protected]>
To: [email protected]
Subject: [PATCH] Add AlwaysUseFallbackNameservers flag in the
configuration file. When it is enabled, the fallback name servers will
be used even though some name servers are provided by the service.
Message-ID: <[email protected]>
---
src/dhcp.c | 23 +++++++++++++++++++++--
src/main.c | 39 ++++++++++++++++++++++++++-------------
src/main.conf | 4 ++++
src/service.c | 3 ++-
4 files changed, 53 insertions(+), 16 deletions(-)
diff --git a/src/dhcp.c b/src/dhcp.c
index 4040ad1..ba14ae7 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -312,11 +312,11 @@ static bool compare_string_arrays(char **array_a, char
**array_b)
static bool apply_lease_available_on_network(GDHCPClient *dhcp_client,
struct connman_dhcp *dhcp)
{
- char **nameservers, **timeservers, *pac = NULL;
+ char **nameservers, **timeservers, *pac = NULL, **ns;
struct connman_service *service;
GList *list, *option = NULL;
int ns_entries;
- int i;
+ int i, j, len;
if (!dhcp->network)
return true;
@@ -366,6 +366,25 @@ static bool apply_lease_available_on_network(GDHCPClient
*dhcp_client,
g_strfreev(dhcp->nameservers);
}
+ /* Append fallback name servers to the name server list */
+ if (connman_setting_get_bool("AlwaysUseFallbackNameservers")) {
+ ns =
connman_setting_get_string_list("FallbackNameservers");
+ if (ns) {
+ if (nameservers) {
+ i = g_strv_length(nameservers);
+ len = i + g_strv_length(ns);
+ nameservers = g_try_renew(char *,
nameservers, len + 1);
+ } else {
+ i = 0;
+ len = g_strv_length(ns);
+ nameservers = g_try_new0(char *, len +
1);
+ }
+ for (j = 0; ns[j]; j++, i++)
+ nameservers[i] = g_strdup(ns[j]);
+ nameservers[i] = NULL;
+ }
+ }
+
dhcp->nameservers = nameservers;
for (i = 0; dhcp->nameservers && dhcp->nameservers[i]; i++) {
diff --git a/src/main.c b/src/main.c
index e46fa7b..87d11a7 100644
--- a/src/main.c
+++ b/src/main.c
@@ -74,6 +74,7 @@ static struct {
char **tethering_technologies;
bool persistent_tethering_mode;
bool enable_6to4;
+ bool always_use_fallback_nameservers;
} connman_settings = {
.bg_scan = true,
.pref_timeservers = NULL,
@@ -88,21 +89,23 @@ static struct {
.tethering_technologies = NULL,
.persistent_tethering_mode = false,
.enable_6to4 = false,
+ .always_use_fallback_nameservers = false,
};
-#define CONF_BG_SCAN "BackgroundScanning"
-#define CONF_PREF_TIMESERVERS "FallbackTimeservers"
-#define CONF_AUTO_CONNECT "DefaultAutoConnectTechnologies"
-#define CONF_PREFERRED_TECHS "PreferredTechnologies"
-#define CONF_FALLBACK_NAMESERVERS "FallbackNameservers"
-#define CONF_TIMEOUT_INPUTREQ "InputRequestTimeout"
-#define CONF_TIMEOUT_BROWSERLAUNCH "BrowserLaunchTimeout"
-#define CONF_BLACKLISTED_INTERFACES "NetworkInterfaceBlacklist"
-#define CONF_ALLOW_HOSTNAME_UPDATES "AllowHostnameUpdates"
-#define CONF_SINGLE_TECH "SingleConnectedTechnology"
-#define CONF_TETHERING_TECHNOLOGIES "TetheringTechnologies"
-#define CONF_PERSISTENT_TETHERING_MODE "PersistentTetheringMode"
-#define CONF_ENABLE_6TO4 "Enable6to4"
+#define CONF_BG_SCAN "BackgroundScanning"
+#define CONF_PREF_TIMESERVERS "FallbackTimeservers"
+#define CONF_AUTO_CONNECT "DefaultAutoConnectTechnologies"
+#define CONF_PREFERRED_TECHS "PreferredTechnologies"
+#define CONF_FALLBACK_NAMESERVERS "FallbackNameservers"
+#define CONF_TIMEOUT_INPUTREQ "InputRequestTimeout"
+#define CONF_TIMEOUT_BROWSERLAUNCH "BrowserLaunchTimeout"
+#define CONF_BLACKLISTED_INTERFACES "NetworkInterfaceBlacklist"
+#define CONF_ALLOW_HOSTNAME_UPDATES "AllowHostnameUpdates"
+#define CONF_SINGLE_TECH "SingleConnectedTechnology"
+#define CONF_TETHERING_TECHNOLOGIES "TetheringTechnologies"
+#define CONF_PERSISTENT_TETHERING_MODE "PersistentTetheringMode"
+#define CONF_ENABLE_6TO4 "Enable6to4"
+#define CONF_ALWAYS_USE_FALLBACK_NAMESERVERS "AlwaysUseFallbackNameservers"
static const char *supported_options[] = {
CONF_BG_SCAN,
@@ -365,6 +368,13 @@ static void parse_config(GKeyFile *config)
connman_settings.enable_6to4 = boolean;
g_clear_error(&error);
+
+ boolean = __connman_config_get_bool(config, "General",
+ CONF_ALWAYS_USE_FALLBACK_NAMESERVERS,
&error);
+ if (!error)
+ connman_settings.always_use_fallback_nameservers = boolean;
+
+ g_clear_error(&error);
}
static int config_init(const char *file)
@@ -542,6 +552,9 @@ bool connman_setting_get_bool(const char *key)
if (g_str_equal(key, CONF_ENABLE_6TO4))
return connman_settings.enable_6to4;
+ if (g_str_equal(key, CONF_ALWAYS_USE_FALLBACK_NAMESERVERS))
+ return connman_settings.always_use_fallback_nameservers;
+
return false;
}
diff --git a/src/main.conf b/src/main.conf
index eb352fb..a4ea083 100644
--- a/src/main.conf
+++ b/src/main.conf
@@ -33,6 +33,10 @@
# names are ignored.
# FallbackNameservers =
+# Always use fallback name servers even though the name
+# servers are provided by the service. i.e from DHCP reply.
+# AlwaysUseFallbackNameservers = true
+
# List of technologies that are marked autoconnectable
# by default, separated by commas ",". The default value
# for this entry when empty is ethernet,wifi,cellular.
diff --git a/src/service.c b/src/service.c
index 8e07337..3beb828 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1692,7 +1692,8 @@ static void append_dns(DBusMessageIter *iter, void
*user_data)
append_nameservers(iter, service,
service->nameservers_auto);
- if (!service->nameservers && !service->nameservers_auto) {
+ if ((!service->nameservers && !service->nameservers_auto) ||
+
connman_setting_get_bool("AlwaysUseFallbackNameservers")) {
char **ns;
DBG("append fallback nameservers");
--
2.7.0.rc3.207.g0ac5344
------------------------------
Message: 7
Date: Thu, 25 Feb 2016 10:52:58 -0800
From: wangfe-nestlabs <[email protected]>
To: [email protected]
Subject: Re: [PATCH] Add AlwaysUseFallbackNameservers flag in the
configuration file. When it is enabled, the fallback name servers will
be used even though some name servers are provided by the service.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Background information.
Connmand will not use fallback name servers when some name servers are provided
by DHCP reply. But in some cases, the ISP provided its own name servers can?t
be down, then DNS won?t work. So some requirement is to use some fallback name
severs such as 8.8.8.8, 8.8.4.4 for backup.
Add the option flag ?AlwaysUseFallbackNameservers?. Which it is enabled, the
fallback name servers are appended to name server list, and will be used. The
duplicate servers will be filtered out in the
__connman_service_nameserver_append.
Thanks,
Feng
> On Feb 25, 2016, at 10:41 AM, Feng Wang <[email protected]> wrote:
>
> ---
> src/dhcp.c | 23 +++++++++++++++++++++--
> src/main.c | 39 ++++++++++++++++++++++++++-------------
> src/main.conf | 4 ++++
> src/service.c | 3 ++-
> 4 files changed, 53 insertions(+), 16 deletions(-)
>
> diff --git a/src/dhcp.c b/src/dhcp.c
> index 4040ad1..ba14ae7 100644
> --- a/src/dhcp.c
> +++ b/src/dhcp.c
> @@ -312,11 +312,11 @@ static bool compare_string_arrays(char **array_a, char
> **array_b)
> static bool apply_lease_available_on_network(GDHCPClient *dhcp_client,
> struct connman_dhcp *dhcp)
> {
> - char **nameservers, **timeservers, *pac = NULL;
> + char **nameservers, **timeservers, *pac = NULL, **ns;
> struct connman_service *service;
> GList *list, *option = NULL;
> int ns_entries;
> - int i;
> + int i, j, len;
>
> if (!dhcp->network)
> return true;
> @@ -366,6 +366,25 @@ static bool apply_lease_available_on_network(GDHCPClient
> *dhcp_client,
> g_strfreev(dhcp->nameservers);
> }
>
> + /* Append fallback name servers to the name server list */
> + if (connman_setting_get_bool("AlwaysUseFallbackNameservers")) {
> + ns =
> connman_setting_get_string_list("FallbackNameservers");
> + if (ns) {
> + if (nameservers) {
> + i = g_strv_length(nameservers);
> + len = i + g_strv_length(ns);
> + nameservers = g_try_renew(char *,
> nameservers, len + 1);
> + } else {
> + i = 0;
> + len = g_strv_length(ns);
> + nameservers = g_try_new0(char *, len +
> 1);
> + }
> + for (j = 0; ns[j]; j++, i++)
> + nameservers[i] = g_strdup(ns[j]);
> + nameservers[i] = NULL;
> + }
> + }
> +
> dhcp->nameservers = nameservers;
>
> for (i = 0; dhcp->nameservers && dhcp->nameservers[i]; i++) {
> diff --git a/src/main.c b/src/main.c
> index e46fa7b..87d11a7 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -74,6 +74,7 @@ static struct {
> char **tethering_technologies;
> bool persistent_tethering_mode;
> bool enable_6to4;
> + bool always_use_fallback_nameservers;
> } connman_settings = {
> .bg_scan = true,
> .pref_timeservers = NULL,
> @@ -88,21 +89,23 @@ static struct {
> .tethering_technologies = NULL,
> .persistent_tethering_mode = false,
> .enable_6to4 = false,
> + .always_use_fallback_nameservers = false,
> };
>
> -#define CONF_BG_SCAN "BackgroundScanning"
> -#define CONF_PREF_TIMESERVERS "FallbackTimeservers"
> -#define CONF_AUTO_CONNECT "DefaultAutoConnectTechnologies"
> -#define CONF_PREFERRED_TECHS "PreferredTechnologies"
> -#define CONF_FALLBACK_NAMESERVERS "FallbackNameservers"
> -#define CONF_TIMEOUT_INPUTREQ "InputRequestTimeout"
> -#define CONF_TIMEOUT_BROWSERLAUNCH "BrowserLaunchTimeout"
> -#define CONF_BLACKLISTED_INTERFACES "NetworkInterfaceBlacklist"
> -#define CONF_ALLOW_HOSTNAME_UPDATES "AllowHostnameUpdates"
> -#define CONF_SINGLE_TECH "SingleConnectedTechnology"
> -#define CONF_TETHERING_TECHNOLOGIES "TetheringTechnologies"
> -#define CONF_PERSISTENT_TETHERING_MODE "PersistentTetheringMode"
> -#define CONF_ENABLE_6TO4 "Enable6to4"
> +#define CONF_BG_SCAN "BackgroundScanning"
> +#define CONF_PREF_TIMESERVERS "FallbackTimeservers"
> +#define CONF_AUTO_CONNECT "DefaultAutoConnectTechnologies"
> +#define CONF_PREFERRED_TECHS "PreferredTechnologies"
> +#define CONF_FALLBACK_NAMESERVERS "FallbackNameservers"
> +#define CONF_TIMEOUT_INPUTREQ "InputRequestTimeout"
> +#define CONF_TIMEOUT_BROWSERLAUNCH "BrowserLaunchTimeout"
> +#define CONF_BLACKLISTED_INTERFACES "NetworkInterfaceBlacklist"
> +#define CONF_ALLOW_HOSTNAME_UPDATES "AllowHostnameUpdates"
> +#define CONF_SINGLE_TECH "SingleConnectedTechnology"
> +#define CONF_TETHERING_TECHNOLOGIES "TetheringTechnologies"
> +#define CONF_PERSISTENT_TETHERING_MODE "PersistentTetheringMode"
> +#define CONF_ENABLE_6TO4 "Enable6to4"
> +#define CONF_ALWAYS_USE_FALLBACK_NAMESERVERS "AlwaysUseFallbackNameservers"
>
> static const char *supported_options[] = {
> CONF_BG_SCAN,
> @@ -365,6 +368,13 @@ static void parse_config(GKeyFile *config)
> connman_settings.enable_6to4 = boolean;
>
> g_clear_error(&error);
> +
> + boolean = __connman_config_get_bool(config, "General",
> + CONF_ALWAYS_USE_FALLBACK_NAMESERVERS,
> &error);
> + if (!error)
> + connman_settings.always_use_fallback_nameservers = boolean;
> +
> + g_clear_error(&error);
> }
>
> static int config_init(const char *file)
> @@ -542,6 +552,9 @@ bool connman_setting_get_bool(const char *key)
> if (g_str_equal(key, CONF_ENABLE_6TO4))
> return connman_settings.enable_6to4;
>
> + if (g_str_equal(key, CONF_ALWAYS_USE_FALLBACK_NAMESERVERS))
> + return connman_settings.always_use_fallback_nameservers;
> +
> return false;
> }
>
> diff --git a/src/main.conf b/src/main.conf
> index eb352fb..a4ea083 100644
> --- a/src/main.conf
> +++ b/src/main.conf
> @@ -33,6 +33,10 @@
> # names are ignored.
> # FallbackNameservers =
>
> +# Always use fallback name servers even though the name
> +# servers are provided by the service. i.e from DHCP reply.
> +# AlwaysUseFallbackNameservers = true
> +
> # List of technologies that are marked autoconnectable
> # by default, separated by commas ",". The default value
> # for this entry when empty is ethernet,wifi,cellular.
> diff --git a/src/service.c b/src/service.c
> index 8e07337..3beb828 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -1692,7 +1692,8 @@ static void append_dns(DBusMessageIter *iter, void
> *user_data)
> append_nameservers(iter, service,
> service->nameservers_auto);
>
> - if (!service->nameservers && !service->nameservers_auto) {
> + if ((!service->nameservers && !service->nameservers_auto) ||
> +
> connman_setting_get_bool("AlwaysUseFallbackNameservers")) {
> char **ns;
>
> DBG("append fallback nameservers");
> --
> 2.7.0.rc3.207.g0ac5344
>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 4, Issue 33
**************************************
