Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] network: Set service->favorite to false when invalid
key error is set (Saurav Babu)
2. Re: [PATCH] network: Set service->favorite to false when
invalid key error is set (Pasi Sj?holm)
----------------------------------------------------------------------
Message: 1
Date: Wed, 06 Apr 2016 10:05:04 +0530
From: Saurav Babu <[email protected]>
To: [email protected]
Cc: [email protected], Saurav Babu <[email protected]>
Subject: [PATCH] network: Set service->favorite to false when invalid
key error is set
Message-ID:
<[email protected]>
In following scenario connman continuously tries to auto connect to AP:
1. Connect to an AP.
2. Change AP Password.
3. Disconnection occurs and then connman always tries to autoconnect and
fails due to invalid key.
This patch sets service->favorite property to false on receiving invalid
key error so that connman never tries to autoconnect again to that AP
until it has been successfully connected again.
---
src/network.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/network.c b/src/network.c
index db3d2f3..df2115c 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1223,6 +1223,8 @@ static void set_invalid_key_error(struct connman_network
*network)
service = connman_service_lookup_from_network(network);
+ __connman_service_set_favorite(service, false);
+
__connman_service_indicate_error(service,
CONNMAN_SERVICE_ERROR_INVALID_KEY);
}
--
1.9.1
------------------------------
Message: 2
Date: Wed, 6 Apr 2016 21:10:20 +0300 (EEST)
From: Pasi Sj?holm <[email protected]>
To: Saurav Babu <[email protected]>
Cc: [email protected], [email protected]
Subject: Re: [PATCH] network: Set service->favorite to false when
invalid key error is set
Message-ID: <[email protected]>
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
On Wed, 6 Apr 2016, Saurav Babu wrote:
> In following scenario connman continuously tries to auto connect to AP:
> 1. Connect to an AP.
> 2. Change AP Password.
> 3. Disconnection occurs and then connman always tries to autoconnect and
> fails due to invalid key.
>
> This patch sets service->favorite property to false on receiving invalid
> key error so that connman never tries to autoconnect again to that AP
> until it has been successfully connected again.
This is not a good idea as there are too many AP's setup with the same
SSID and having different password. Instead I would suggest setting up
a temporary block for the service not to be available for the
autoconnect due the "invalid key"-error.
Br,
Pasi
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 6, Issue 2
*************************************
