Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH 1/1] service: Remove redundant NULL check (Ravi Prasad RK)
2. [PATCH 1/1] bluetooth: Change function return value
(Ravi Prasad RK)
3. Re: [PATCH] dhcp: Set link MTU if available (Patrik Flykt)
4. Re: [PATCH v2] nat: Remember previous IPv4 forwarding value
(Patrik Flykt)
5. [PATCH 1/1] main: add ve- and vb- to the default interface
blacklist. ([email protected])
6. Re: [PATCH 1/1] service: Remove redundant NULL check
(Patrik Flykt)
7. Re: [PATCH 1/1] bluetooth: Change function return value
(Patrik Flykt)
8. Re: [PATCH 1/1] main: add ve- and vb- to the default
interface blacklist. (Patrik Flykt)
9. Re: [PATCH] firewall: Remove old rules (Patrik Flykt)
10. [PATCH] Store passphrase(PSK) after WPS provisioning has
successfully completed (Jose Blanquicet)
----------------------------------------------------------------------
Message: 1
Date: Wed, 13 Apr 2016 08:50:32 +0530
From: Ravi Prasad RK <[email protected]>
To: [email protected]
Cc: Ravi Prasad RK <[email protected]>
Subject: [PATCH 1/1] service: Remove redundant NULL check
Message-ID: <[email protected]>
g_strdup() returns NULL only if 'nameserver' is NULL.
'nameserver' is checked for NULL at begining of function before
passing to g_strdup() function
---
src/service.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/service.c b/src/service.c
index 8e07337..1fff483 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1127,9 +1127,6 @@ int __connman_service_nameserver_append(struct
connman_service *service,
return -ENOMEM;
nameservers[len] = g_strdup(nameserver);
- if (!nameservers[len])
- return -ENOMEM;
-
nameservers[len + 1] = NULL;
if (is_auto) {
--
1.7.9.5
------------------------------
Message: 2
Date: Wed, 13 Apr 2016 09:57:26 +0530
From: Ravi Prasad RK <[email protected]>
To: [email protected]
Cc: Ravi Prasad RK <[email protected]>
Subject: [PATCH 1/1] bluetooth: Change function return value
Message-ID: <[email protected]>
---
plugins/bluetooth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/plugins/bluetooth.c b/plugins/bluetooth.c
index 3bf8f0f..181df27 100644
--- a/plugins/bluetooth.c
+++ b/plugins/bluetooth.c
@@ -720,7 +720,7 @@ static bool tethering_create(const char *path,
if (!bridge) {
g_free(tethering);
- return -EINVAL;
+ return false;
}
proxy = g_dbus_proxy_new(client, path, "org.bluez.NetworkServer1");
--
1.7.9.5
------------------------------
Message: 3
Date: Wed, 13 Apr 2016 10:31:41 +0300
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH] dhcp: Set link MTU if available
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-03-30 at 14:07 +0300, Patrik Flykt wrote:
> Request DHCP Interface MTU option from the DHCP server and set the
> MTU if it is between the minimum required for IPv6 and the maximum
> for ethernet networks.
>
> Reported by auto.
> ---
Applied.
Patrik
------------------------------
Message: 4
Date: Wed, 13 Apr 2016 10:32:08 +0300
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH v2] nat: Remember previous IPv4 forwarding value
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2016-04-12 at 16:01 +0300, Patrik Flykt wrote:
> When NAT is enabled, store the previous IPv4 forwarding setting so
> that
> it can be restored to its former value when disabling NAT.
> ---
>
> v2: Fix err = -errno and fix a few conditionals to be more readable
Applied.
Patrik
------------------------------
Message: 5
Date: Wed, 13 Apr 2016 10:28:08 +0300
From: [email protected]
To: [email protected]
Cc: Krisztian Litkey <[email protected]>
Subject: [PATCH 1/1] main: add ve- and vb- to the default interface
blacklist.
Message-ID: <[email protected]>
From: Krisztian Litkey <[email protected]>
Add ve- and vb- to the list of default blacklisted interface
prefixes. Such interfaces are usually used by systemd-nspawn'd
containers and are typically managed by systemd-networkd.
---
src/main.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/main.c b/src/main.c
index e46fa7b..f44a2ed 100644
--- a/src/main.c
+++ b/src/main.c
@@ -57,6 +57,8 @@ static char *default_blacklist[] = {
"vboxnet",
"virbr",
"ifb",
+ "ve-",
+ "vb-",
NULL
};
--
2.5.5
------------------------------
Message: 6
Date: Wed, 13 Apr 2016 10:50:36 +0300
From: Patrik Flykt <[email protected]>
To: Ravi Prasad RK <[email protected]>, [email protected]
Subject: Re: [PATCH 1/1] service: Remove redundant NULL check
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-04-13 at 08:50 +0530, Ravi Prasad RK wrote:
> g_strdup() returns NULL only if 'nameserver' is NULL.
> 'nameserver' is checked for NULL at begining of function before
> passing to g_strdup() function
> ---
Applied, thanks!
Patrik
------------------------------
Message: 7
Date: Wed, 13 Apr 2016 10:50:51 +0300
From: Patrik Flykt <[email protected]>
To: Ravi Prasad RK <[email protected]>, [email protected]
Subject: Re: [PATCH 1/1] bluetooth: Change function return value
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-04-13 at 09:57 +0530, Ravi Prasad RK wrote:
> ---
Applied, thanks!
Patrik
------------------------------
Message: 8
Date: Wed, 13 Apr 2016 10:51:08 +0300
From: Patrik Flykt <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH 1/1] main: add ve- and vb- to the default
interface blacklist.
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-04-13 at 10:28 +0300, [email protected] wrote:
> From: Krisztian Litkey <[email protected]>
>
> Add ve- and vb- to the list of default blacklisted interface
> prefixes. Such interfaces are usually used by systemd-nspawn'd
> containers and are typically managed by systemd-networkd.
> ---
Applied, thanks!
Patrik
------------------------------
Message: 9
Date: Wed, 13 Apr 2016 11:10:00 +0300
From: Patrik Flykt <[email protected]>
To: Jose Blanquicet <[email protected]>, [email protected]
Subject: Re: [PATCH] firewall: Remove old rules
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2016-04-12 at 17:18 +0200, Jose Blanquicet wrote:
> When a new service becomes ready or online, it is checked if its
> technology is more preferred than the one used by the currrent
> default gateway. If so, this new service becomes the new default
> gateway.
>
> When the tethering is enabled, a NAT rule is created to forward the
> traffic between the interface playing the AP role and the interface
> connected to current default gateway. The problem comes out when the
> default gateway changes, because the NAT rule is disabled but not
> removed from the firewall rules list. Therefore, when the new rule is
> installed also the old rule is installed because it is still in the
> list. If it changes again, then three rules will be installed, and so
> on. They are never removed.
>
> This patch adds a deletion of all the rules from the firewall list
> exactly after they are disabled to avoid the described problem.
> ---
Applied, thanks!
I chopped down the length of the commit message to fit an 80 character
terminal (the above folding was done by the mail client).
Patrik
------------------------------
Message: 10
Date: Wed, 13 Apr 2016 10:36:01 +0200
From: Jose Blanquicet <[email protected]>
To: [email protected]
Subject: [PATCH] Store passphrase(PSK) after WPS provisioning has
successfully completed
Message-ID: <[email protected]>
When WPS Provisioning finished successfully, the passphrase gotten from
the WPS Credentials is stored first in the network structure in
handle_wps_completion() and then on the service structure in
service_indicate_state(). The problems is that the service's settings
file is created/updated through service_save() before updating the
service structure with the new passphrase. Therefore, the passphrase is
not actually written in the file.
This patch moves the updating of the passphrase before storing the
information in the settings file.
---
src/service.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/src/service.c b/src/service.c
index 1fff483..361e8e4 100644
--- a/src/service.c
+++ b/src/service.c
@@ -5402,16 +5402,6 @@ static int service_indicate_state(struct connman_service
*service)
reply_pending(service, 0);
- g_get_current_time(&service->modified);
- service_save(service);
-
- dns_changed(service);
- domain_changed(service);
- proxy_changed(service);
-
- if (old_state != CONNMAN_SERVICE_STATE_ONLINE)
- __connman_notifier_connect(service->type);
-
if (service->type == CONNMAN_SERVICE_TYPE_WIFI &&
connman_network_get_bool(service->network,
"WiFi.UseWPS")) {
@@ -5425,6 +5415,16 @@ static int service_indicate_state(struct connman_service
*service)
connman_network_set_bool(service->network,
"WiFi.UseWPS", false);
}
+
+ g_get_current_time(&service->modified);
+ service_save(service);
+
+ dns_changed(service);
+ domain_changed(service);
+ proxy_changed(service);
+
+ if (old_state != CONNMAN_SERVICE_STATE_ONLINE)
+ __connman_notifier_connect(service->type);
method = __connman_ipconfig_get_method(service->ipconfig_ipv6);
if (method == CONNMAN_IPCONFIG_METHOD_OFF)
--
1.9.1
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 6, Issue 8
*************************************
