Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. Re: [PATCH] nat: Open IPv4 forwarding file with proper mode
      (Patrik Flykt)
   2. Re: dhcp failure and link local (Prasant J)
   3. [PATCH] client: Use PRIu64 when printing unsigned 64 bit
      values (Patrik Flykt)
   4. Re: [PATCH] client: Use PRIu64 when printing unsigned 64 bit
      values (Patrik Flykt)
   5. [PATCH] Remove old ip/gateway address if different addresses
      are assigned during DHCP renewal to avoid two ip addresses added
      to the interface. (Feng Wang)


----------------------------------------------------------------------

Message: 1
Date: Fri, 15 Apr 2016 13:25:33 +0300
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH] nat: Open IPv4 forwarding file with proper mode
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"

On Fri, 2016-04-15 at 13:19 +0300, Patrik Flykt wrote:
> The file needs to be read and written to.
> ---
> 
> Yes, something wasn't right. Thanks to Jose for noticing this!

...and applied.

        Patrik


------------------------------

Message: 2
Date: Fri, 15 Apr 2016 17:54:52 +0530
From: Prasant J <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: Re: dhcp failure and link local
Message-ID:
        <caa2dh4vjaclx0r0utetwb8w4ta+jk943u10bw0w1wwjh8ah...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8

On Fri, Apr 15, 2016 at 3:14 PM, Patrik Flykt
<[email protected]> wrote:
> On Fri, 2016-04-15 at 13:15 +0530, Prasant J wrote:
>> I want my embedded linux system to stop looking out for DHCP server
>> (stop sending DISCOVERY packets) after ipv4ll address is assigned.
>> Is it possible? If yes, do I need to change the code or is there a
>> configuration file?
>
> Not really. Other users actually run into the opposite problem, which
> was that their DHCP server was not immediately reachable, and wanted to
> get out of a situation with link-local IPv4 decently quickly.
>

Thanks for the inputs, Patrik!

Is it possible to modify gdhcp/client.c code to get the desired
behaviour? it may not be the best solution but a work around which
could work for me.. case you have any suggestions.

Regards, Pj


------------------------------

Message: 3
Date: Fri, 15 Apr 2016 16:57:02 +0300
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: [PATCH] client: Use PRIu64 when printing unsigned 64 bit
        values
Message-ID:
        <[email protected]>

---
 client/dbus_helpers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/dbus_helpers.c b/client/dbus_helpers.c
index 461266c..6ca407d 100644
--- a/client/dbus_helpers.c
+++ b/client/dbus_helpers.c
@@ -22,6 +22,7 @@
 
 #include <stdio.h>
 #include <errno.h>
+#include <inttypes.h>
 #include <glib.h>
 
 #include "input.h"
@@ -116,7 +117,7 @@ void __connmanctl_dbus_print(DBusMessageIter *iter, const 
char *pre,
 
                case DBUS_TYPE_UINT64:
                        dbus_message_iter_get_basic(iter, &u64);
-                       fprintf(stdout, "%lu", u64);
+                       fprintf(stdout, "%"PRIu64, u64);
                        break;
 
                case DBUS_TYPE_DOUBLE:
-- 
2.8.0.rc3



------------------------------

Message: 4
Date: Fri, 15 Apr 2016 17:05:36 +0300
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: Re: [PATCH] client: Use PRIu64 when printing unsigned 64 bit
        values
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"

On Fri, 2016-04-15 at 16:57 +0300, Patrik Flykt wrote:
> ---

...and applied.

        Patrik


------------------------------

Message: 5
Date: Fri, 15 Apr 2016 09:53:09 -0700
From: Feng Wang <[email protected]>
To: [email protected]
Subject: [PATCH] Remove old ip/gateway address if different addresses
        are assigned during DHCP renewal to avoid two ip addresses added to
        the interface.
Message-ID: <[email protected]>

---
 src/dhcp.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/dhcp.c b/src/dhcp.c
index 1d2cd48..54d98db 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -435,7 +435,7 @@ static void lease_available_cb(GDHCPClient *dhcp_client, 
gpointer user_data)
        char *address, *netmask = NULL, *gateway = NULL;
        const char *c_address, *c_gateway;
        unsigned char prefixlen, c_prefixlen;
-       bool ip_change;
+       bool ip_change = false;
 
        DBG("Lease available");
 
@@ -467,14 +467,21 @@ static void lease_available_cb(GDHCPClient *dhcp_client, 
gpointer user_data)
 
        DBG("c_address %s", c_address);
 
-       if (g_strcmp0(address, c_address))
+       if (g_strcmp0(address, c_address)) {
                ip_change = true;
-       else if (g_strcmp0(gateway, c_gateway))
+               if (c_address) {
+                       /* Remove old ip address */
+                       __connman_ipconfig_address_remove(dhcp->ipconfig);
+               }
+       }
+       if (g_strcmp0(gateway, c_gateway)) {
                ip_change = true;
-       else if (prefixlen != c_prefixlen)
+               if (c_gateway) {
+                       /* Remove gateway ip address */
+                       __connman_ipconfig_gateway_remove(dhcp->ipconfig);
+               }
+       } else if (prefixlen != c_prefixlen)
                ip_change = true;
-       else
-               ip_change = false;
 
        __connman_ipconfig_set_method(dhcp->ipconfig,
                                                CONNMAN_IPCONFIG_METHOD_DHCP);
-- 
2.8.0.rc3.226.g39d4020



------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 6, Issue 12
**************************************

Reply via email to