Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. [PATCH] Remove old ip/gateway address if different addresses
      are assigned during DHCP renewal to avoid two ip addresses added
      to the interface. (Feng Wang)
   2. re-connect issues (Thomas Green)


----------------------------------------------------------------------

Message: 1
Date: Fri, 29 Apr 2016 14:37:29 -0700
From: Feng Wang <[email protected]>
To: [email protected]
Subject: [PATCH] Remove old ip/gateway address if different addresses
        are assigned during DHCP renewal to avoid two ip addresses added to
        the interface.
Message-ID: <[email protected]>

---
 src/dhcp.c | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/src/dhcp.c b/src/dhcp.c
index 1d2cd48..54d98db 100644
--- a/src/dhcp.c
+++ b/src/dhcp.c
@@ -435,7 +435,7 @@ static void lease_available_cb(GDHCPClient *dhcp_client, 
gpointer user_data)
        char *address, *netmask = NULL, *gateway = NULL;
        const char *c_address, *c_gateway;
        unsigned char prefixlen, c_prefixlen;
-       bool ip_change;
+       bool ip_change = false;
 
        DBG("Lease available");
 
@@ -467,14 +467,21 @@ static void lease_available_cb(GDHCPClient *dhcp_client, 
gpointer user_data)
 
        DBG("c_address %s", c_address);
 
-       if (g_strcmp0(address, c_address))
+       if (g_strcmp0(address, c_address)) {
                ip_change = true;
-       else if (g_strcmp0(gateway, c_gateway))
+               if (c_address) {
+                       /* Remove old ip address */
+                       __connman_ipconfig_address_remove(dhcp->ipconfig);
+               }
+       }
+       if (g_strcmp0(gateway, c_gateway)) {
                ip_change = true;
-       else if (prefixlen != c_prefixlen)
+               if (c_gateway) {
+                       /* Remove gateway ip address */
+                       __connman_ipconfig_gateway_remove(dhcp->ipconfig);
+               }
+       } else if (prefixlen != c_prefixlen)
                ip_change = true;
-       else
-               ip_change = false;
 
        __connman_ipconfig_set_method(dhcp->ipconfig,
                                                CONNMAN_IPCONFIG_METHOD_DHCP);
-- 
2.8.0.rc3.226.g39d4020



------------------------------

Message: 2
Date: Fri, 29 Apr 2016 21:51:27 +0000
From: Thomas Green <[email protected]>
To: "[email protected]" <[email protected]>
Subject: re-connect issues
Message-ID:
        <c2bc44d770753c45aaac42695fb5be02010329b...@slc-exmb01.corp.srelay.com>
        
Content-Type: text/plain; charset="us-ascii"

We have developed an issue when we have changed a password on an access point.  
In the past, when we would try to connect, the agent would get a new "request 
input" call with a "Passphrase" and "Previous Passphrase"  in the argument 
list.  It seems what happens now is that we receive an invalid-key error from 
the connection call.  We are running connman v 1.29.

Should we not still be getting the "Previous Passphrase"?

Tom


------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 6, Issue 27
**************************************

Reply via email to