Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: Details about the Patch (Patrik Flykt)
2. RE: Details about the Patch (Natarajan, Ponniah (P.))
3. [PATCH] dhcpv6: use correct dhcp renew time when valid
life-time is infinity. (Feng Wang)
----------------------------------------------------------------------
Message: 1
Date: Wed, 01 Jun 2016 15:07:04 +0300
From: Patrik Flykt <[email protected]>
To: "Natarajan, Ponniah (P.)" <[email protected]>,
"'[email protected]'" <[email protected]>
Subject: Re: Details about the Patch
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2016-05-31 at 12:27 +0000, Natarajan, Ponniah (P.) wrote:
> Hi,
> ?
> Please let me know whether this patch as part of below link has been
> considered for release? Or any other mechanism is handled in current
> connman release v1.32
> ?
> http://permalink.gmane.org/gmane.comp.handhelds.moblin.connman/18794
The functionality seems to have gone in as?http://thread.gmane.org/gman
e.linux.network.connman/15852. The commit comment in the thread seems
to tie it together with your ml archive URL.
> We are observing similar issue with connman v1.31, where sometimes
> upon power on of the device, settings of connman for wifi shows as
> ?True?, but when run the connmanctl to get the technology state shows
> the Powered state as ?False?
You need to be more specific and give more details of your
observations.
Patrik
------------------------------
Message: 2
Date: Wed, 1 Jun 2016 14:49:07 +0000
From: "Natarajan, Ponniah (P.)" <[email protected]>
To: Patrik Flykt <[email protected]>,
"'[email protected]'" <[email protected]>
Subject: RE: Details about the Patch
Message-ID:
<vi1pr0601mb2077839f9c307a14fda5221fda...@vi1pr0601mb2077.eurprd06.prod.outlook.com>
Content-Type: text/plain; charset="utf-8"
Hi Patrik,
connman 1.31 is used in our platform, Sometimes there is no powered status
reported on powerup. But the connman settings file for WIFI Enable flag shows
"true", whereas when run the connmanctl "technologies" which returns the
powered status as "False"..
It looks like there is no sync between the connman settings and the
technologies powered status notification.
/var/lib/connman# cat settings
[global]
OfflineMode=false
[WiFi]
Enable=true
Tethering=false
[Gadget]
Enable=false
Tethering=false
connmanctl>technologies
/net/connman/technology/wifi
Name = WiFi
Type = wifi
Powered = False
Connected = False
Tethering = False
Please correct me whether my understandings are wrong..
Note: This issues occurs very sporadic.
Regards,
Ponniah Natarajan.
------------------------------------
Visteon Electronics, India.
Ph Off : +91-44-49477650
Mob : +91-98401-08041
------------------------------------
-----Original Message-----
From: Patrik Flykt [mailto:[email protected]]
Sent: Wednesday, June 01, 2016 5:37 PM
To: Natarajan, Ponniah (P.); '[email protected]'
Subject: Re: Details about the Patch
On Tue, 2016-05-31 at 12:27 +0000, Natarajan, Ponniah (P.) wrote:
> Hi,
>
> Please let me know whether this patch as part of below link has been
> considered for release? Or any other mechanism is handled in current
> connman release v1.32
>
> http://permalink.gmane.org/gmane.comp.handhelds.moblin.connman/18794
The functionality seems to have gone in as http://thread.gmane.org/gman
e.linux.network.connman/15852. The commit comment in the thread seems to tie it
together with your ml archive URL.
> We are observing similar issue with connman v1.31, where sometimes
> upon power on of the device, settings of connman for wifi shows as
> ?True?, but when run the connmanctl to get the technology state shows
> the Powered state as ?False?
You need to be more specific and give more details of your observations.
Patrik
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20160601/bcc1e5a5/attachment-0001.html>
------------------------------
Message: 3
Date: Wed, 1 Jun 2016 10:54:27 -0700
From: Feng Wang <[email protected]>
To: [email protected]
Subject: [PATCH] dhcpv6: use correct dhcp renew time when valid
life-time is infinity.
Message-ID: <[email protected]>
Based on RFC 3315, 22.6, the valid life-time is infinite when its
value is 0xffffffff. In the g_dhcpv6_client_get_timeouts, the expire
data type is time_t. If time_t is uint32, the last_request time plus
0xffffffff will wrapover so that expire time is smaller than current
time. Thus the dhcpv6 will restart immediately(dhcpv6_restart called).
---
gdhcp/client.c | 9 +++++++--
src/dhcpv6.c | 6 +++++-
2 files changed, 12 insertions(+), 3 deletions(-)
diff --git a/gdhcp/client.c b/gdhcp/client.c
index 9012b38..2be3982 100644
--- a/gdhcp/client.c
+++ b/gdhcp/client.c
@@ -835,8 +835,13 @@ int g_dhcpv6_client_get_timeouts(GDHCPClient *dhcp_client,
if (started)
*started = dhcp_client->last_request;
- if (expire)
- *expire = dhcp_client->last_request + dhcp_client->expire;
+ if (expire) {
+ if (dhcp_client->expire == 0xffffffff)
+ /* RFC3315 22.6 infinite valid-lifetime */
+ *expire = 0xffffffff;
+ else
+ *expire = dhcp_client->last_request +
dhcp_client->expire;
+ }
return 0;
}
diff --git a/src/dhcpv6.c b/src/dhcpv6.c
index 9e21040..cd5733a 100644
--- a/src/dhcpv6.c
+++ b/src/dhcpv6.c
@@ -1195,7 +1195,7 @@ static int check_restart(struct connman_dhcpv6 *dhcp)
NULL, &expired);
current = time(NULL);
- if (current >= expired) {
+ if (current >= expired && expired != 0xffffffff) {
DBG("expired by %d secs", (int)(current - expired));
g_timeout_add(0, dhcpv6_restart, dhcp);
@@ -1442,6 +1442,10 @@ int __connman_dhcpv6_start_renew(struct connman_network
*network,
/* RFC 3315, 22.4
* Client can choose the timeout.
*/
+ if (expired == 0xffffffff) {
+ /* RFC 3315, 22.6 infinite valid-lifetime */
+ return 0;
+ }
T1 = (expired - started) / 2;
T2 = (expired - started) / 10 * 8;
}
--
2.8.0.rc3.226.g39d4020
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 8, Issue 1
*************************************
