Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. Skipping wpa_supplicant interfaces by mistake
      (Blanquicet-Melendez Jose (MM))


----------------------------------------------------------------------

Message: 1
Date: Thu, 7 Jul 2016 12:13:08 +0000
From: "Blanquicet-Melendez Jose (MM)"
        <[email protected]>
To: "[email protected]" <[email protected]>
Subject: Skipping wpa_supplicant interfaces by mistake
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"

Hi,

If the wpa_supplicant has been launched before ConnMan, when the Connman calls 
the GetAll method on the fi.w1.wpa_supplicant1, the properties are returned as 
an array where there is an entry named "Interfaces". This entry is an array 
itself with only the object path of the current available interfaces. The 
problem occurs when ConnMan goes across this array using the function 
interface_added(), because this function tries also to extract the interface 
properties next to object path which is wrong because properties are not 
appended in this message reply. So, by doing dbus_message_iter_next(iter), we 
are actually skipping one interface of the list and it will result in a future 
error because the skipped interface(s) were not stored and ConnMan will not be 
aware of them.

This issue is due to the function interface_added() is also used when signal 
"fi.w1.wpa_supplicant1.InterfaceAdded" arrives, and in this message the 
properties are actually appended. It could be solved by distinguishing the 
caller of the function interface_added(). It means to know if function 
interface_added() was called after a GetAll call or a InterfaceAdded signal in 
order to avoid trying to extract properties if they are not actually appended 
in the message.

I think it could be done by taking advantage from the unused user_data argument 
of function interface_added(). Do you agree or is there something we are 
missing?

Best regards,

Jose Blanquicet

________________________________

VISITA IL NOSTRO NUOVO SITO WEB! - VISIT OUR NEW WEB SITE! 
www.magnetimarelli.com

Confidential Notice: This message - including its attachments - may contain 
proprietary, confidential and/or legally protected information and is intended 
solely for the use of the designated addressee(s) above. If you are not the 
intended recipient be aware that any downloading, copying, disclosure, 
distribution or use of the contents of the above information is strictly 
prohibited.
If you have received this communication by mistake, please forward the message 
back to the sender at the email address above, delete the message from all 
mailboxes and any other electronic storage medium and destroy all copies.
Disclaimer Notice: Internet communications cannot be guaranteed to be safe or 
error-free. Therefore we do not assure that this message is complete or 
accurate and we do not accept liability for any errors or omissions in the 
contents of this message.


------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 9, Issue 2
*************************************

Reply via email to