Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: NTP service (Patrik Flykt)
2. Re: [PATCH 2/2] proxy: support for non browser schemes in
'auto' mode (David Woodhouse)
3. Re: Connman on Android/Brillo (Patrik Flykt)
4. Re: [PATCH][v2] resolver: ensure that resolv.conf is
populated with search domains and DNS servers in the correct
order (Patrik Flykt)
5. Re: [PATCH] config: Fix indentation (Patrik Flykt)
6. Re: [PATCH] ntp: Use adjtimex to tune the kernel clock
(Patrik Flykt)
7. Re: [PATCH] rtnl: Treat bond interfaces as ethernet (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Tue, 09 Aug 2016 12:59:24 +0300
From: Patrik Flykt <[email protected]>
To: Thomas Green <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: NTP service
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2016-08-08 at 17:10 +0000, Thomas Green wrote:
> All,
> ?
> Is there a way to easily disable the NTP service?? Our application
> does our own time services, and when connman conflicts with it, it
> breaks our application.
NTP can be disabled by setting Clock API?TimeUpdates to 'manual', see
doc/clock-api.txt. You can check its value with 'connmanctl clock';
patches for setting Clock API properties with connmanctl would be
nice...
Cheers,
Patrik
------------------------------
Message: 2
Date: Tue, 09 Aug 2016 11:11:15 +0100
From: David Woodhouse <[email protected]>
To: Atul Anand <[email protected]>, [email protected]
Subject: Re: [PATCH 2/2] proxy: support for non browser schemes in
'auto' mode
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
On Sun, 2016-08-07 at 13:41 +0530, Atul Anand wrote:
> PacRunner is obtaining PAC file from the network for the use of all
> clients. Though PAC files are usually written for browser protocols
> and browsers have already support for. To be fair towards all clients
> add a new key "NonBrowser" on DBus interface as an string array and
> should be provided when there is a request for proxy from URL with non
> browser scheme.
We definitely need *something* like this. It's worth re-stating the
original problem ? many networks have discoverable PAC files designed
only for web browsers, and as we get everything in the system working
nicely with PacRunner we end up querying it for other things like SMTP
and IMAP connections, which doesn't work. As shown in?
https://bugzilla.gnome.org/show_bug.cgi?id=767786?for example.
We *don't* want a PAC file auto-detected by WPAD/DHCP to be used for
these non-browser protocols, as it *usually* won't work correctly.
However, some PAC files *are* going to work correctly and we want to be
able to use them in that case. And obviously, we want explicit
configurations also to work.
I was actually thinking of a simple boolean 'browser-only' which would
be part of the *matching* process in pacrunner_proxy_lookup(). We'd
select the appropriate proxy config according to the target host (vs.
proxy->domains) and also the target protocol (vs. proxy->nonbrowser).
(Perhaps if a config exists which matches on proxy->domains but *not*
proxy->nonbrowser, we'd return 'direct' instead of letting it fall back
to any generic config which has no proxy->domains list.)
--
David Woodhouse Open Source Technology Centre
[email protected] Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 5760 bytes
Desc: not available
URL:
<http://lists.01.org/pipermail/connman/attachments/20160809/da99e2b4/attachment-0001.bin>
------------------------------
Message: 3
Date: Tue, 09 Aug 2016 13:35:36 +0300
From: Patrik Flykt <[email protected]>
To: Naveen Singh <[email protected]>, [email protected]
Subject: Re: Connman on Android/Brillo
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
Hi,
On Fri, 2016-07-15 at 18:21 -0700, Naveen Singh wrote:
> I had this talk with Marcel few weeks back about compiling connman on
> Android/Brillo. This would surely give connman the penetration into
> Android world and future IoT devices which are based of Brillo.
>
> I actually got it compiled and working. There are two challenges:
>
> a) Some of the libraries that are required by connman are missing.
> For
> my work I got those libraries compiled first.
>
> b) Changes in connman itself: Open source connman does not compile as
> such for Android/Brillo. There are some changes needed in connman to
> get this going. I would like to see if we can upstream these changes.
>
> The intent of this email is to discuss those changes. Following are
> the changes needed:
>
> 1) Backtrace system call: In log.c from function print_backtrace we
> call backtrace. It is a glibc API and is no present in bionic. There
> is an equivalent function in bionic for doing this.
Backtrace printing was moved to its own file, src/backtrace.c, in
ConnMan 1.32, so this is just an automake check away.
> 2) hard check for ns_initparse in libresolv.so: There is no
> libresolv.so for android/Brillo. All these ns_* symbols are part of
> libc.so. So hard check has to go. We may need to check in
> configure.ac
> whether we are compiling against glibc or bionic early on and do
> stuff
> differently.
Yes, some automake magic needed.
> 3) NTP code calls adjtime to adjust clock. This function is missing
> in
> bionic. We may need to find a similar function in bionic for doing
> this.
The adjtimex patch on the ml will probably solve this. I'll take a look
at that patch nextish.
> 4) struct in6_pktinfo is defined in connman code (file
> gdhcp/common.h)
> under #ifndef __USE_GNU. Now this structure is defined in bionic
> header file libc/kernel/uapi/ipv6.h. Not sure what is the intent of
> #ifndef __USE_GNU? Should this go away? Similarly struct in6_ifreq is
> defined in inet.c file and it is also defined in the same bionic
> header file. I had to comment out this definition to compile connman.
See commit message for?e8784053a0a680ec8943ff20559c6561cb5b9a96.
For?struct in6_ifreq it looks like very old code that should be fixed.
> 5) Some of the structures which are needed for connman compilation
> are
> defined under #ifdef __USE_BSD in bionic header file. For Bionic
> __USE_BSD is defined only if _GNU_SOURCE is defined. So for those
> files in connman we have to define _GNU_SOURCE as the first line in
> that file. Example is ipv4ll.c. I hope this should be OK.
I'd like to keep the files as clean as possible. Looking at autoconf
magic, it seems to be possible to use?AC_DEFINE to add values to the
generated config.h file, which is included first. config.h is used
everywhere and should be the first file included. So could one add the
needed defines in order to config.h with AC_DEFINE instead? And/or the
use of bionic, if needed?
> 6) GResolv structure in gresolv.c: struct __res_state is a member for
> GResolv structure. This structure is defined in resolv.h file in
> glibc. struct __res_state in bionic requires inclusion of two other
> header files resolv_private.h and res_private. Also this structure is
> defined very differently between bionic and glibc. This caused
> changes
> in gresolv.c, the way it accesses various members of this structure.
Ok, sounds a bit more complicated. You should perhaps post an RFC patch
for this so we have an idea of how complicated it becomes.
> 7) Struct sockaddr_in6 defined differently b/w bionic and glibc.
What is the difference here? Something that does not compile on both
"platforms"?
> 8) ETH_ALEN is not defined in bionic header file
Should be easy once we know bionic is being used.
> 9) Need to include resolv_params.h in resolver.c. This is because
> "MAXDNSRCH" etc is defined in resolv_params.h in bionic.
Automake/conf magic, I hope.
> 10) Needed to remove "-lresolv -lrt" from Makefile.am.
As above, I hope.
> Some of these changes are easily doable if we can have #ifdef ANDROID
> in code. Through configure.ac we can detect if we are compiling
> against bionic or glibc and appropriately turn on this flag. Not sure
> what your thought are on this.
I'd go for configure.ac, it makes the code cleaner and uses
autoconf/automake for it's intended purpose. Let's start with the easy
parts first.
Thanks for the heads up!
Patrik
------------------------------
Message: 4
Date: Tue, 09 Aug 2016 16:19:15 +0300
From: Patrik Flykt <[email protected]>
To: Sam Nazarko <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: [PATCH][v2] resolver: ensure that resolv.conf is
populated with search domains and DNS servers in the correct order
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Fri, 2016-07-22 at 08:12 +0000, Sam Nazarko wrote:
> From 814d51ce06c8a44026e1265b62e3cdd818a3be72 Mon Sep 17 00:00:00
> 2001
> From: Sam Nazarko <[email protected]>
> Date: Thu, 21 Jul 2016 15:59:48 +0100
> Subject: [PATCH] resolver: ensure that resolv.conf is populated with
> search
> ?domains and DNS servers in the correct order
>
> Signed-off-by: Sam Nazarko <[email protected]>
> ---
> ?src/resolver.c | 8 ++++----
> ?1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/resolver.c b/src/resolver.c
> index fbe4be7..c4adbc6 100644
> --- a/src/resolver.c
> +++ b/src/resolver.c
> @@ -100,9 +100,9 @@ static int resolvfile_export(void)
> ?????????* MAXDNSRCH/MAXNS entries are used.
> ?????????*/
> ?
> -???????for (count = 0, list = g_list_last(resolvfile_list);
> +???????for (count = 0, list = g_list_first(resolvfile_list);
> ????????????????????????????????????????????????list && (count <
> MAXDNSRCH);
> -???????????????????????????????????????????????list =
> g_list_previous(list)) {
> +???????????????????????????????????????????????list =
> g_list_next(list)) {
> ????????????????struct resolvfile_entry *entry = list->data;
> ?
> ????????????????if (!entry->domain)
> @@ -118,9 +118,9 @@ static int resolvfile_export(void)
> ????????if (count)
> ????????????????g_string_append_printf(content, "\n");
> ?
> -???????for (count = 0, list = g_list_last(resolvfile_list);
> +???????for (count = 0, list = g_list_first(resolvfile_list);
> ????????????????????????????????????????????????list && (count <
> MAXNS);
> -???????????????????????????????????????????????list =
> g_list_previous(list)) {
> +???????????????????????????????????????????????list =
> g_list_next(list)) {
> ????????????????struct resolvfile_entry *entry = list->data;
> ?
> ????????????????if (!entry->server)
I didn't get this patch to apply to upstream, maybe you had an older
version in use? That said, I was to add a commit message like so:
resolver: Ensure resolv.conf is populated in correct order
This patch fixes an issue where DNS servers and search domains are
written to resolv.conf in the reverse order. This has caused problems
with some OSMC users that have relied on the primary DNS server to be
listed first and have a faulty or intermittent secondary DNS server.
Despite the working status of the DNS servers, we should still respect
the ordering that is configured or received via DHCP.
Ensure resolv.conf is populated with search domains and DNS servers in
the correct order.
Cheers,
Patrik
------------------------------
Message: 5
Date: Tue, 09 Aug 2016 16:22:39 +0300
From: Patrik Flykt <[email protected]>
To: Jaakko Hannikainen <[email protected]>,
[email protected]
Subject: Re: [PATCH] config: Fix indentation
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Thu, 2016-07-14 at 13:13 +0300, Jaakko Hannikainen wrote:
> gcc 6.1.1 complains about misleading indentation and halts because of
> -Werror. Fix the indentation.
Applied, thanks!
Patrik
------------------------------
Message: 6
Date: Tue, 09 Aug 2016 16:23:45 +0300
From: Patrik Flykt <[email protected]>
To: Justin Maggard <[email protected]>, [email protected]
Cc: Justin Maggard <[email protected]>
Subject: Re: [PATCH] ntp: Use adjtimex to tune the kernel clock
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2016-07-18 at 11:14 -0700, Justin Maggard wrote:
> Replace adjtime()/gettimeofday() calls with the RFC 5905 clock
> adjustment algorithm implemented by adjtimex().??This also allows us
> to
> support leap seconds sent from an NTP server.
Applied, thanks!
Patrik
------------------------------
Message: 7
Date: Tue, 09 Aug 2016 16:31:51 +0300
From: Patrik Flykt <[email protected]>
To: Justin Maggard <[email protected]>, [email protected]
Cc: Justin Maggard <[email protected]>
Subject: Re: [PATCH] rtnl: Treat bond interfaces as ethernet
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2016-07-18 at 11:14 -0700, Justin Maggard wrote:
> Since Linux 3.9, the kernel started setting the sysfs DEVTYPE for
> bond
> interfaces to 'bond', which made connman start classifying the
> service
> type and device type as UNKNOWN.??So we need to handle DEVTYPE=bond
> so
> we can configure bond inferfaces on modern kernels.
And applied!
Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 10, Issue 4
**************************************
