Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/3] Use AC_USE_SYSTEM_EXTENSIONS (Burton, Ross)
2. Re: storage handling (Patrik Flykt)
3. [PATCH 1/2] doc: Fix service's Security property type to
"string" (Peter Meerwald-Stadler)
4. [PATCH 2/2] doc: Spellchecking plugin-api.txt
(Peter Meerwald-Stadler)
5. Re: storage handling (wangfe-nestlabs)
----------------------------------------------------------------------
Message: 1
Date: Wed, 10 Aug 2016 20:08:28 +0100
From: "Burton, Ross" <[email protected]>
To: Marcel Holtmann <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/3] Use AC_USE_SYSTEM_EXTENSIONS
Message-ID:
<cajto0lysxb9bq6mv4qwrct6o36jjosrn_p4pz2rsucfxgb9...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
On 10 August 2016 at 11:30, Marcel Holtmann <[email protected]> wrote:
> so my preference was to define _GNU_SOURCE manually in each *.c file as
> described by the manpages. For example:
>
> SYNOPSIS
> #define _GNU_SOURCE /* See feature_test_macros(7) */
> #include <stdio.h>
>
> int asprintf(char **strp, const char *fmt, ...);
>
Surely the man pages say this because referencing AC_USE_SYSTEM_EXTENSIONS
would be endorsing autoconf over any other build system. Defining
_GNU_SOURCE manually per file is time consuming and unless the maintainers
do builds under musl before release, you risk releasing with broken builds
under musl.
Ross
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20160810/f0968fdb/attachment-0001.html>
------------------------------
Message: 2
Date: Thu, 11 Aug 2016 09:19:26 +0300
From: Patrik Flykt <[email protected]>
To: wangfe-nestlabs <[email protected]>
Cc: "Nakamura, Yusuke (ADITJ/SWG)" <[email protected]>,
"[email protected]" <[email protected]>, "Hoyer, Marko
(ADITG/SW2)" <[email protected]>, "Ishikawa, Tetsuri (ADITJ/SWG)"
<[email protected]>
Subject: Re: storage handling
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-08-10 at 10:34 -0700, wangfe-nestlabs wrote:
> Just a reminder,? there is statistic file ?data? in the service_name
> directory is updated.?
> And I would like add a compile flag to disable it.??
> Patrick, what is your opinion?
I don't want to remove the statistics.
And also the statistics handling needs some work in order to function
more properly if there are no counters registered. Right now the
statistics aren't updated more than once for a connected service when
no counters are registered IIRC.
Cheers,
Patrik
------------------------------
Message: 3
Date: Thu, 11 Aug 2016 13:43:48 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: [PATCH 1/2] doc: Fix service's Security property type to
"string"
Message-ID: <[email protected]>
---
doc/service-api.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/doc/service-api.txt b/doc/service-api.txt
index e2e9e84..bf365f6 100644
--- a/doc/service-api.txt
+++ b/doc/service-api.txt
@@ -180,7 +180,7 @@ Properties string State [readonly]
Together with a missing Name property, this can
be used to identify hidden WiFi networks.
- array{string} Security [readonly]
+ string Security [readonly]
If the service type is WiFi, then this property is
present and contains the list of security methods
--
2.7.4
------------------------------
Message: 4
Date: Thu, 11 Aug 2016 13:43:49 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: [PATCH 2/2] doc: Spellchecking plugin-api.txt
Message-ID: <[email protected]>
---
doc/plugin-api.txt | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/doc/plugin-api.txt b/doc/plugin-api.txt
index 616938b..ea5ec0a 100644
--- a/doc/plugin-api.txt
+++ b/doc/plugin-api.txt
@@ -37,7 +37,7 @@ Technology infrastructure
A Technology in ConnMan is an abstract representation of the different
kinds of technologies it supports such as WiFi, Ethernet, Bluetooth and
-Celullar. The technologies support are added to ConnMan through plugins, such
+Celullar. The technologies supported are added to ConnMan through plugins, such
as plugins/bluetooth.c for the Bluetooth Technology or plugins/wifi.c for the
WiFi Technology. Each new technology plugin needs to register itself as a
Technology with ConnMan. As an example we will take a look at the Bluetooth
@@ -65,7 +65,7 @@ plugin initialization function, bluetooth_init() in this
example:
connman_technology_driver_register(&tech_driver);
-In this document the error check is supressed for the sake of simplicity.
+In this document the error check is suppressed for the sake of simplicity.
All plugins should check return values in driver registration functions.
After this call ConnMan becomes aware of the new Technology plugin and will
@@ -74,7 +74,7 @@ the Bluetooth plugin for example probe() would be called when
a Bluetooth
adapter is recognized. A Technology is only probed if there exists at least
one device of such technology plugged into the system.
-Complementary, the technology must be unregistered on the plugin exit function
+Complementary, the technology must be unregistered by the plugin exit function
through 'connman_technology_driver_unregister()'.
Device infrastructure
@@ -101,7 +101,7 @@ And to register the driver:
'connman_device_driver_register()' is called during the plugin initialization
process, not necessarily at the plugin init function.
-In this document the error check is supressed for the sake of simplicity.
+In this document the error check is suppressed for the sake of simplicity.
All plugins should check return values in driver registration functions.
Additionally code to handle the detection of new devices needs to be written
@@ -130,7 +130,7 @@ its API documentation.
Network infrastructure
======================
-The Connection Manager provides a mean to plugins handle the specifics of
+The Connection Manager provides a means to plugins to handle the specifics of
establishing/handling a connection for each type of Technology. For the
bluetooth plugin a connman_network_driver needs to be registered:
@@ -147,12 +147,12 @@ And then call the register function:
connman_network_driver_register(&network_driver);
-In this document the error check is supressed for the sake of simplicity.
+In this document the error check is suppressed for the sake of simplicity.
All plugins should check return values in driver registration functions.
The next step would be the probe of a Network entity, for the bluetooth
plugin this would happen when a new device that supports the PAN NAP role is
-paired with the system. ConnMan then call connman_device_add_network() to
+paired with the system. ConnMan then calls connman_device_add_network() to
associate the new Network with the existing Device entity (the local Bluetooth
Adapter).
--
2.7.4
------------------------------
Message: 5
Date: Thu, 11 Aug 2016 10:44:13 -0700
From: wangfe-nestlabs <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: "Nakamura, Yusuke (ADITJ/SWG)" <[email protected]>,
"[email protected]" <[email protected]>, "Hoyer, Marko
(ADITG/SW2)" <[email protected]>, "Ishikawa, Tetsuri (ADITJ/SWG)"
<[email protected]>
Subject: Re: storage handling
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Hi Patrik,
My proposal is to add a configurable flag to enable/disable the statistics. It
will be enabled by default. Thus if it is not needed, user can remove it to
save some code space and reduce the writing to the ?data? file.
It will provide some benefit and no harm. What do you think?
Thanks,
Feng
> On Aug 10, 2016, at 11:19 PM, Patrik Flykt <[email protected]>
> wrote:
>
> On Wed, 2016-08-10 at 10:34 -0700, wangfe-nestlabs wrote:
>> Just a reminder, there is statistic file ?data? in the service_name
>> directory is updated.
>> And I would like add a compile flag to disable it.
>> Patrick, what is your opinion?
>
> I don't want to remove the statistics.
>
> And also the statistics handling needs some work in order to function
> more properly if there are no counters registered. Right now the
> statistics aren't updated more than once for a connected service when
> no counters are registered IIRC.
>
>
> Cheers,
>
> Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 10, Issue 7
**************************************
