Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH 1/2] ntp: Fix potentially leaked addrinfo
(Peter Meerwald-Stadler)
2. [PATCH 2/2] dhcp: Remove dead code (Peter Meerwald-Stadler)
----------------------------------------------------------------------
Message: 1
Date: Thu, 18 Aug 2016 18:18:48 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: [PATCH 1/2] ntp: Fix potentially leaked addrinfo
Message-ID: <[email protected]>
CID 1352476
---
src/ntp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/ntp.c b/src/ntp.c
index 9b1bb4f..bb15792 100644
--- a/src/ntp.c
+++ b/src/ntp.c
@@ -477,15 +477,15 @@ static void start_ntp(char *server)
hint.ai_socktype = SOCK_DGRAM;
hint.ai_flags = AI_NUMERICHOST | AI_PASSIVE;
ret = getaddrinfo(server, NULL, &hint, &info);
-
if (ret) {
connman_error("cannot get server info");
return;
}
family = info->ai_family;
-
memcpy(×erver_addr, info->ai_addr, info->ai_addrlen);
+ freeaddrinfo(info);
+
memset(&in6addr, 0, sizeof(in6addr));
if (family == AF_INET) {
@@ -503,7 +503,6 @@ static void start_ntp(char *server)
connman_error("Family is neither ipv4 nor ipv6");
return;
}
- freeaddrinfo(info);
DBG("server %s family %d", server, family);
--
2.7.4
------------------------------
Message: 2
Date: Thu, 18 Aug 2016 18:18:49 +0200
From: Peter Meerwald-Stadler <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: [email protected]
Subject: [PATCH 2/2] dhcp: Remove dead code
Message-ID: <[email protected]>
CID 1230769
---
gdhcp/client.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/gdhcp/client.c b/gdhcp/client.c
index fbb40ab..e9e38e7 100644
--- a/gdhcp/client.c
+++ b/gdhcp/client.c
@@ -2351,10 +2351,6 @@ static gboolean listener_event(GIOChannel *channel,
GIOCondition condition,
return TRUE;
}
- if (!message_type && !client_id)
- /* No message type / client id option, ignore package */
- return TRUE;
-
debug(dhcp_client, "received DHCP packet xid 0x%04x "
"(current state %d)", ntohl(xid), dhcp_client->state);
--
2.7.4
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 10, Issue 22
***************************************
