Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] rfkill: Open /dev/rfkill read-only if we are only
reading from it (Patrik Flykt)
2. Re: [PATCH] technology: avoid redundant saving to the file
system (Patrik Flykt)
3. Re: [PATCH v0 0/2] OpenVPN logging (Patrik Flykt)
4. Re: [PATCH v0 0/3] nftable session fixes (Patrik Flykt)
5. Re: [PATCH] service: Use PreferredTechnologies for service
ordering (Patrik Flykt)
6. Re: [PATCH 03/16] ntp: Fix unused value (Patrik Flykt)
7. Re: [PATCH 08/16] build: Fix whitespace Makefile.am (Patrik Flykt)
8. Re: [PATCH 1/1] Fix nameserver and search domain ordering
when writing resolv.conf (Patrik Flykt)
9. Re: [PATCH 1/3] docs: update manager-api.txt to include
BrowserOnly Key (Patrik Flykt)
10. Re: FW: [PATCH] dhcp: Follow the RFC regarding ordrer of
"subnet" and "router" option (Patrik Flykt)
11. [PATCH] gweb: fix crash on malformed http response (Mans Rullgard)
12. Re: [PATCH] gweb: fix crash on malformed http response
(Patrik Flykt)
13. Re: [PATCH] gweb: Do not lookup for a NULL key in a hash
table (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Wed, 05 Oct 2016 12:47:31 +0300
From: Patrik Flykt <[email protected]>
To: Slava Monich <[email protected]>, [email protected]
Subject: Re: [PATCH] rfkill: Open /dev/rfkill read-only if we are only
reading from it
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Sat, 2016-09-17 at 13:14 +0300, Slava Monich wrote:
> ---
> ?src/rfkill.c | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Patrik
------------------------------
Message: 2
Date: Wed, 05 Oct 2016 12:47:57 +0300
From: Patrik Flykt <[email protected]>
To: Yusuke Nakamura <[email protected]>, [email protected]
Subject: Re: [PATCH] technology: avoid redundant saving to the file
system
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2016-09-19 at 14:32 +0900, Yusuke Nakamura wrote:
> ????Even if OfflineMode is the same as before, Connman always saves
> ????to the file system. This patch makes Connman to save OfflineMode
> ????only when it is actually changed in order to avoid redundant data
> ????writing.
> ---
> ?src/technology.c |???22 +++++++++++++++++++---
> ?1 file changed, 19 insertions(+), 3 deletions(-)
Applied, thanks!
Patrik
------------------------------
Message: 3
Date: Wed, 05 Oct 2016 12:48:42 +0300
From: Patrik Flykt <[email protected]>
To: Daniel Wagner <[email protected]>, [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: Re: [PATCH v0 0/2] OpenVPN logging
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-06-08 at 09:54 +0200, Daniel Wagner wrote:
> From: Daniel Wagner <[email protected]>
>
> Hi,
>
> I am debugging some network setups here and found out that we don't
> log anything from OpenVPN which is pretty sad. Let's fix this.
Applied, thanks!
Patrik
------------------------------
Message: 4
Date: Wed, 05 Oct 2016 12:49:44 +0300
From: Patrik Flykt <[email protected]>
To: Daniel Wagner <[email protected]>, [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: Re: [PATCH v0 0/3] nftable session fixes
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Thu, 2016-09-29 at 10:22 +0200, Daniel Wagner wrote:
> From: Daniel Wagner <[email protected]>
>
> Hi,
>
> The first patch removes the connection tracking code from ConnMan. We
> never really used it. It looks like we are soon having means to
> enforce network activies via cgroups (eBPF) thanks to Daniel Macks
> work [1]. So I think its better to have this kind of enforcement in
> an
> external component.
>
> The second patch does add a warning when nftables fails. It took me a
> while to figure out what's going on when I forgot to load the right
> module. So why not just be userfriendly.
>
> The last patch moves the marking rule to the route table. I just
> placed it iniatially into the filter chain. That was wrong. With
> this,
> the packets are routed acording the session settings.
Applied, thanks! And with v1 for 1/3.
Patrik
------------------------------
Message: 5
Date: Wed, 05 Oct 2016 12:50:19 +0300
From: Patrik Flykt <[email protected]>
To: Maxime Chevallier <[email protected]>,
[email protected]
Subject: Re: [PATCH] service: Use PreferredTechnologies for service
ordering
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2016-09-20 at 16:42 +0200, Maxime Chevallier wrote:
> When services have the same state, the PreferredTechnologies list
> needs
> to be taken into account for service ordering. This applies when all
> services are 'ready' but none is 'online'.
>
> This patch checks for services in PreferredTechnologies before
> defaulting to the hardcoded list in service_compare.
> ---
Applied, thanks!
Patrik
------------------------------
Message: 6
Date: Wed, 05 Oct 2016 12:50:54 +0300
From: Patrik Flykt <[email protected]>
To: Peter Meerwald-Stadler <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 03/16] ntp: Fix unused value
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Sat, 2016-09-17 at 13:05 +0200, Peter Meerwald-Stadler wrote:
> msg.poll is assigned twice, the first assignment should probably be
> a comment
>
> RFC5905 specifies MINPOLL 6 and MAXPOLL 17
>
> CID 1352485
Applied this 03/16, thanks!
Patrik
------------------------------
Message: 7
Date: Wed, 05 Oct 2016 12:51:42 +0300
From: Patrik Flykt <[email protected]>
To: Peter Meerwald-Stadler <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 08/16] build: Fix whitespace Makefile.am
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Sat, 2016-09-17 at 13:05 +0200, Peter Meerwald-Stadler wrote:
> ---
> ?Makefile.am | 2 +-
> ?1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Patrik
------------------------------
Message: 8
Date: Wed, 05 Oct 2016 12:53:14 +0300
From: Patrik Flykt <[email protected]>
To: Sam Nazarko <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: [PATCH 1/1] Fix nameserver and search domain ordering
when writing resolv.conf
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Thu, 2016-07-21 at 17:39 +0000, Sam Nazarko wrote:
> diff --git a/src/resolver.c b/src/resolver.c
> index fbe4be7..c4adbc6 100644
> --- a/src/resolver.c
> +++ b/src/resolver.c
Had some problems getting this applied, banged on it a bit. Now
applied, thanks!
Patrik
------------------------------
Message: 9
Date: Wed, 05 Oct 2016 13:34:06 +0300
From: Patrik Flykt <[email protected]>
To: Atul Anand <[email protected]>, [email protected]
Subject: Re: [PATCH 1/3] docs: update manager-api.txt to include
BrowserOnly Key
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Mon, 2016-08-29 at 13:55 +0530, Atul Anand wrote:
> It has been documented that we are adding a new dict key BrowserOnly
> on PACrunner DBus interface.
> ---
All three patches applied, thanks! Updated patch 2/3 so it compiles
test cases also.
Patrik
------------------------------
Message: 10
Date: Wed, 05 Oct 2016 13:57:35 +0300
From: Patrik Flykt <[email protected]>
To: Kristian Klausen <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: FW: [PATCH] dhcp: Follow the RFC regarding ordrer of
"subnet" and "router" option
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Fri, 2016-09-30 at 13:24 +0200, Kristian Klausen wrote:
> Resending because it seems like I need to be subscribed, before I can
> post.
> and it impossible to get in contact with any Connman dev (which could
> check the mail, and allow it to be posted).. At least on #connman on
> freenode.
Patch was availabe at https://anonscm.debian.org/cgit/collab-maint/conn
man.git/plain/debian/patches/dhcp-follow-rfc.patch?and applied. Thanks!
Patrik
------------------------------
Message: 11
Date: Wed, 5 Oct 2016 13:17:00 +0100
From: Mans Rullgard <[email protected]>
To: [email protected]
Subject: [PATCH] gweb: fix crash on malformed http response
Message-ID: <[email protected]>
If an http response has a line starting with whitespace before the first
valid header field, g_hash_table_lookup() is called with a null key,
which is invalid. Fix this by checking for a valid last_key before
attempting to process continuation lines.
---
gweb/gweb.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/gweb/gweb.c b/gweb/gweb.c
index 6ce5028ad57c..10e8c8fe0b8d 100644
--- a/gweb/gweb.c
+++ b/gweb/gweb.c
@@ -792,6 +792,9 @@ static void handle_multi_line(struct web_session *session)
char *str;
gchar *value;
+ if (!session->result.last_key)
+ return;
+
str = session->current_header->str;
if (str[0] != ' ' && str[0] != '\t')
--
2.10.0
------------------------------
Message: 12
Date: Wed, 05 Oct 2016 15:28:50 +0300
From: Patrik Flykt <[email protected]>
To: Mans Rullgard <[email protected]>, [email protected]
Subject: Re: [PATCH] gweb: fix crash on malformed http response
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2016-10-05 at 13:17 +0100, Mans Rullgard wrote:
> If an http response has a line starting with whitespace before the
> first
> valid header field, g_hash_table_lookup() is called with a null key,
> which is invalid.??Fix this by checking for a valid last_key before
> attempting to process continuation lines.
Applied, thanks! Updated the commit message to mention Tomasz and
Marcel Mulder.
Patrik
------------------------------
Message: 13
Date: Wed, 05 Oct 2016 15:29:47 +0300
From: Patrik Flykt <[email protected]>
To: M?ns Rullg?rd <[email protected]>, Tomasz Bursztyka
<[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] gweb: Do not lookup for a NULL key in a hash
table
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Sat, 2016-10-01 at 15:50 +0100, M?ns Rullg?rd wrote:
> Tomasz Bursztyka <[email protected]> writes:
>
> >
> > At this position, no key might have been provided yet.
> >
> > Reported by Marcel Mulder <[email protected]>
> > ---
> >
> > Hi Marcel,
> >
> > Does that helps?
> >
> > Btw the logs you provided are missing the gweb parts.
> > Could you run connman like: CONNMAN_WEB_DEBUG=1 connmnand <your
> > options>
>
> Did this ever get fixed properly?
Yes, by you a minute ago. Replying to this thread also that it is now
fixed.
Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 12, Issue 3
**************************************
