Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/2][v2] stats: Fix bad file descriptor
initialisation (Daniel Wagner)
2. Re: [PATCH 2/2] stats: cleanup of stats file error handling
(Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Wed, 26 Oct 2016 20:08:13 +0200
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH 1/2][v2] stats: Fix bad file descriptor
initialisation
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
On 10/26/2016 07:13 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> Stats file code initialises its file descriptor field to 0.
> But 0 is a valid fd value. -1 should be used instead.
> This causes problems when an error happens before a stats file is open
> (e.g. mkdir fails). The clean-up procedure, stats_free() calls close(fd).
> When fd is 0, this first closes stdin, and then any files/sockets which
> received fd=0, re-used by the OS.
>
> Fixed several instances of bad file descriptor field handling,
> in case of errors.
Applied.
Thanks,
Daniel
------------------------------
Message: 2
Date: Wed, 26 Oct 2016 20:09:09 +0200
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH 2/2] stats: cleanup of stats file error handling
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
On 10/26/2016 07:13 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> Moved mkdir before a stats file is created, to avoid
> unnecessary further steps in case it fails.
> Removed unnecessary conditions in clean-up.
I splitted into two patches and applied. Please check if I screwed it up.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 12, Issue 30
***************************************
