Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: Support fro strongswan in Connman (Florent Le Saout)
2. Spurious failures starting ConnMan with systemd (Robert Tiemann)
3. Re: Support fro strongswan in Connman (Daniel Wagner)
4. Re: [PATCH v2] service: Update nameservers automatically
(Daniel Wagner)
5. Re: Spurious failures starting ConnMan with systemd
(Daniel Wagner)
6. [PATCH v1 0/7] Too many DBG() on default (Daniel Wagner)
7. [PATCH v1 2/7] ipconfig: Remove noisy DBGs (Daniel Wagner)
8. [PATCH v1 4/7] storage: Remove noisy DBG (Daniel Wagner)
9. [PATCH v1 1/7] service: Remove noisy DBGs (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Fri, 11 Nov 2016 10:51:51 +0100
From: Florent Le Saout <[email protected]>
To: Daniel Wagner <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: Support fro strongswan in Connman
Message-ID: <[email protected]>
Content-Type: text/plain; charset="windows-1252"
Hi Daniel,
Yes I get it ;)
I will try to work on that.
Do you have any idea how much work such plugin could require ?
How big this could be, from your point of view ?
Thanks,
Florent.
On 10/11/2016 19:19, Daniel Wagner wrote:
> Hi Florent,
>
> On 11/10/2016 05:16 PM, Florent Le Saout wrote:
>> I'm using Strongswan for IPsec and connman as network manager.
>>
>> It seems that there is no support for strongswan in Connman ?
>
> Yes, it looks like we don't do strongswan yet.
>
>> If so then is there any plan to integrate it at some point, or any work
>> on that already ongoing ?
>
> I haven't heard or seen anyone working on such a plugin. Obviously, we
> wouldn't mind if someone would build such a plugin :)
>
> cheers,
> daniel
--
*Florent LE SAOUT*
R&D department
Embedded Software Developer
AUSY contractor for KERLINK
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20161111/5eb45cd1/attachment-0001.html>
------------------------------
Message: 2
Date: Fri, 11 Nov 2016 11:05:01 +0100
From: Robert Tiemann <[email protected]>
To: [email protected]
Subject: Spurious failures starting ConnMan with systemd
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
I am working on a system based on Yocto Project which uses ConnMan
v1.33 for network management. The system uses systemd and generally
works well so far, but once in a blue moon ConnMan fails to start up.
Here is the relevant log from systemd:
[ 15.886270] systemd[1]: connman.service: Main process exited,
code=exited, status=1/FAILURE
[ 15.912838] systemd[1]: Failed to start Connection service.
There were no logs from connmand in this case, so in the
connman.service file I've added the -d option to ExecStart= and set
StandardOutput to syslog. I have restarted the system many times until
the failure occurred again. There is only a single line from connmand
in the log:
[ 12.174528] connmand[278]: Failed to connect to socket
/var/run/dbus/system_bus_socket: No such file or directory
[ 12.209448] systemd[1]: connman.service: Main process exited,
code=exited, status=1/FAILURE
[ 12.242872] systemd[1]: Failed to start Connection service.
So the system D-Bus is not up and running the time ConnMan is started.
In case of failure, I've noticed there is also no mentioning about
D-Bus starting up in the log, but in all other logs there is.
Now, I think the After=dbus.service line in src/connman.service.in is
not enough because After= specifies order, but not a requirement
dependency. This what Requires= is there for. I've added the line
Requires=dbus.service
to the service file, reverted my other changes, and tried again. I've
been unable to reproduce the problem ever since, so for me the problem
seems to be fixed.
What do you think? Should src/connman.service.in be changed to include
the Requires= line by default or is this something to be fixed
somewhere else?
Should network-pre.target and systemd-sysusers.service be added to
Requires= as well?
Kind regards,
Robert
------------------------------
Message: 3
Date: Fri, 11 Nov 2016 11:05:09 +0100
From: Daniel Wagner <[email protected]>
To: Florent Le Saout <[email protected]>,
"[email protected]" <[email protected]>
Subject: Re: Support fro strongswan in Connman
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Florent,
On 11/11/2016 10:51 AM, Florent Le Saout wrote:
> Yes I get it ;)
:)
> I will try to work on that.
Nice.
> Do you have any idea how much work such plugin could require ?
Not sure, it depends heavily on the kind of API strongswan is using. For
example OpenVPN is quite easy (see connman/vpn/plugins/openvpn.c).
The plugin starts the daemon and waits for feedback via the
connman/scripts/openvpn-script.c.
> How big this could be, from your point of view ?
I don't expect that it will be a big thing(TM) (though I haven't played
with IPsec so far). We have already a couple of plugins for vpn daemons.
Just try to steal the bits from the existing code if possible. Shouldn't
be too hard to get an initial code base up and running (check also the
commit history for the plugins). Don't wait too long with posting the
code. Rather send early some RFC so that we can help you.
cheers,
daniel
------------------------------
Message: 4
Date: Fri, 11 Nov 2016 11:56:36 +0100
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Patrik Flykt <[email protected]>, [email protected]
Subject: Re: [PATCH v2] service: Update nameservers automatically
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Thanks everyone, patch applied.
Daniel
------------------------------
Message: 5
Date: Fri, 11 Nov 2016 12:04:53 +0100
From: Daniel Wagner <[email protected]>
To: Robert Tiemann <[email protected]>, [email protected]
Subject: Re: Spurious failures starting ConnMan with systemd
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi
On 11/11/2016 11:05 AM, Robert Tiemann wrote:
> Now, I think the After=dbus.service line in src/connman.service.in is
> not enough because After= specifies order, but not a requirement
> dependency. This what Requires= is there for. I've added the line
>
> Requires=dbus.service
>
> to the service file, reverted my other changes, and tried again. I've
> been unable to reproduce the problem ever since, so for me the problem
> seems to be fixed.
I am no systemd expert. I just did a quick read in the documentation and
it seems it is recommended to have After= and Requires= together:
https://www.freedesktop.org/software/systemd/man/systemd.unit.html
"""
Before=, After=
A space-separated list of unit names. Configures ordering
dependencies between units. If a unit foo.service contains a setting
Before=bar.service and both units are being started, bar.service's
start-up is delayed until foo.service is started up. Note that this
setting is independent of and orthogonal to the requirement dependencies
as configured by Requires=. It is a common pattern to include a unit
name in both the After= and Requires= option, in which case the unit
listed will be started before the unit that is configured with these
options.
"""
Care to send a patch which adds Requires=? Please include your excellent
error report into the commit message.
Thanks,
Daniel
------------------------------
Message: 6
Date: Fri, 11 Nov 2016 13:20:54 +0100
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH v1 0/7] Too many DBG() on default
Message-ID: <[email protected]>
From: Daniel Wagner <[email protected]>
This series drops a bunch of very noisy DBGs. None of them
really adds a real value except the dnsproxy ones. For those
I decided to follow the pattern I found in gdhcp and gweb.
I converted most of the DBGs to debug and defined it as empty
macro. That allows anyone hacking on dnsproxy to get some
inside.
With all patches applied I am able to see again whats happening
without spammed away.
cheers,
daniel
Daniel Wagner (7):
service: Remove noisy DBGs
ipconfig: Remove noisy DBGs
dnsproxy: Disable noisy DBGs
storage: Remove noisy DBG
network: Remove noisy DBGs and merge one
wispr: Merge two DBGs into one
rtnl: Remove useless DBG
src/dnsproxy.c | 154 +++++++++++++++++++++++++++++----------------------------
src/ipconfig.c | 34 +------------
src/network.c | 24 +--------
src/rtnl.c | 2 -
src/service.c | 8 +--
src/storage.c | 2 -
src/wispr.c | 4 +-
7 files changed, 85 insertions(+), 143 deletions(-)
--
2.7.4
------------------------------
Message: 7
Date: Fri, 11 Nov 2016 13:20:56 +0100
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH v1 2/7] ipconfig: Remove noisy DBGs
Message-ID: <[email protected]>
From: Daniel Wagner <[email protected]>
These DBGs are very noisy in the log and don't provide any real
value. Furthermore, the users of ipconfig usually print the information
already.
---
src/ipconfig.c | 34 ++--------------------------------
1 file changed, 2 insertions(+), 32 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 0dc702b0b04a..7fdc024e4fa8 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1106,8 +1106,6 @@ static struct connman_ipconfig *create_ipv6config(int
index)
struct connman_ipconfig *ipv6config;
struct connman_ipdevice *ipdevice;
- DBG("index %d", index);
-
ipv6config = g_try_new0(struct connman_ipconfig, 1);
if (!ipv6config)
return NULL;
@@ -1134,7 +1132,7 @@ static struct connman_ipconfig *create_ipv6config(int
index)
ipv6config->system = connman_ipaddress_alloc(AF_INET6);
- DBG("ipconfig %p method %s", ipv6config,
+ DBG("ipconfig %p index %d method %s", ipv6config, index,
__connman_ipconfig_method2string(ipv6config->method));
return ipv6config;
@@ -1155,8 +1153,6 @@ struct connman_ipconfig *__connman_ipconfig_create(int
index,
if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
return create_ipv6config(index);
- DBG("index %d", index);
-
ipconfig = g_try_new0(struct connman_ipconfig, 1);
if (!ipconfig)
return NULL;
@@ -1174,7 +1170,7 @@ struct connman_ipconfig *__connman_ipconfig_create(int
index,
ipconfig->system = connman_ipaddress_alloc(AF_INET);
- DBG("ipconfig %p", ipconfig);
+ DBG("ipconfig %p index %d", ipconfig, index);
return ipconfig;
}
@@ -1307,8 +1303,6 @@ enum connman_ipconfig_method
__connman_ipconfig_get_method(
int __connman_ipconfig_address_add(struct connman_ipconfig *ipconfig)
{
- DBG("");
-
switch (ipconfig->method) {
case CONNMAN_IPCONFIG_METHOD_UNKNOWN:
case CONNMAN_IPCONFIG_METHOD_OFF:
@@ -1332,13 +1326,9 @@ int __connman_ipconfig_address_remove(struct
connman_ipconfig *ipconfig)
{
int err;
- DBG("");
-
if (!ipconfig)
return 0;
- DBG("method %d", ipconfig->method);
-
switch (ipconfig->method) {
case CONNMAN_IPCONFIG_METHOD_UNKNOWN:
case CONNMAN_IPCONFIG_METHOD_OFF:
@@ -1360,13 +1350,9 @@ int __connman_ipconfig_address_unset(struct
connman_ipconfig *ipconfig)
{
int err;
- DBG("");
-
if (!ipconfig)
return 0;
- DBG("method %d", ipconfig->method);
-
switch (ipconfig->method) {
case CONNMAN_IPCONFIG_METHOD_UNKNOWN:
case CONNMAN_IPCONFIG_METHOD_OFF:
@@ -1397,8 +1383,6 @@ int __connman_ipconfig_set_proxy_autoconfig(struct
connman_ipconfig *ipconfig,
{
struct connman_ipdevice *ipdevice;
- DBG("ipconfig %p", ipconfig);
-
if (!ipconfig || ipconfig->index < 0)
return -ENODEV;
@@ -1417,8 +1401,6 @@ const char
*__connman_ipconfig_get_proxy_autoconfig(struct connman_ipconfig *ipc
{
struct connman_ipdevice *ipdevice;
- DBG("ipconfig %p", ipconfig);
-
if (!ipconfig || ipconfig->index < 0)
return NULL;
@@ -1753,8 +1735,6 @@ int __connman_ipconfig_ipv6_set_privacy(struct
connman_ipconfig *ipconfig,
if (!ipconfig)
return -EINVAL;
- DBG("ipconfig %p privacy %s", ipconfig, value);
-
privacy = string2privacy(value);
ipconfig->ipv6_privacy_config = privacy;
@@ -1770,8 +1750,6 @@ void __connman_ipconfig_append_ipv4(struct
connman_ipconfig *ipconfig,
struct connman_ipaddress *append_addr = NULL;
const char *str;
- DBG("");
-
if (ipconfig->type != CONNMAN_IPCONFIG_TYPE_IPV4)
return;
@@ -1827,8 +1805,6 @@ void __connman_ipconfig_append_ipv6(struct
connman_ipconfig *ipconfig,
struct connman_ipaddress *append_addr = NULL;
const char *str, *privacy;
- DBG("");
-
if (ipconfig->type != CONNMAN_IPCONFIG_TYPE_IPV6)
return;
@@ -1885,8 +1861,6 @@ void __connman_ipconfig_append_ipv6config(struct
connman_ipconfig *ipconfig,
{
const char *str, *privacy;
- DBG("");
-
str = __connman_ipconfig_method2string(ipconfig->method);
if (!str)
return;
@@ -1929,8 +1903,6 @@ void __connman_ipconfig_append_ipv4config(struct
connman_ipconfig *ipconfig,
{
const char *str;
- DBG("");
-
str = __connman_ipconfig_method2string(ipconfig->method);
if (!str)
return;
@@ -1981,8 +1953,6 @@ int __connman_ipconfig_set_config(struct connman_ipconfig
*ipconfig,
DBusMessageIter dict;
int type = -1;
- DBG("ipconfig %p", ipconfig);
-
if (dbus_message_iter_get_arg_type(array) != DBUS_TYPE_ARRAY)
return -EINVAL;
--
2.7.4
------------------------------
Message: 8
Date: Fri, 11 Nov 2016 13:20:58 +0100
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH v1 4/7] storage: Remove noisy DBG
Message-ID: <[email protected]>
From: Daniel Wagner <[email protected]>
This DBGs is noisy in the log and doesn't provide any real
value.
---
src/storage.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/src/storage.c b/src/storage.c
index 7d031303b37f..5e877ef10375 100644
--- a/src/storage.c
+++ b/src/storage.c
@@ -43,8 +43,6 @@ static GKeyFile *storage_load(const char *pathname)
GKeyFile *keyfile = NULL;
GError *error = NULL;
- DBG("Loading %s", pathname);
-
keyfile = g_key_file_new();
if (!g_key_file_load_from_file(keyfile, pathname, 0, &error)) {
--
2.7.4
------------------------------
Message: 9
Date: Fri, 11 Nov 2016 13:20:55 +0100
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Subject: [PATCH v1 1/7] service: Remove noisy DBGs
Message-ID: <[email protected]>
From: Daniel Wagner <[email protected]>
These DBGs are very noisy in the log and don't provide any real
value. So let's remove them and make the log great again.
---
src/service.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/src/service.c b/src/service.c
index f6a76f6bb4a5..5304c0db72bd 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1665,8 +1665,6 @@ static void append_nameservers(DBusMessageIter *iter,
CONNMAN_IPCONFIG_TYPE_ALL,
servers[i]);
- DBG("servers[%d] %s available %d", i, servers[i], available);
-
if (available)
dbus_message_iter_append_basic(iter,
DBUS_TYPE_STRING, &servers[i]);
@@ -2928,8 +2926,6 @@ static DBusMessage *get_properties(DBusConnection *conn,
DBusMessage *reply;
DBusMessageIter array, dict;
- DBG("service %p", service);
-
reply = dbus_message_new_method_return(msg);
if (!reply)
return NULL;
@@ -4452,10 +4448,8 @@ static void service_schedule_removed(struct
connman_service *service)
static bool allow_property_changed(struct connman_service *service)
{
if (g_hash_table_lookup_extended(services_notify->add, service->path,
- NULL, NULL)) {
- DBG("no property updates for service %p", service);
+ NULL, NULL))
return false;
- }
return true;
}
--
2.7.4
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 13, Issue 13
***************************************
