Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] service: Don't auto connect if error is set for
service (Daniel Wagner)
2. Re: [RFC, v2] service: Update nameservers and timeservers
with changes in IP (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Thu, 5 Jan 2017 20:32:54 +0100
From: Daniel Wagner <[email protected]>
To: Patrik Flykt <[email protected]>, Saurav Babu
<[email protected]>, [email protected]
Cc: [email protected]
Subject: Re: [PATCH] service: Don't auto connect if error is set for
service
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
> Looks the right way to implement this. ACK but no testing done by me.
Great. I pushed the patch. Thanks for testing Saurav.
cheers,
daniel
------------------------------
Message: 2
Date: Thu, 5 Jan 2017 20:44:55 +0100
From: Daniel Wagner <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: M?ns Rullg?rd <[email protected]>, [email protected]
Subject: Re: [RFC, v2] service: Update nameservers and timeservers
with changes in IP
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Patrik,
On 12/08/2016 01:09 PM, M?ns Rullg?rd wrote:
> Patrik Flykt <[email protected]> writes:
>
>> When the IP address changes, nameservers need to be removed and
>> re-added in order for them to pick up the changed IP address. The
>> same applies to timeservers, restart the query for those as well.
>>
>> Reported by M?ns Rullg?rd.
>> ---
>>
>> Much less messing around with the code if implemented this way.
>>
>> Can you still test that it works identically to v1?
>
> This seems to work as well.
I tend to say the settings_changed() function is a bit cluttered. All
other calls to allow_property_changed() prevent any D-Bus updates to be
sent. Now we are starting to mix what settings_changed() does. It is not
only sending D-Bus messages but also driving ConnMan's internal state.
Maybe factoring the two things settings_changed() currently does into
small function would help. But that is just a minor thing. I could also
life with your version.
If you are happy with the current version I can apply it if you want. Or
do it yourself. Whatever :)
cheers,
daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 15, Issue 6
**************************************
