Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] connman.service.in: Drop CAP_KILL from upstream
service file (Patrik Flykt)
2. Re: [PATCH v3] service: Update nameservers and timeservers
with address change (Daniel Wagner)
3. Wi-Fi specific information in connman (Saurav Babu)
4. Re: Wi-Fi specific information in connman (Patrik Flykt)
5. Re: [PATCH v3] service: Update nameservers and timeservers
with address change (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Wed, 11 Jan 2017 13:01:31 +0200
From: Patrik Flykt <[email protected]>
To: [email protected]
Subject: [PATCH] connman.service.in: Drop CAP_KILL from upstream
service file
Message-ID: <[email protected]>
Upstream ConnMan uses only D-Bus to start external programs. The
CAP_KILL capability in the service file is not necessary and can
therefore be removed. ConnMan still has the capability of starting
other applications, if this is needed the capability needs to be
re-added to the distro or OS specific service file.
---
src/connman.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/connman.service.in b/src/connman.service.in
index 57eaaf96..9f5c10fe 100644
--- a/src/connman.service.in
+++ b/src/connman.service.in
@@ -13,7 +13,7 @@ BusName=net.connman
Restart=on-failure
ExecStart=@sbindir@/connmand -n
StandardOutput=null
-CapabilityBoundingSet=CAP_KILL CAP_NET_ADMIN CAP_NET_BIND_SERVICE CAP_NET_RAW
CAP_SYS_TIME CAP_SYS_MODULE
+CapabilityBoundingSet=CAP_NET_ADMIN CAP_NET_BIND_SERVICE CAP_NET_RAW
CAP_SYS_TIME CAP_SYS_MODULE
ProtectHome=true
ProtectSystem=full
--
2.11.0
------------------------------
Message: 2
Date: Wed, 11 Jan 2017 12:17:04 +0100
From: Daniel Wagner <[email protected]>
To: Patrik Flykt <[email protected]>, [email protected]
Subject: Re: [PATCH v3] service: Update nameservers and timeservers
with address change
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
Hi Patrik,
On 01/11/2017 11:06 AM, Patrik Flykt wrote:
> When the IP address changes, nameservers need to be removed and
> re-added in order for them to pick up the changed IP address. The
> same applies to timeservers, restart the query for those as well.
>
> Reported by M?ns Rullg?rd.
> ---
> src/service.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/src/service.c b/src/service.c
> index 2a714763..d78e0d0e 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -1389,6 +1389,18 @@ void __connman_service_nameserver_del_routes(struct
> connman_service *service,
> nameserver_del_routes(index, service->nameservers, type);
> }
>
> +static void address_updated(struct connman_service *service,
> + enum connman_ipconfig_type type)
> +{
> + if (is_connected_state(service, service->state) &&
> + service == __connman_service_get_default()) {
> + nameserver_remove_all(service, type);
> + nameserver_add_all(service, type);
> +
> + __connman_timeserver_sync(service);
> + }
> +}
Wouldn't it make sense to move the notifier call from settings_changed()
to address_updated()?
__connman_notifier_ipconfig_changed(service, ipconfig);
cheers,
daniel
------------------------------
Message: 3
Date: Wed, 11 Jan 2017 16:43:43 +0530
From: Saurav Babu <[email protected]>
To: [email protected]
Cc: [email protected], Saurav Babu <[email protected]>
Subject: Wi-Fi specific information in connman
Message-ID: <[email protected]>
Hi,
There are few applications which require Wi-Fi specific informations like
MAC Address, Frequency/Channel of AP. Is there any specific reason that
these informations are not stored by connman?
Will you accept patches which provides these specific informations to
applications
at upper layer?
Thanks,
Saurav
------------------------------
Message: 4
Date: Wed, 11 Jan 2017 15:04:35 +0200
From: Patrik Flykt <[email protected]>
To: Saurav Babu <[email protected]>, [email protected],
'Marcel Holtmann' <[email protected]>
Cc: [email protected]
Subject: Re: Wi-Fi specific information in connman
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2017-01-11 at 16:43 +0530, Saurav Babu wrote:
> Hi,
> There are few applications which require Wi-Fi specific informations
> like MAC Address, Frequency/Channel of AP. Is there any specific
> reason that these informations are not stored by connman?
>
> Will you accept patches which provides these specific informations to
> applications at upper layer?
Let's ping Marcel about this, I suppose.
Cheers,
Patrik
------------------------------
Message: 5
Date: Wed, 11 Jan 2017 15:08:07 +0200
From: Patrik Flykt <[email protected]>
To: Daniel Wagner <[email protected]>, [email protected]
Subject: Re: [PATCH v3] service: Update nameservers and timeservers
with address change
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Wed, 2017-01-11 at 12:17 +0100, Daniel Wagner wrote:
> Wouldn't it make sense to move the notifier call from
> settings_changed()
> to address_updated()?
>
> ????????__connman_notifier_ipconfig_changed(service, ipconfig);
A call to this function is blocked by the !allow_property_changed()
check in the beginning of settings_changed().
Maybe that is actually another bug?
Cheers,
Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 15, Issue 12
***************************************