Send connman mailing list submissions to
        connman@lists.01.org

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        connman-requ...@lists.01.org

You can reach the person managing the list at
        connman-ow...@lists.01.org

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. Re: [PATCH v3] service: Update nameservers and timeservers
      with address change (Daniel Wagner)
   2. Re: Does connman support Multiple APN with Ofono plugin ?
      (Daniel Wagner)
   3. Re: [PATCH 1/2] service: Remove additional network state
      check (Daniel Wagner)
   4. Re: [PATCH 2/2] service: Clean up service state check
      functions (Daniel Wagner)
   5. Re: [PATCH] build: Remember to clean generated VPN D-Bus file
      (Daniel Wagner)
   6. Re: [PATCH] service: Always call ipconfig notifier (Daniel Wagner)
   7. Re: Wi-Fi specific information in connman (Daniel Wagner)
   8. Re: [PATCH] dhcp: Add support for setting DHCP Vendor Class
      ID (Option 60) (Daniel Wagner)
   9. Re: [PATCH] connman.service.in: Drop CAP_KILL from upstream
      service file (Daniel Wagner)
  10. Re: Does connman support Multiple APN with Ofono plugin ?
      (Patrik Flykt)
  11. Re: [PATCH] build: Remember to clean generated VPN D-Bus file
      (Patrik Flykt)


----------------------------------------------------------------------

Message: 1
Date: Thu, 12 Jan 2017 22:42:27 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, connman@lists.01.org
Subject: Re: [PATCH v3] service: Update nameservers and timeservers
        with address change
Message-ID: <0256c4d9-b7a2-33dc-f2a1-3c00db99c...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed

Hi Patrik

On 01/11/2017 02:08 PM, Patrik Flykt wrote:
> On Wed, 2017-01-11 at 12:17 +0100, Daniel Wagner wrote:
>> Wouldn't it make sense to move the notifier call from
>> settings_changed()
>> to address_updated()?
>>
>>         __connman_notifier_ipconfig_changed(service, ipconfig);
>
> A call to this function is blocked by the !allow_property_changed()
> check in the beginning of settings_changed().

Good catch.

> Maybe that is actually another bug?

It certainly smells like that.

cheers,
daniel


------------------------------

Message: 2
Date: Thu, 12 Jan 2017 22:44:46 +0100
From: Daniel Wagner <w...@monom.org>
To: Naveen Kumar Danturi <naveendant...@gmail.com>
Cc: connman@lists.01.org
Subject: Re: Does connman support Multiple APN with Ofono plugin ?
Message-ID: <9870e65a-99de-8f06-522d-7d54b597b...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed

Hi Naveen,

On 01/10/2017 12:16 AM, Naveen Kumar Danturi wrote:
> I have a single Qualcomm Modem which supports multiple Packet data
> connections [i.e., multiple data sessions]. The use case is i have to
> use one data session for general internet browsing, other session for
> Firmware upgrade etc., this is supported from modem side. Are you saying
> that this can be possible from connman?

It depends on how your hardware is exposed from oFono towards ConnMan. 
It should just work if ConnMan sess two modems. If that is not the case 
some work would be needed to teach the oFono plugin in ConnMan to handle 
this. It's difficult to tell without any logs or the output from 
list-modems.

cheers,
daniel


------------------------------

Message: 3
Date: Thu, 12 Jan 2017 22:52:38 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, connman@lists.01.org
Subject: Re: [PATCH 1/2] service: Remove additional network state
        check
Message-ID: <2cfb8092-250c-e718-8f2d-2cdaf9451...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Patrik,

On 01/11/2017 11:43 AM, Patrik Flykt wrote:
> Network state indication is tracked with
> __connman_service_ipconfig_indicate_state().
> ---
>  src/service.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/src/service.c b/src/service.c
> index d78e0d0e..fd32175b 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -897,8 +897,6 @@ static bool is_connecting_state(struct connman_service 
> *service,
>       case CONNMAN_SERVICE_STATE_UNKNOWN:
>       case CONNMAN_SERVICE_STATE_IDLE:
>       case CONNMAN_SERVICE_STATE_FAILURE:
> -             if (service->network)
> -                     return connman_network_get_connecting(service->network);


After looking a bit into the git history, I also conclude that one looks 
just wrong. Yeah, let's kill it and see where fix need to fix the state 
machine in a correct way if that is necessary.

cheers,
daniel


------------------------------

Message: 4
Date: Thu, 12 Jan 2017 22:53:54 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>
Cc: connman@lists.01.org
Subject: Re: [PATCH 2/2] service: Clean up service state check
        functions
Message-ID: <775e467f-b7b0-015b-72d3-9704ff8de...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Patrik,

On 01/11/2017 11:43 AM, Patrik Flykt wrote:
> None of the state cheking functions need a service struct, clean up
> the state check functions to take only state as argument.
> ---
>
> I think I also fixed a bug in __connman_service_is_connected_state(),
> don't know why the compiler hasn't so far reacted.

Who knows. I think the result is a clear improvement in consistency and 
readability. Go ahead and apply them :)

cheers,
daniel


------------------------------

Message: 5
Date: Thu, 12 Jan 2017 22:54:21 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, connman@lists.01.org
Subject: Re: [PATCH] build: Remember to clean generated VPN D-Bus file
Message-ID: <c1461c83-d28d-8dcb-c5a1-74dd362e3...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

ack


------------------------------

Message: 6
Date: Thu, 12 Jan 2017 22:56:49 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, connman@lists.01.org
Subject: Re: [PATCH] service: Always call ipconfig notifier
Message-ID: <68b9a5d6-afdd-3f52-1a64-86dfcfe6e...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Patrik,

On 01/12/2017 11:52 AM, Patrik Flykt wrote:
> Always call the ipconfig notifier whether the code is waiting to
> announce the service for the first time with ServicesChanged
> signal or not.
> ---
>
> This is a fix in for the comment to "[PATCH v3] service: Update nameservers
> and timeservers with address change". Any part of ipconfig may have changed,
> not only the address.

That reasoning makes sense and the resulting code also :) Go ahead and 
apply it!

cheers,
daniel


------------------------------

Message: 7
Date: Thu, 12 Jan 2017 23:00:23 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, Saurav Babu
        <saurav.b...@samsung.com>, connman@lists.01.org, 'Marcel Holtmann'
        <mar...@holtmann.org>
Cc: sachin....@samsung.com
Subject: Re: Wi-Fi specific information in connman
Message-ID: <1d74ac7e-842a-487c-1d3a-75d591a92...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

On 01/11/2017 02:04 PM, Patrik Flykt wrote:
> On Wed, 2017-01-11 at 16:43 +0530, Saurav Babu wrote:
>> There are few applications which require Wi-Fi specific informations
>> like MAC Address, Frequency/Channel of AP. Is there any specific
>> reason that these informations are not stored by connman?

Can you elaborate a bit on your use case? I'd like to understand why you 
want that information. One thing which comes to my mind is that you want 
to show it to the user.

>> Will you accept patches which provides these specific informations to
>> applications at upper layer?
>
> Let's ping Marcel about this, I suppose.

You need to do a proper rain dance for summing Marcel, you know that? :)

cheers,
daniel


------------------------------

Message: 8
Date: Thu, 12 Jan 2017 23:04:36 +0100
From: Daniel Wagner <w...@monom.org>
To: Andreas Smas <andr...@lonelycoder.com>, connman@lists.01.org
Subject: Re: [PATCH] dhcp: Add support for setting DHCP Vendor Class
        ID (Option 60)
Message-ID: <fa4e38ef-6d79-0f75-fb5d-618844dda...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Andreas,

On 01/12/2017 11:03 AM, Andreas Smas wrote:
> This adds a new global config option "VendorClassID" which, when
> configured as a string, is passed on to DHCP requests as option 60
> ---
>  doc/connman.conf.5.in |  5 +++++
>  gdhcp/client.c        |  5 +++--
>  gdhcp/gdhcp.h         |  1 +
>  src/dhcp.c            |  6 ++++++
>  src/main.c            | 15 +++++++++++++++
>  5 files changed, 30 insertions(+), 2 deletions(-)
>
> diff --git a/doc/connman.conf.5.in b/doc/connman.conf.5.in
> index db9e558..9b28aad 100644
> --- a/doc/connman.conf.5.in
> +++ b/doc/connman.conf.5.in
> @@ -131,6 +131,11 @@ Default value is false.
>  Automatically enable Anycast 6to4 if possible. This is not recommended, as 
> the
>  use of 6to4 will generally lead to a severe degradation of connection 
> quality.
>  See RFC6343.  Default value is false (as recommended by RFC6343 section 4.1).
> +.TP
> +.BI VendorClassID= string
> +Set DHCP option 60 (Vendor Class ID) to the given string. This option can
> +be used by DHCP servers to identify specific clients without having to
> +rely on MAC address ranges, etc

I wonder if the VendorClassID configuration needs to go into 
connman.conf? Is it likely to be changed between boots? If not I would 
say it something for configure.ac.

The patch itself looks good to me, just not sure if we need to expose 
the option in connman.conf.

cheers,
daniel


------------------------------

Message: 9
Date: Thu, 12 Jan 2017 23:05:46 +0100
From: Daniel Wagner <w...@monom.org>
To: Patrik Flykt <patrik.fl...@linux.intel.com>, connman@lists.01.org
Subject: Re: [PATCH] connman.service.in: Drop CAP_KILL from upstream
        service file
Message-ID: <55c67ea6-dc7c-f77b-6be2-da8f261fb...@monom.org>
Content-Type: text/plain; charset=windows-1252; format=flowed

Hi Patrik,

On 01/11/2017 12:01 PM, Patrik Flykt wrote:
> Upstream ConnMan uses only D-Bus to start external programs. The
> CAP_KILL capability in the service file is not necessary and can
> therefore be removed. ConnMan still has the capability of starting
> other applications, if this is needed the capability needs to be
> re-added to the distro or OS specific service file.

okay, whatever :) ACK

cheers,
daniel


------------------------------

Message: 10
Date: Fri, 13 Jan 2017 12:45:34 +0200
From: Patrik Flykt <patrik.fl...@linux.intel.com>
To: Daniel Wagner <w...@monom.org>, Naveen Kumar Danturi
        <naveendant...@gmail.com>
Cc: connman@lists.01.org
Subject: Re: Does connman support Multiple APN with Ofono plugin ?
Message-ID: <1484304334.10965.1.ca...@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 2017-01-12 at 22:44 +0100, Daniel Wagner wrote:

> It depends on how your hardware is exposed from oFono towards
> ConnMan.? It should just work if ConnMan sess two modems. If that is
> not the case? some work would be needed to teach the oFono plugin in
> ConnMan to handle?this. It's difficult to tell without any logs or
> the output from?list-modems.

The oFono plugin has supported multiple internet contexts for some time
already, see patces starting with
71cbf35ce180cfed27bea6f4b7d1e5792d58f52c. Notice that only internet
contexts are supported by ConnMan.

Cheers,

        Patrik


------------------------------

Message: 11
Date: Fri, 13 Jan 2017 13:24:14 +0200
From: Patrik Flykt <patrik.fl...@linux.intel.com>
To: Daniel Wagner <w...@monom.org>, connman@lists.01.org
Subject: Re: [PATCH] build: Remember to clean generated VPN D-Bus file
Message-ID: <1484306654.10965.2.ca...@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 2017-01-12 at 22:54 +0100, Daniel Wagner wrote:
> ack

Applied.

        Patrik


------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
connman@lists.01.org
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 15, Issue 14
***************************************

Reply via email to