Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: Aw: Re: [PATCH v2 1/1] doc: add online check information
(Daniel Wagner)
2. Re: Create statistics file and service folder strictly only
after successful connect (Daniel Wagner)
3. (no subject) (Daniel Wagner)
4. [PATCH] main: Make --noplugin option repeatable (Slava Monich)
5. Re: Create statistics file and service folder strictly only
after successful connect (Patrik Flykt)
----------------------------------------------------------------------
Message: 1
Date: Tue, 28 Feb 2017 07:30:21 +0100
From: Daniel Wagner <[email protected]>
To: Ingo Albrecht <[email protected]>
Cc: [email protected]
Subject: Re: Aw: Re: [PATCH v2 1/1] doc: add online check information
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Ingo,
On 02/21/2017 03:16 PM, Ingo Albrecht wrote:
>> Gesendet: Montag, 20. Februar 2017 um 15:40 Uhr
>> Von: "Daniel Wagner" <[email protected]>
>> An: "Ingo Albrecht" <[email protected]>, [email protected]
>> Betreff: Re: [PATCH v2 1/1] doc: add online check information
>>
>> Hi Ingo,
>>
>> On 02/14/17 11:56, Ingo Albrecht wrote:
>>> Add new info from connman.net server admin to README.
>>> Mention the online check in the manual so that end users have a reference
>>> why the client
>>> opens an external route.
>>
>> Thanks for your patch. I tried to apply it but it failed. Did you create
>> this patch via 'git commit -m "bla bla"; git send-patch HEAD~'?
>>
>> Anyway I can apply it manually next week. I am traveling and don't have
>> access to my devel manchine. I wouldn't mind if you find time to update
>> your patch :)
>>
>> Thanks,
>> Daniel
>>
>
> Hi Daniel,
> I just send it again based on -m bla. Hope it works better as I cannot git
> send-email directly at current.
> As I wrote in another message, I'll be glad to update it further on
> functionality changes, maybe
> even move it to a separate onlinecheck.txt doc then.
Patch applied and looking forward to more contributions!
Thanks,
Daniel
------------------------------
Message: 2
Date: Tue, 28 Feb 2017 07:38:38 +0100
From: Daniel Wagner <[email protected]>
To: Patrik Flykt <[email protected]>, Jose Blanquicet
<[email protected]>, [email protected]
Subject: Re: Create statistics file and service folder strictly only
after successful connect
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Patrik,
On 02/27/2017 08:38 AM, Patrik Flykt wrote:
> On Fri, 2017-02-24 at 08:12 +0000, Jose Blanquicet wrote:
>> Or, maybe better, why ConnMan needs to access the file that early?
>> Shouldn't it be done when service goes into CONFIGURATION state or
>> READY state for new services? If it does not break any statistics
>> feature, I would suggest to completely remove that piece of code from
>> service_connect():
>>
>> - if (__connman_stats_service_register(service) == 0) {
>> - __connman_stats_get(service, false,
>> - &service-
>>> stats.data);
>> - __connman_stats_get(service, true,
>> - &service-
>>> stats_roaming.data);
>> - }
>>
>> What do yo think?
>
> ConnMan statistics should count all the bytes sent via that service,
> successful or not. Configuration state sounds about right, as then all
> the bytes in the messages doing authentication are accounted for as
> well. Unfortunately I think ethernet was skipping this state (or then
> it was Associating, can't remember right now), but that should be
> trivial to fix. We do want to have all bytes counted, as this is
> especially important with oFono and cellular.
>
> Unfortunately accounting is a bit broken at the moment. Stopping it
> does not properly store the bytes seen and the only way to have ConnMan
> account properly is to set up an external application to ask for
> statistics.
Depends on how you see it :) It works exactly as we initially planned
it. That is without an external user of the stats API the counters are
not updated to keep overhead/power usage at a minimum.
Always updating the counters makes perfectly sense for me though you
need to take a close look on how to keep the overhead small.
Thanks,
Daniel
------------------------------
Message: 3
Date: Tue, 28 Feb 2017 07:47:54 +0100
From: Daniel Wagner <[email protected]>
To: Jose Blanquicet <[email protected]>, Antoine Aubert
<[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
I pestered Marcel for a release a bit during ELC last week. He agreed to
do one. A soon it is done patches will will get applied again. Sorry for
the inconvenience.
Thanks,
Daniel
------------------------------
Message: 4
Date: Tue, 28 Feb 2017 12:01:12 +0200
From: Slava Monich <[email protected]>
To: [email protected]
Subject: [PATCH] main: Make --noplugin option repeatable
Message-ID: <[email protected]>
---
src/main.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/src/main.c b/src/main.c
index 915c17e..651b3e2 100644
--- a/src/main.c
+++ b/src/main.c
@@ -511,6 +511,21 @@ static bool parse_debug(const char *key, const char *value,
return true;
}
+static bool parse_noplugin(const char *key, const char *value,
+ gpointer user_data, GError **error)
+{
+ if (option_noplugin) {
+ char *prev = option_noplugin;
+
+ option_noplugin = g_strconcat(prev, ",", value, NULL);
+ g_free(prev);
+ } else {
+ option_noplugin = g_strdup(value);
+ }
+
+ return true;
+}
+
static GOptionEntry options[] = {
{ "config", 'c', 0, G_OPTION_ARG_STRING, &option_config,
"Load the specified configuration file "
@@ -524,7 +539,7 @@ static GOptionEntry options[] = {
"Specify networking interface to ignore", "DEV" },
{ "plugin", 'p', 0, G_OPTION_ARG_STRING, &option_plugin,
"Specify plugins to load", "NAME,..." },
- { "noplugin", 'P', 0, G_OPTION_ARG_STRING, &option_noplugin,
+ { "noplugin", 'P', 0, G_OPTION_ARG_CALLBACK, &parse_noplugin,
"Specify plugins not to load", "NAME,..." },
{ "wifi", 'W', 0, G_OPTION_ARG_STRING, &option_wifi,
"Specify driver for WiFi/Supplicant", "NAME" },
--
1.9.1
------------------------------
Message: 5
Date: Tue, 28 Feb 2017 12:24:37 +0200
From: Patrik Flykt <[email protected]>
To: Daniel Wagner <[email protected]>, Jose Blanquicet
<[email protected]>, [email protected]
Subject: Re: Create statistics file and service folder strictly only
after successful connect
Message-ID: <[email protected]>
Content-Type: text/plain; charset="UTF-8"
On Tue, 2017-02-28 at 07:38 +0100, Daniel Wagner wrote:
> Depends on how you see it :) It works exactly as we initially
> planned?it. That is without an external user of the stats API the
> counters are?not updated to keep overhead/power usage at a minimum.
>
> Always updating the counters makes perfectly sense for me though you?
> need to take a close look on how to keep the overhead small.
The only problem right now is that stats are not recorded to file on
service disconnect. It has to do with the fact that the interface is
the first one to go, then the service is removed. Stats are
closed/saved only when service goes away, which is too late.
Cheers,
Patrik
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 16, Issue 27
***************************************
