Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. How to set MTU? (David Aldrich)
2. Re: Prevent scanning on tethering interface (Jose Blanquicet)
3. [PATCH] wifi: Prevent scanning on tethering interface
([email protected])
4. Re: [PATCH v2] ofono: Fix segfault during set_property
(Daniel Wagner)
5. Re: [PATCH] gsupplicant: Add DBGs to trace errors from
wpa_supplicant (Daniel Wagner)
6. Re: [PATCH v2] technology: Deny P2P finding if technology is
disabled (Daniel Wagner)
7. Re: [PATCH v2] service: Add EnableOnlineCheck config option
(Daniel Wagner)
8. Re: [PATCH] wifi: Prevent scanning on tethering interface
(Daniel Wagner)
9. Re: How to set MTU? (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Tue, 14 Mar 2017 14:58:04 +0000
From: David Aldrich <[email protected]>
To: "[email protected]" <[email protected]>
Subject: How to set MTU?
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hi
I am working with Wind River Linux.
Is it possible to set the MTU of a network interface using connman?
Best regards
David
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20170314/8aaa25f3/attachment-0001.html>
------------------------------
Message: 2
Date: Tue, 14 Mar 2017 18:49:53 +0100
From: Jose Blanquicet <[email protected]>
To: Patrik Flykt <[email protected]>
Cc: Daniel Wagner <[email protected]>, [email protected], Tomasz
Bursztyka <[email protected]>
Subject: Re: Prevent scanning on tethering interface
Message-ID:
<CAFC8iJJZL=d8ysjqqmhvwauai55l6bcgajhq-lxx--obqnt...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi Patrik,
On Mon, Mar 13, 2017 at 12:05 PM, Patrik Flykt
<[email protected]> wrote:
> Yes, looks like the right thing to do here.
OK, I will send a proper patch.
Regards,
Jose Blanquicet
------------------------------
Message: 3
Date: Tue, 14 Mar 2017 17:56:39 +0000
From: [email protected]
To: [email protected]
Subject: [PATCH] wifi: Prevent scanning on tethering interface
Message-ID:
<1489514199-18241-1-git-send-email-jose.blanquicet-melen...@magnetimarelli.com>
From: Jose Blanquicet <[email protected]>
The first issue takes place when user asks for a Scan on P2P technology and
Tethering is enabled for WiFi technology, ConnMan will reply with a success to
the request even if the P2P find does not actually started. The second issue
occurs when user asks for a Scan on WiFi technology and WiFi tethering is
enabled, in such case, ConnMan will never emit the reply and client (e.g.
connmanctl) will go in D-Bus time-out.
This patch moves the tethering state check before calling P2PDevice.Find() in
order to solve first issue; in addition, return -EBUSY instead of zero
("success") if tethering is enabled to solve the second issue. Doing so, ConnMan
will save one useless D-Bus call toward wpa_supplicant (P2PDevice.Find) and will
be able to correctly reply "Error" to the scan requests while tethering.
---
plugins/wifi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/plugins/wifi.c b/plugins/wifi.c
index f8d88fa..a49031c 100644
--- a/plugins/wifi.c
+++ b/plugins/wifi.c
@@ -1802,14 +1802,14 @@ static int wifi_scan(enum connman_service_type type,
if (wifi->p2p_device)
return 0;
+ if (wifi->tethering)
+ return -EBUSY;
+
if (type == CONNMAN_SERVICE_TYPE_P2P)
return p2p_find(device);
DBG("device %p wifi %p hidden ssid %s", device, wifi->interface, ssid);
- if (wifi->tethering)
- return 0;
-
scanning = connman_device_get_scanning(device);
if (!ssid || ssid_len == 0 || ssid_len > 32) {
--
1.9.1
------------------------------
Message: 4
Date: Tue, 14 Mar 2017 19:08:10 +0100
From: Daniel Wagner <[email protected]>
To: Scott Valentine <[email protected]>, [email protected]
Subject: Re: [PATCH v2] ofono: Fix segfault during set_property
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Scott,
On 03/13/2017 07:51 PM, Scott Valentine wrote:
> If the SIM card is ejected or the modem is reset / removed between the
> set_property call and the set_property_reply callback, connmand will generally
> abort, as the remove_all_contexts will get called, and the callback accesses a
> reference to a stale context via the property_info pointer.
>
> The following patch adds reference counting to the network_context struct to
> prevent the segfault, and has been modified slightly after review.
Applied your patch after a couple style modifications. I didn't want to
bother you again but those things so I just went ahead and fixed it up
myself. Hope that is okay with you.
Thanks,
Daniel
------------------------------
Message: 5
Date: Tue, 14 Mar 2017 19:23:46 +0100
From: Daniel Wagner <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH] gsupplicant: Add DBGs to trace errors from
wpa_supplicant
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Jose,
On 03/13/2017 02:40 PM, [email protected] wrote:
> From: Jose Blanquicet <[email protected]>
>
> Errors comming from wpa_supplicant are mapped into standard errors. This patch
> adds some DBGs to log those errors and ease debug in case one of these D-Bus
> calls fails.
Patch applied.
Thank,
Daniel
------------------------------
Message: 6
Date: Tue, 14 Mar 2017 19:28:33 +0100
From: Daniel Wagner <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH v2] technology: Deny P2P finding if technology is
disabled
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
On 03/13/2017 02:42 PM, [email protected] wrote:
> From: Jose Blanquicet <[email protected]>
>
> This check is added because P2P and WiFi scan end up at the same device and at
> that level there is not differentiation between WiFi and P2P, they both are
> WiFi
> devices. Therefore, when device's power is checked in device.c:device_scan(),
> it is actually checking only if WiFi technology is enabled thus P2P scan will
> go
> ahead even if P2P technology is not enabled.
Forgot to ask and I don't have any hardware with p2p support: Can p2p be
enabled and wifi disabled at the same time? If so, the patch below would
also need the wifi part.
Thanks,
Daniel
> ---
> src/technology.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/technology.c b/src/technology.c
> index 4574f1e..d2f0ae2 100644
> --- a/src/technology.c
> +++ b/src/technology.c
> @@ -1077,6 +1077,10 @@ static DBusMessage *scan(DBusConnection *conn,
> DBusMessage *msg, void *data)
> DBG("technology %p request from %s", technology,
> dbus_message_get_sender(msg));
>
> + if (technology->type == CONNMAN_SERVICE_TYPE_P2P &&
> + !technology->enabled)
> + return __connman_error_permission_denied(msg);
> +
> dbus_message_ref(msg);
> technology->scan_pending =
> g_slist_prepend(technology->scan_pending, msg);
>
------------------------------
Message: 7
Date: Tue, 14 Mar 2017 19:32:25 +0100
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH v2] service: Add EnableOnlineCheck config option
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Lukasz,
On 03/13/2017 04:14 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> Global config option, which allows to enable/disable (enabled by default)
> use of http get in wispr to transition a default service from READY to
> ONLINE state.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 8
Date: Tue, 14 Mar 2017 19:36:55 +0100
From: Daniel Wagner <[email protected]>
To: [email protected], [email protected]
Subject: Re: [PATCH] wifi: Prevent scanning on tethering interface
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Jose,
On 03/14/2017 06:56 PM, [email protected] wrote:
> From: Jose Blanquicet <[email protected]>
>
> The first issue takes place when user asks for a Scan on P2P technology and
> Tethering is enabled for WiFi technology, ConnMan will reply with a success to
> the request even if the P2P find does not actually started. The second issue
> occurs when user asks for a Scan on WiFi technology and WiFi tethering is
> enabled, in such case, ConnMan will never emit the reply and client (e.g.
> connmanctl) will go in D-Bus time-out.
>
> This patch moves the tethering state check before calling P2PDevice.Find() in
> order to solve first issue; in addition, return -EBUSY instead of zero
> ("success") if tethering is enabled to solve the second issue. Doing so,
> ConnMan
> will save one useless D-Bus call toward wpa_supplicant (P2PDevice.Find) and
> will
> be able to correctly reply "Error" to the scan requests while tethering.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 9
Date: Tue, 14 Mar 2017 19:43:57 +0100
From: Daniel Wagner <[email protected]>
To: David Aldrich <[email protected]>, "[email protected]"
<[email protected]>
Subject: Re: How to set MTU?
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi David,
On 03/14/2017 03:58 PM, David Aldrich wrote:
> Is it possible to set the MTU of a network interface using connman?
As it stands currently, ConnMan only has some knobs for VPN tunnels. I
thought we supported this for all interfaces but as it turns out, nope.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 17, Issue 14
***************************************
