Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] ofono: Fix segfault during modem_removed
(Daniel Wagner)
2. Re: [PATCH] ofono: Fix shared usage of interface index
(Daniel Wagner)
3. Re: [PATCH v1 1/1] doc: update online check information
(Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Tue, 4 Apr 2017 20:02:06 +0200
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH] ofono: Fix segfault during modem_removed
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Lukasz,
On 03/31/2017 04:37 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> Prevent sending any further dbus messages after modem_removed signal.
I presume that is the part with the g_hash_table_lookup()? Mixing this
with the segfault fix is a bit confusing. Could you split this into two
patches?
Thanks,
Daniel
> Sequence causing a segfault is:
> - modem_removed
> - remove_modem
> - remove_all_contexts
> - remove_cm_context
> - remove_network
> - connman_device_remove_network
> - network_disconnect
> - context_set_active
> - set_property
> ---
> plugins/ofono.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/plugins/ofono.c b/plugins/ofono.c
> index 70b085a..f6b2b52 100644
> --- a/plugins/ofono.c
> +++ b/plugins/ofono.c
> @@ -2500,16 +2500,19 @@ static void remove_modem(gpointer data)
> if (modem->call_set_property) {
> dbus_pending_call_cancel(modem->call_set_property);
> dbus_pending_call_unref(modem->call_set_property);
> + modem->call_set_property = NULL;
> }
>
> if (modem->call_get_properties) {
> dbus_pending_call_cancel(modem->call_get_properties);
> dbus_pending_call_unref(modem->call_get_properties);
> + modem->call_get_properties = NULL;
> }
>
> if (modem->call_get_contexts) {
> dbus_pending_call_cancel(modem->call_get_contexts);
> dbus_pending_call_unref(modem->call_get_contexts);
> + modem->call_get_contexts = NULL;
> }
>
> /* Must remove the contexts before the device */
> @@ -2699,6 +2702,9 @@ static int network_connect(struct connman_network
> *network)
>
> DBG("%s network %p", modem->path, network);
>
> + if (!g_hash_table_lookup(modem_hash, modem->path))
> + return -ENODEV;
> +
> context = get_context_with_network(modem->context_list, network);
> if (!context)
> return -ENODEV;
> @@ -2720,6 +2726,9 @@ static int network_disconnect(struct connman_network
> *network)
>
> DBG("%s network %p", modem->path, network);
>
> + if (!g_hash_table_lookup(modem_hash, modem->path))
> + return -ENODEV;
> +
> context = get_context_with_network(modem->context_list, network);
> if (!context)
> return -ENODEV;
>
------------------------------
Message: 2
Date: Tue, 4 Apr 2017 20:08:22 +0200
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH] ofono: Fix shared usage of interface index
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Lukasz,
On 03/31/2017 07:00 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> IPv4 and IPv6 share the interface index value in the network_context
> structure.
> Because of that, they should not overwrite it with -1 every time a Settings
> or IPv6.Setting modem property is received.
>
> Problem observed when a modem was first reporting IPv4 Settings, with a valid
> interface name and method dhcp. And then IPv6.Settings with method=OFF and
> no interface name.
>
> In that case, extract_ipv6_settings would wrongly set context->index = -1
> causing the set_connected() fail and modem being incorrectly kept
> disconnected.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 3
Date: Tue, 4 Apr 2017 20:11:15 +0200
From: Daniel Wagner <[email protected]>
To: Ingo Albrecht <[email protected]>, [email protected]
Subject: Re: [PATCH v1 1/1] doc: update online check information
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Ingo,
On 04/03/2017 08:25 PM, Ingo Albrecht wrote:
> Update doc to reflect the new EnableOnlineCheck configuration option
> introduced with 4de35cde5a93271e785a3bb5a0f3d39aea34d77b
> Correct typo.
Patch applied.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 18, Issue 3
**************************************
