Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v2 0/2] ofono: Fix segfault during modem_removed
(Daniel Wagner)
2. Re: [PATCH 1/5] Session: add parameter Service into
CreateSession call of ConnMan Session API, (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Sun, 9 Apr 2017 20:38:26 +0200
From: Daniel Wagner <[email protected]>
To: Lukasz Nowak <[email protected]>, [email protected]
Subject: Re: [PATCH v2 0/2] ofono: Fix segfault during modem_removed
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Lukasz,
On 04/04/2017 09:36 PM, Lukasz Nowak wrote:
> From: Lukasz Nowak <[email protected]>
>
> Changes since v1:
> - split patch into two separate commits
> - added more information to commit messages
>
> The second patch is technically not required, after the first patch.
> But it might save somebody 2 days of debugging memory corruption in the
> future,
> in case a different path emerges, which can use the non-cleared pointers to
> already freed memory.
Thanks for the additional change log.
Patched applied.
Thanks,
Daniel
------------------------------
Message: 2
Date: Sun, 9 Apr 2017 20:59:17 +0200
From: Daniel Wagner <[email protected]>
To: [email protected], [email protected]
Cc: thb1hi <[email protected]>,
[email protected]
Subject: Re: [PATCH 1/5] Session: add parameter Service into
CreateSession call of ConnMan Session API,
Message-ID: <[email protected]>
Content-Type: text/plain; charset=windows-1252; format=flowed
Hi Bjoern,
Could you provide a cover letter which explains why these chances are
necessary? I know there is a discussion somewhere in the mail archive.
To stay consistent please use lower case prefixes, e.g. 'session: ...'.
Also the dot at the end of the subject is left away. Again that how most
commit message look like.
On 04/06/2017 02:52 PM, [email protected] wrote:
> From: thb1hi <[email protected]>
Would it a problem to use your real name 'From: Bjoern Thorwith <...>'?
> propagation of parameter value through creation_data struct into policy
> plugins.
Please explain why this is necessary.
> Signed-off-by: thb1hi <[email protected]>
> Signed-off-by: Mounesh Sutar <[email protected]>
We don't do SoB.
> diff --git a/src/session.c b/src/session.c
> index dadd68f..a64df64 100644
> --- a/src/session.c
> +++ b/src/session.c
> @@ -545,6 +545,7 @@ struct creation_data {
> GSList *allowed_bearers;
> char *allowed_interface;
> bool source_ip_rule;
> + char *service;
> };
>
> static void cleanup_creation_data(struct creation_data *creation_data)
> @@ -554,6 +555,8 @@ static void cleanup_creation_data(struct creation_data
> *creation_data)
>
> if (creation_data->pending)
> dbus_message_unref(creation_data->pending);
> + if (creation_data->service)
> + g_free(creation_data->service);
>
> g_slist_free(creation_data->allowed_bearers);
> g_free(creation_data->allowed_interface);
> @@ -1471,6 +1474,9 @@ int __connman_session_create(DBusMessage *msg)
>
> connman_session_parse_connection_type(val);
>
> user_connection_type = true;
> + } else if (g_str_equal(key, "Service")) {
> + dbus_message_iter_get_basic(&value, &val);
> + creation_data->service = g_strdup(val);
> } else if (g_str_equal(key, "AllowedInterface")) {
> dbus_message_iter_get_basic(&value, &val);
> creation_data->allowed_interface =
> g_strdup(val);
>
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 18, Issue 7
**************************************
