Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 1/5] Session: add parameter Service into
CreateSession call of ConnMan Session API, (Mounesh Sutar)
----------------------------------------------------------------------
Message: 1
Date: Tue, 25 Apr 2017 15:22:54 +0530
From: Mounesh Sutar <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected], thb1hi
<[email protected]>, "Sutar, Mounesh"
<[email protected]>
Subject: Re: [PATCH 1/5] Session: add parameter Service into
CreateSession call of ConnMan Session API,
Message-ID:
<cahrsm5nhnhqeboylfy+zxwa-taroh7qsbzwak9yhogpx34p...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi Daniel,
These changes are for proposal to provide two extensions to session API
interfaces of Connman.
1> The first extension enables a service differentiation for processes run
by the same user.
It allows ConnMan to differentiate between bearer usage permissions
and the respective priorities based on the requested service type.
2> The second extension enables session-based routing based on source IPs.
This mechanism is meant as an alternative means for differentiating
between traffic of session API users.
Source IP based routing may be used to route traffic from non-local
sources, e.g. remote hosts or virtual machines/containers.
There have been many discussions on its consideration.
https://lists.01.org/pipermail/connman/2017-January/021428.html
With the consideration of feedback and suggestions for above proposal, we
have therefore looked into how to build a functional separation, that will
maintain the default ConnMan behaviour while enabling more complex policy
scenarios.
We found that, it would be necessary for the more complex policy scenarios
to add new hooks to the policy callback function infrastructure of the
Session API.
The hooks would be backward compatible with the default policy plugin and
the ongoing Session API development.
All the patches with fixes for review comments have been pushed with
subject v2.
Regards,
Mounesh
On Mon, Apr 10, 2017 at 12:29 AM, Daniel Wagner <[email protected]> wrote:
> Hi Bjoern,
>
> Could you provide a cover letter which explains why these chances are
> necessary? I know there is a discussion somewhere in the mail archive.
>
> To stay consistent please use lower case prefixes, e.g. 'session: ...'.
> Also the dot at the end of the subject is left away. Again that how most
> commit message look like.
>
> On 04/06/2017 02:52 PM, [email protected] wrote:
>
>> From: thb1hi <[email protected]>
>>
>
> Would it a problem to use your real name 'From: Bjoern Thorwith <...>'?
>
> propagation of parameter value through creation_data struct into policy
>> plugins.
>>
>
> Please explain why this is necessary.
>
> Signed-off-by: thb1hi <[email protected]>
>> Signed-off-by: Mounesh Sutar <[email protected]>
>>
>
> We don't do SoB.
>
>
> diff --git a/src/session.c b/src/session.c
>> index dadd68f..a64df64 100644
>> --- a/src/session.c
>> +++ b/src/session.c
>> @@ -545,6 +545,7 @@ struct creation_data {
>> GSList *allowed_bearers;
>> char *allowed_interface;
>> bool source_ip_rule;
>> + char *service;
>> };
>>
>> static void cleanup_creation_data(struct creation_data *creation_data)
>> @@ -554,6 +555,8 @@ static void cleanup_creation_data(struct
>> creation_data *creation_data)
>>
>> if (creation_data->pending)
>> dbus_message_unref(creation_data->pending);
>> + if (creation_data->service)
>> + g_free(creation_data->service);
>>
>> g_slist_free(creation_data->allowed_bearers);
>> g_free(creation_data->allowed_interface);
>> @@ -1471,6 +1474,9 @@ int __connman_session_create(DBusMessage *msg)
>> connman_session_parse_connecti
>> on_type(val);
>>
>> user_connection_type = true;
>> + } else if (g_str_equal(key, "Service")) {
>> + dbus_message_iter_get_basic(&value,
>> &val);
>> + creation_data->service = g_strdup(val);
>> } else if (g_str_equal(key, "AllowedInterface")) {
>> dbus_message_iter_get_basic(&value,
>> &val);
>> creation_data->allowed_interface =
>> g_strdup(val);
>>
>>
> Thanks,
> Daniel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20170425/9a4b81db/attachment-0001.html>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 18, Issue 23
***************************************
