Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] dhcp: multiple interfaces with link-local
connection (Jose Blanquicet)
2. Re: [PATCH 1/2] wifi: Do not allow scan/autoscan on p2p
connected interface (Daniel Wagner)
3. Re: [PATCH] dhcp: multiple interfaces with link-local
connection (Daniel Wagner)
4. Sierra gobi modem and RmNet (Daryl Nebrich)
----------------------------------------------------------------------
Message: 1
Date: Mon, 26 Jun 2017 08:02:51 +0000
From: Jose Blanquicet <[email protected]>
To: Heghedus Razvan <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] dhcp: multiple interfaces with link-local
connection
Message-ID:
<CAFC8iJLoAj6RwPb=4ajnje1hht1j8d_c2m6x5ohhfqqwnjd...@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Hi Heghedus,
On Fri, Jun 23, 2017 at 11:27 AM, Heghedus Razvan wrote:
> By default connman limits the link-local connection to a single
> interface, meaning that we can't have multiple interfaces connected to
> link-local networks.
> This allows connman to have multiple link-local connections.
All the test environments where I use ConnMan have only one interface
acting as STA thus I did not realized about this limitation while I
worked in c22705701b9b ('service: Set method to AUTO when address is
got through IPv4LL'). I tested this patch and it seems to work as
expected. I just added a couple of comments. Thanks!
> Signed-off-by: Heghedus Razvan <[email protected]>
SoB is not done in ConnMan Community.
> ---
> src/dhcp.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/src/dhcp.c b/src/dhcp.c
> index 54fb64e5..509e3734 100644
> --- a/src/dhcp.c
> +++ b/src/dhcp.c
> @@ -59,10 +59,11 @@ struct connman_dhcp {
> GDHCPClient *dhcp_client;
> char *ipv4ll_debug_prefix;
> char *dhcp_debug_prefix;
> +
> + bool ipv4ll_running;
WARNING: please, no spaces at the start of a line
#10: FILE: src/dhcp.c:63:
+ bool ipv4ll_running;$
> };
>
> static GHashTable *ipconfig_table;
> -static bool ipv4ll_running;
>
> static void dhcp_free(struct connman_dhcp *dhcp)
> {
> @@ -85,7 +86,7 @@ static void ipv4ll_stop_client(struct connman_dhcp *dhcp)
> g_dhcp_client_stop(dhcp->ipv4ll_client);
> g_dhcp_client_unref(dhcp->ipv4ll_client);
> dhcp->ipv4ll_client = NULL;
> - ipv4ll_running = false;
> + dhcp->ipv4ll_running = false;
>
> g_free(dhcp->ipv4ll_debug_prefix);
> dhcp->ipv4ll_debug_prefix = NULL;
> @@ -232,7 +233,7 @@ static int ipv4ll_start_client(struct connman_dhcp *dhcp)
> return err;
> }
>
> - ipv4ll_running = true;
> + dhcp->ipv4ll_running = true;
> return 0;
> }
>
> @@ -253,7 +254,7 @@ static void no_lease_cb(GDHCPClient *dhcp_client,
> gpointer user_data)
> struct connman_dhcp *dhcp = user_data;
> int err;
>
> - DBG("No lease available ipv4ll %d client %p", ipv4ll_running,
> + DBG("No lease available ipv4ll %d client %p", dhcp->ipv4ll_running,
> dhcp->ipv4ll_client);
>
> if (dhcp->timeout > 0)
> @@ -262,7 +263,7 @@ static void no_lease_cb(GDHCPClient *dhcp_client,
> gpointer user_data)
> dhcp->timeout = g_timeout_add_seconds(RATE_LIMIT_INTERVAL,
> dhcp_retry_cb,
> dhcp);
> - if (ipv4ll_running)
> + if (dhcp->ipv4ll_running)
> return;
>
> err = ipv4ll_start_client(dhcp);
> @@ -270,7 +271,7 @@ static void no_lease_cb(GDHCPClient *dhcp_client,
> gpointer user_data)
> DBG("Cannot start ipv4ll client (%d/%s)", err,
> strerror(-err));
>
> /* Only notify upper layer if we have a problem */
> - dhcp_invalidate(dhcp, !ipv4ll_running);
> + dhcp_invalidate(dhcp, !dhcp->ipv4ll_running);
> }
>
> static void lease_lost_cb(GDHCPClient *dhcp_client, gpointer user_data)
Best Regards,
Jose Blanquicet
------------------------------
Message: 2
Date: Mon, 26 Jun 2017 10:13:29 +0200
From: Daniel Wagner <[email protected]>
To: Jose Blanquicet <[email protected]>, Tomasz Bursztyka
<[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 1/2] wifi: Do not allow scan/autoscan on p2p
connected interface
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jose,
> Any feedback on this topic?
Since no one didn't react I applied both patches.
Thanks,
Daniel
------------------------------
Message: 3
Date: Mon, 26 Jun 2017 10:25:59 +0200
From: Daniel Wagner <[email protected]>
To: Heghedus Razvan <[email protected]>, Jose Blanquicet
<[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] dhcp: multiple interfaces with link-local
connection
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi
On 06/26/2017 10:02 AM, Jose Blanquicet wrote:
> Hi Heghedus,
>
> On Fri, Jun 23, 2017 at 11:27 AM, Heghedus Razvan wrote:
>> By default connman limits the link-local connection to a single
>> interface, meaning that we can't have multiple interfaces connected to
>> link-local networks.
>> This allows connman to have multiple link-local connections.
>
> All the test environments where I use ConnMan have only one interface
> acting as STA thus I did not realized about this limitation while I
> worked in c22705701b9b ('service: Set method to AUTO when address is
> got through IPv4LL'). I tested this patch and it seems to work as
> expected. I just added a couple of comments. Thanks!
Thanks for testing. I applied this patch after fixing the two issues
Jose mentioned.
Thanks,
Daniel
------------------------------
Message: 4
Date: Mon, 26 Jun 2017 10:52:50 -0400
From: Daryl Nebrich <[email protected]>
To: [email protected]
Subject: Sierra gobi modem and RmNet
Message-ID:
<CANmGHYv6wep3KUD1qHhvuQz3+ORKAETaxOZ=b1-kwvkq749...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi,
I'm using connman 1.34 and ofono 1.20. The modem is a Sierra AR7x
series with QC/Gobi. I'm using Sierra's GobiNet and GobiSerial
drivers. The drivers use QC's RmNet to expose the cell data
connection as an ethernet network interface on the host.
Once the modem is setup and online in ofono, I'm able to create the
data connection in connman using "connect cellular...". After the
connection is established, connmanctl services shows -
connmanctl> services
*AO Wired ethernet_00049f04434e_cable
*AR Wired ethernet_3e75cbee771b_cable
c AT&T cellular_310410598635836_context1
The eth1 interface doesn't look to be associated with the cellular
service. Eventually, the pending cell service connection times out
(service.c:connect_timeout) and the connection is torn down. I
attached the log file. Line 53 shows where detect_newlink() appears
to setup eth1 as a new ethernet service and doesn't detect it as part
of the cellular service. Any ideas how to fix?
Jun 26 14:10:14 imx6qsabreauto daemon.debug connmand[1836]:
../connman-1.34/src/detect.c:detect_newlink() type 1 index 41
Jun 26 14:10:14 imx6qsabreauto daemon.debug connmand[1836]:
../connman-1.34/plugins/ethernet.c:ethernet_newlink() index 41 flags
36995 change 1
Jun 26 14:10:14 imx6qsabreauto daemon.debug connmand[1836]:
../connman-1.34/plugins/ethernet.c:ethernet_newlink() power on
Thanks,
Daryl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sierra - eth1.log
Type: application/octet-stream
Size: 79209 bytes
Desc: not available
URL:
<http://lists.01.org/pipermail/connman/attachments/20170626/3d3da70b/attachment.obj>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 20, Issue 15
***************************************
