Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] service: Return OperationAborted when agent gets
Canceled (Vasyl Vavrychuk)
2. autoconnect should be disabled while password input is in
progress (Vasyl Vavrychuk)
----------------------------------------------------------------------
Message: 1
Date: Fri, 13 Oct 2017 00:15:37 +0300
From: Vasyl Vavrychuk <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] service: Return OperationAborted when agent gets
Canceled
Message-ID:
<CAGj4m+7mqzaFC3Rh-Q==3mvdleo0rdfergdeesxrvhqwugk...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi, Daniel,
This works fine for me. Thanks.
Kind regards,
Vasyl
On Sun, Oct 8, 2017 at 2:10 PM, Daniel Wagner <[email protected]> wrote:
> When the user decided to cancel the connect attempt, the agent sends
> net.connman.Agent.Error.Canceled. Currently, we return InvalidArgument
> for normal non-hidden networks and ConnectedAborted for hidden
> networks. Return OperationAborted also for non-hidden networks to
> avoid confusion on the user ends. That means the cancel operation was
> successful and nothing went wrong as invalid argument indicates.
>
> Reported by Vasyl Vavrychuk.
> ---
>
> Hi Vasyl,
>
> Can you give it a try and give feedback?
>
> Thanks,
> Daniel
>
>
> doc/agent-api.txt | 2 ++
> src/service.c | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/doc/agent-api.txt b/doc/agent-api.txt
> index aa7271d43484..e3c1dcde8cd3 100644
> --- a/doc/agent-api.txt
> +++ b/doc/agent-api.txt
> @@ -54,6 +54,8 @@ Methods void Release()
> keys are the field names and the values are the
> actual fields. Alternatively an error indicating
> that
> the request got canceled can be returned.
> + OperationAborted will be return on a successfull
> + cancel request.
>
> Most common return field names are "Name" and of
> course "Passphrase".
> diff --git a/src/service.c b/src/service.c
> index 02cd51f2e104..219285439678 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -5341,7 +5341,7 @@ static void request_input_cb(struct connman_service
> *service,
>
> if (g_strcmp0(error,
> "net.connman.Agent.Error.Canceled") == 0)
> {
> - err = -EINVAL;
> + err = -ECONNABORTED;
>
> if (service->hidden)
> __connman_service_return_error(service,
> --
> 2.9.5
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20171013/74c97f50/attachment-0001.html>
------------------------------
Message: 2
Date: Fri, 13 Oct 2017 00:25:43 +0300
From: Vasyl Vavrychuk <[email protected]>
To: [email protected]
Subject: autoconnect should be disabled while password input is in
progress
Message-ID:
<CAGj4m+4xaCASu378RRwh8BxU4YS6SDzqgxT7rZM==e=uwae...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi All,
I can reproduce situation described in this commit
https://git.merproject.org/mer-core/connman/commit/b060f70489a431b9fa13f9c47ab642edf74bdb53
1. Suppose we are already connected to some network.
2. Click on another WPA-personal network to connect for which we do not
have password recorded.
3. Password popup dialog will appear.
Problem: status of connected network will be changed to: connect-failed,
connecting... etc.
Is it possible to integrate mentioned patch?
Regards,
Vasyl
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.01.org/pipermail/connman/attachments/20171013/19de3761/attachment-0001.html>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 24, Issue 17
***************************************
