Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH v2 2/3] service: implement option to enable auto
connection for roaming services (Jonas Bonn)
----------------------------------------------------------------------
Message: 1
Date: Fri, 15 Dec 2017 10:41:58 +0100
From: Jonas Bonn <[email protected]>
To: Christophe Ronco <[email protected]>, [email protected]
Subject: Re: [PATCH v2 2/3] service: implement option to enable auto
connection for roaming services
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
On 12/15/2017 10:34 AM, Christophe Ronco wrote:
> ---
> src/service.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/service.c b/src/service.c
> index 197f266..0c422a6 100644
> --- a/src/service.c
> +++ b/src/service.c
> @@ -3809,7 +3809,8 @@ static bool is_ignore(struct connman_service *service)
> if (!service->autoconnect)
> return true;
>
> - if (service->roaming)
> + if (!connman_setting_get_bool("AutoConnectRoamingServices") &&
> + service->roaming)
Swap around the components of the test so that you check
service->roaming first before calling the "heavy" function that might do
a string comparison.? service->roaming is both unlikely and quicker to
check.
/Jonas
> return true;
>
> if (service->ignore)
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 26, Issue 15
***************************************
