Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 3/3] gsupplicant: Report changes of network WPS
capabilities. (Robert Tiemann)
----------------------------------------------------------------------
Message: 1
Date: Fri, 12 Jan 2018 14:13:38 +0100
From: Robert Tiemann <[email protected]>
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH 3/3] gsupplicant: Report changes of network WPS
capabilities.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8
On 01/12/2018 01:30 PM, Daniel Wagner wrote:
>> This comment is part of what I've copied from function network_added()
>> in the same file. Should I fix the comment style in the original place
>> as well?
>
> Ah I see. No, leave the old comment as it is. It would just introduce
> unnecessary white space changes in the commit history. There are a few
> other places which have the other comment style. So we either change all
> of them or leave them as they are. But it's just not worth the extra
> noise in the commit history in my opinion.
Same thinking here, I actually prefer your comment style as well.
I wanted to keep the two duplicated portions as equal as possible.
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 27, Issue 8
**************************************
