Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] iptables: Add duplicate chain check to
iptables_add_chain(). (Daniel Wagner)
2. Re: [PATCH] iptables: allow netmask 32 in parse_ip_and_mask()
(Daniel Wagner)
3. Re: [PATCH] iptables: Fix iptables protocol usage with -p
switch. (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Sun, 28 Jan 2018 18:54:18 +0100
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>, [email protected]
Subject: Re: [PATCH] iptables: Add duplicate chain check to
iptables_add_chain().
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jussi,
On 01/26/2018 05:20 PM, Jussi Laakkonen wrote:
> This commit adds a check to iptables_add_chain() before new chain is added. If
> a chain with same name is found -EEXIST will be returned.
>
> Without this, e.g., chain INPUT can be duplicated to iptables filter table and
> it cannot be removed with iptables_remove_chain() or iptables -X. After boot
> the duplicate builtin chain is removed.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 2
Date: Sun, 28 Jan 2018 18:54:37 +0100
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>, [email protected]
Subject: Re: [PATCH] iptables: allow netmask 32 in parse_ip_and_mask()
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jussi,
On 01/26/2018 05:21 PM, Jussi Laakkonen wrote:
> Netmask 32 should not be treated as invalid value.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 3
Date: Sun, 28 Jan 2018 18:55:33 +0100
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>, [email protected]
Subject: Re: [PATCH] iptables: Fix iptables protocol usage with -p
switch.
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jussi,
On 01/26/2018 05:21 PM, Jussi Laakkonen wrote:
> This commit fixes protocol use with iptables management. Protocol type is
> changed to uint16_t, which is the type xtables_parse_protocol() returns.
>
> Without this fix iptables rules with switch -p cannot be added to iptables and
> setsockopt() in iptables_replace() will return error: Invalid argument.
Patch applied after
> +
> + /* If protocol was set add it to ipt_ip.
> + * xtables_parse_protocol() returns 0 or UINT16_MAX
> (-1) on error
> + * */
> + if (ctx->proto > 0 && ctx->proto < UINT16_MAX)
> + ctx->ip->proto = ctx->proto;
changing the comment style to
/*
* asdf
*/
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 27, Issue 22
***************************************
