Send connman mailing list submissions to connman@lists.01.org To subscribe or unsubscribe via the World Wide Web, visit https://lists.01.org/mailman/listinfo/connman or, via email, send a message with subject or body 'help' to connman-requ...@lists.01.org
You can reach the person managing the list at connman-ow...@lists.01.org When replying, please edit your Subject line so it is more specific than "Re: Contents of connman digest..." Today's Topics: 1. [PATCH] config: fix incorrect timeservers assignment (Alexander Kochetkov) ---------------------------------------------------------------------- Message: 1 Date: Mon, 19 Mar 2018 15:02:08 +0300 From: Alexander Kochetkov <al.koc...@gmail.com> To: connman@lists.01.org Subject: [PATCH] config: fix incorrect timeservers assignment Message-ID: <1521460928-4270-1-git-send-email-al.koc...@gmail.com> The command 'connmanctl config <service> --timeservers' (with empty --timeservers argument) will clear timeservers array. Timeservers obtained from dhcp will be dropped from timeservers array after the command. That looks like copy/paste error. Instead of clearing timeservers_config array the code clears timeservers array. Signed-off-by: Alexander Kochetkov <al.koc...@gmail.com> --- src/service.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/service.c b/src/service.c index ab5b2c6..529be38 100644 --- a/src/service.c +++ b/src/service.c @@ -3564,8 +3564,7 @@ static DBusMessage *set_property(DBusConnection *conn, char **timeservers = g_strsplit_set(str->str, " ", 0); timeservers = remove_empty_strings(timeservers); service->timeservers_config = timeservers; - } else - service->timeservers = NULL; + } g_string_free(str, TRUE); -- 1.7.9.5 ------------------------------ Subject: Digest Footer _______________________________________________ connman mailing list connman@lists.01.org https://lists.01.org/mailman/listinfo/connman ------------------------------ End of connman Digest, Vol 29, Issue 17 ***************************************