Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [RFC PATCH 07/27] shared/arp: Add random_ip() (Daniel Wagner)
2. Re: [RFC PATCH 09/27] Add Address Conflict Detection support
(RFC 5227) (Daniel Wagner)
3. Re: [RFC PATCH 00/27] Implement Address Conflict Detection
(ACD), RFC 5227 (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Wed, 28 Mar 2018 20:26:00 +0200
From: Daniel Wagner <[email protected]>
To: Christian Spielberger <[email protected]>
Cc: Peter Meerwald-Stadler <[email protected]>, [email protected]
Subject: Re: [RFC PATCH 07/27] shared/arp: Add random_ip()
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
On 03/21/2018 02:42 PM, Peter Meerwald-Stadler wrote:
> diff --git a/gdhcp/ipv4ll.h b/gdhcp/ipv4ll.h
> deleted file mode 100644
> index 315ca3db..00000000
> --- a/gdhcp/ipv4ll.h
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -/*
> - *
> - * IPV4 Local Link library with GLib integration
> - *
> - * Copyright (C) 2009-2010 Aldebaran Robotics. All rights reserved.
I think you moved parts of the ipv4ll code base to a new file and
dropped the copyright statement. Please move the copyright statement
also to the new place if you just moved code around.
Thanks,
Daniel
------------------------------
Message: 2
Date: Wed, 28 Mar 2018 20:36:34 +0200
From: Daniel Wagner <[email protected]>
To: Christian Spielberger <[email protected]>
Cc: Peter Meerwald-Stadler <[email protected]>, [email protected]
Subject: Re: [RFC PATCH 09/27] Add Address Conflict Detection support
(RFC 5227)
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
> --- /dev/null
> +++ b/include/acd.h
> @@ -0,0 +1,36 @@
> +/*
> + *
> + * Address Conflict Detection (RFC 5227)
> + *
> + * based on DHCP client library with GLib integration,
> + * Copyright (C) 2009-2014 Intel Corporation. All rights reserved.
> + *
> + * Copyright (C) 2018 Commend International. All rights reserved.
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
Nitpicking: We have almost consistently pattern of the copyright header.
Please follow the style. In this example the first line should be
/*
*
* Connection Manager
*
[ bla bla ]
*/
And then you can add comments such as the "Address Conflict Detection
(RFC 5227)" part.
Thanks,
Daniel
------------------------------
Message: 3
Date: Wed, 28 Mar 2018 20:43:35 +0200
From: Daniel Wagner <[email protected]>
To: Christian Spielberger <[email protected]>
Cc: [email protected]
Subject: Re: [RFC PATCH 00/27] Implement Address Conflict Detection
(ACD), RFC 5227
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Christian,
I just gave it a quick look and there was nothing really icky in my
eyes. As we already discussed if you could move the parts in service.c
to network.c that would be great.
Excellent work!
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 29, Issue 29
***************************************
