Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 10/27] acd: add functions start/stop_listening
(Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Wed, 2 May 2018 08:45:57 +0200
From: Daniel Wagner <w...@monom.org>
To: Christian Spielberger <christian.spielber...@gmail.com>
Cc: connman@lists.01.org
Subject: Re: [PATCH 10/27] acd: add functions start/stop_listening
Message-ID: <27523ec6-bc8b-1b29-621a-95d49872b...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Christian,
On 04/30/2018 03:25 PM, Christian Spielberger wrote:
> Hi Daniel,
>
> now I use your build-connman.sh. But I have to ask you if you really want
> "-Werror", "-Werror=unused-function" for intermediate patches? It would be a
> lot of work for me to split the patches differently in order to make it
> compilable with this switches. We just tried to avoid one big patch for the
> whole acd.c.
>
> I agree that "-Werror=implicit-function-declaration" makes sense. But if you
> prefer the whole "-Werror" switch, I will do my best.
I see. Well, I prefer to keep the current patchset structure. The
structure is good to follow and to review. So I am rather keep that
property then insisting it needs to compile all in the middle patches
without any warnings. I suggest you post the v3 without any
restructuring. Maybe we could add a compiler pragma for those function
until they are used.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
connman@lists.01.org
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 31, Issue 1
**************************************
