Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] add WPS patch (Daniel Wagner)
2. Re: [PATCH] ippool: Remove refcount on connman_ippool struct
(Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Tue, 10 Jul 2018 07:26:42 +0200
From: Daniel Wagner <w...@monom.org>
To: natsuki.it...@sony.com
Cc: connman@lists.01.org, i...@lists.01.org
Subject: Re: [PATCH] add WPS patch
Message-ID: <3c3bde92-0332-ae72-220c-78cd80be9...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
On 07/06/2018 12:21 PM, natsuki.it...@sony.com wrote:
> Hi,
>
> As ConnMan community previously discussed so, the WPS function has some issue.
> https://lists.01.org/pipermail/connman/2018-January/022367.html
>
> In short, following technical issues / failure cases have been identified;
> - Cannot start WPS protocol without specifying the target AP.
> - WPS protocol sometimes fails with
> + the AP that distributes multi-credentials
> + Multi-band AP
> + "Unconfigured" AP
> Due to above issues, any products which uses ConnMan cannot pass WPS
> certification test.
>
> Please find the attached patch (based on v1.36) for further details.
> We have used this patch for several months and have not seen any negative
> side effects.
The patch itself doesn't look too scary but it needs to be splitted into
reasonable junks with commit messages which explains the change.
> To fix issues, we've separated current WPS protocol procedure into
> a "credential distribution" and a "connection" processes.
>
> Proposed WPS API do only receive credential(s) delivered by WPS protocol.
> The connman notify service(s) that receive WPS credential, an upper layer
> application,
> like the connmanctl, must call "connect API" to the service.
>
> Please take a look at proposed patch, and give us your opinion
> so that we can get an advice on how we should proceed to contribute this patch
> into ConnMan official codebase for future releases.
My main concern is the proposed API. I haven't really figured out how it
fits
into the current API. My first impression is that it doesn't fit with
what we have already for WPS.
@iwd: I have lost a bit track what APIs iwd is offering for WPS. Is an
API like proposed below possible to implement for iwd?
> index e3c1dcde..24b7f762 100644
> --- a/doc/agent-api.txt
> +++ b/doc/agent-api.txt
> @@ -141,6 +141,12 @@ Fields string Name
> In case of a RequestPeerAuthorization, this field will
> be set as mandatory.
>
> + To use this in order to get connected to a given
> + services is deprecated and should not be used. Methods
> + Technology.Start_STA_WPS and Technology.Start_AP_WPS
> + are provided by ConnMan and user should use those two
> + instead.
> +
> string Username
>
> Username for WISPr authentication. This field will be
> diff --git a/doc/technology-api.txt b/doc/technology-api.txt
> index f22e9b29..75c1091d 100644
> --- a/doc/technology-api.txt
> +++ b/doc/technology-api.txt
> @@ -40,6 +40,49 @@ Methods dict GetProperties() [deprecated]
> via the PeersChanged signal from the manager
> interface.
>
> + void Start_AP_WPS(string authentication)
> +
> + Start a WPS Session when the system is playing AP
> + role (Tethering) in order to allow potential Ex-STAs
> + to get connected by using WPS.
> +
> + The argument indicates the WPS authentication method
> + which can be an empty string, if user wants to use
> + push-button method, or a pin code if user wants to
> + use the pin method.
> +
> + This method is supported only by WiFi technology.
> +
> + Possible Errors: [service].Error.InvalidArguments
> + [service].Error.PermissionDenied
> + [service].Error.NotSupported
> +
> + void Start_STA_WPS(string authentication)
> +
> + Start a WPS Session in STA role in order to be able
> + to get connected with an Ex-AP with WPS capabilities.
> +
> + The argument indicates the WPS authentication method
> + which can be an empty string, if user wants to use
> + push-button method, or a pin code if user wants to
> + use the pin method.
> +
> + This method is supported only by WiFi technology.
> +
> + Possible Errors: [service].Error.InvalidArguments
> + [service].Error.OperationAborted
> + [service].Error.OperationTimeout
> + [service].Error.NotConnected
> + [service].Error.NotSupported
> +
> + void Cancel_WPS()
> +
> + Cancel ongoing WPS session.
> +
> + This method is supported only by WiFi technology.
> +
> + Possible Errors: [service].Error.NotSupported
> +
> Signals PropertyChanged(string name, variant value)
>
> This signal indicates a changed value of the given
Thanks,
Daniel
------------------------------
Message: 2
Date: Tue, 10 Jul 2018 07:34:46 +0200
From: Daniel Wagner <w...@monom.org>
To: Nicolas Cornu <nicola...@yahoo.fr>, conn...@connman.net
Cc: Nicolas Cornu <n.co...@overkiz.com>
Subject: Re: [PATCH] ippool: Remove refcount on connman_ippool struct
Message-ID: <a15f720d-a504-d9d4-712b-40001c017...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Nicolas,
On 07/06/2018 04:12 PM, Nicolas Cornu wrote:
> From: Nicolas Cornu <n.co...@overkiz.com>
>
> No one is using it, and it let us NULL the global ippool in tethering.
Patch applied.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
connman@lists.01.org
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 33, Issue 3
**************************************
