Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [Patch] Bug fix when switching happens from Auto to Manual
(Rahul Jain)
2. [Patch] Bug fix when switching happens from Auto to Manual
(Rahul Jain)
----------------------------------------------------------------------
Message: 1
Date: Tue, 07 Aug 2018 14:12:51 +0530
From: Rahul Jain <[email protected]>
To: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: AMIT KUMAR JAISWAL <[email protected]>
Subject: [Patch] Bug fix when switching happens from Auto to Manual
Message-ID: <445089619.1115042.1533631371416.JavaMail.jboss@ep2ml501>
Content-Type: text/plain; charset="utf-8"
??
Author: Rahul Jain <[email protected]>
Date:?? Fri Jul 27 14:32:51 2018 +0530
??? When a device having auto IP configurations, is connected
??? to router in which DHCP is not running, device will go for
??? IPv4All configuration and will get IP(like 169.254.xxx.xxx).
??? Inside connman/src/dhcp.c:dhcpipv4ll_available_cb(), dhcp ipconfig set to
AUTO.
??? Now if user tries to configure manual IP, it fails.
??? As per current code, dhcp stop function (__connman_dhcp_stop) will not be
called for IPv5.
???
??? Signed-off-by: Rahul Jain <[email protected]>
diff --git a/src/network.c b/src/network.c
index c3a7cbf..c910afd 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1872,12 +1872,15 @@ int __connman_network_clear_ipconfig(struct
connman_network *network,
??case CONNMAN_IPCONFIG_METHOD_OFF:
??case CONNMAN_IPCONFIG_METHOD_FIXED:
???return -EINVAL;
-?case CONNMAN_IPCONFIG_METHOD_AUTO:
-??release_dhcpv6(network);
-??break;
??case CONNMAN_IPCONFIG_METHOD_MANUAL:
???__connman_ipconfig_address_remove(ipconfig);
???break;
+?case CONNMAN_IPCONFIG_METHOD_AUTO:
+??release_dhcpv6(network);
+??if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
+???break;
+??// incase ipconfig->type == CONNMAN_IPCONFIG_TYPE_IPV4
+??/* fall through */
??case CONNMAN_IPCONFIG_METHOD_DHCP:
???remove_dhcp_timeout(network);
???__connman_dhcp_stop(ipconfig_ipv4);?
?
?
?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Patch.txt
Type: application/octet-stream
Size: 1398 bytes
Desc: not available
URL:
<http://lists.01.org/pipermail/connman/attachments/20180807/1099ae4c/attachment-0002.obj>
------------------------------
Message: 2
Date: Tue, 07 Aug 2018 14:12:51 +0530
From: Rahul Jain <[email protected]>
To: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Cc: AMIT KUMAR JAISWAL <[email protected]>
Subject: [Patch] Bug fix when switching happens from Auto to Manual
Message-ID: <445089619.1115042.1533631371416.JavaMail.jboss@ep2ml501>
Content-Type: text/plain; charset="utf-8"
??
Author: Rahul Jain <[email protected]>
Date:?? Fri Jul 27 14:32:51 2018 +0530
??? When a device having auto IP configurations, is connected
??? to router in which DHCP is not running, device will go for
??? IPv4All configuration and will get IP(like 169.254.xxx.xxx).
??? Inside connman/src/dhcp.c:dhcpipv4ll_available_cb(), dhcp ipconfig set to
AUTO.
??? Now if user tries to configure manual IP, it fails.
??? As per current code, dhcp stop function (__connman_dhcp_stop) will not be
called for IPv5.
???
??? Signed-off-by: Rahul Jain <[email protected]>
diff --git a/src/network.c b/src/network.c
index c3a7cbf..c910afd 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1872,12 +1872,15 @@ int __connman_network_clear_ipconfig(struct
connman_network *network,
??case CONNMAN_IPCONFIG_METHOD_OFF:
??case CONNMAN_IPCONFIG_METHOD_FIXED:
???return -EINVAL;
-?case CONNMAN_IPCONFIG_METHOD_AUTO:
-??release_dhcpv6(network);
-??break;
??case CONNMAN_IPCONFIG_METHOD_MANUAL:
???__connman_ipconfig_address_remove(ipconfig);
???break;
+?case CONNMAN_IPCONFIG_METHOD_AUTO:
+??release_dhcpv6(network);
+??if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
+???break;
+??// incase ipconfig->type == CONNMAN_IPCONFIG_TYPE_IPV4
+??/* fall through */
??case CONNMAN_IPCONFIG_METHOD_DHCP:
???remove_dhcp_timeout(network);
???__connman_dhcp_stop(ipconfig_ipv4);?
?
?
?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Patch.txt
Type: application/octet-stream
Size: 1398 bytes
Desc: not available
URL:
<http://lists.01.org/pipermail/connman/attachments/20180807/1099ae4c/attachment-0003.obj>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 34, Issue 2
**************************************
