Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] dhcp: Prefer to reuse broadcast flag from
DHCPDISCOVER (Daniel Wagner)
2. Re: [PATCH] inet: Treat NULL and any address gateways as the
same (Daniel Wagner)
3. Re: [PATCH] service: do not reply twice to Connect (Daniel Wagner)
4. Re: [Patch] Bug fix when switching happens from Auto to
Manual (Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Tue, 14 Aug 2018 07:48:35 +0200
From: Daniel Wagner <[email protected]>
To: Slava Monich <[email protected]>, [email protected]
Subject: Re: [PATCH] dhcp: Prefer to reuse broadcast flag from
DHCPDISCOVER
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Slava,
On 08/02/2018 04:52 PM, Slava Monich wrote:
> Some (broken?) DHCP servers are picky about the BROADCAST flag.
> They may respond with an IP broadcast, but ignore requests with
> the BROADCAST flag set. IP unicast received from the server, on
> the other hand, should guarantee that the server is ok with the
> BROADCAST bit cleared.
Patch applied.
Thanks,
Daniel
------------------------------
Message: 2
Date: Tue, 14 Aug 2018 07:55:49 +0200
From: Daniel Wagner <[email protected]>
To: Jussi Laakkonen <[email protected]>, [email protected]
Subject: Re: [PATCH] inet: Treat NULL and any address gateways as the
same
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Jussi,
On 08/08/2018 11:00 AM, Jussi Laakkonen wrote:
> This fixes an issue of treating an any address (IPv4 or IPv6) as gateway
> address when adding routes, which causes RTF_GATEWAY flag being set and
> adding of such route to fail. RTF_GATEWAY should be set only when the
> address is an real IP address.
>
> In addition, when adding a IPv6 route the return value of inet_pton() is
> utilized in order to check for the address validity before enabling
> RTF_GATEWAY flag.
>
> Added a helper function (__connman_inet_is_any_addr()) to check if an
> IPv4 or IPv6 address is an any address. For convenience and future use
> function prototype is added to src/connman.h.
Patch applied after renaming rval to ret to be a bit more consistent
with existing code.
Thanks,
Daniel
------------------------------
Message: 3
Date: Tue, 14 Aug 2018 08:23:37 +0200
From: Daniel Wagner <[email protected]>
To: Beno?t Monin <[email protected]>, [email protected]
Subject: Re: [PATCH] service: do not reply twice to Connect
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Beno?t,
On 08/12/2018 03:11 PM, Beno?t Monin wrote:
> Calling Connect an a service sometime triggers the following error message in
> the log:
>
> dbus-daemon[591]: [system] Rejected send message, 0 matched rules;
> type="method_return", sender=":1.139" (uid=0 pid=27373
> comm="/usr/sbin/connmand -n -d ") interface="(unset)" member="(unset)" error
> name="(unset)" requested_reply="0" destination=":1.141" (uid=0 pid=27384
> comm="/usr/bin/connmanctl ")
>
> This is caused by connmand replying twice to the Connect method. It can be
> reproduced by calling connect on a manually configured ethernet service while
> checking the dbus exchange with dbus-monitor. The dbus daemon rejects the
> second reply since there is no corresponding method call.
Good catch!
> Fix this by exiting connect_service before sending another reply if the
> pending reply has already been sent.
I am not convinced that your patch is complete correct. In case where
__connman_service_connect() returns with success instead of EINPROGRESS
then your patch could it up the response, no?
Suppose that autoconnect is happening in the background and the user
calls 'Connect' before the Service was online. In this case we used to
send an 'error already' back.
The question is why does ConnMan send the same response twice? Can you
send a log?
Thanks,
Dnaiel
------------------------------
Message: 4
Date: Tue, 14 Aug 2018 08:25:53 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: [email protected]
Subject: Re: [Patch] Bug fix when switching happens from Auto to
Manual
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Rahul,
Can you resend your patch as proper formated patch. Your email received
me completely white space damaged.
Thanks,
Daniel
On 08/07/2018 10:42 AM, Rahul Jain wrote:
>
> Author: Rahul Jain <[email protected]>
>
> Date:?? Fri Jul 27 14:32:51 2018 +0530
> ??? When a device having auto IP configurations, is connected
>
> ??? to router in which DHCP is not running, device will go for
>
> ??? IPv4All configuration and will get IP(like 169.254.xxx.xxx).
>
> ??? Inside connman/src/dhcp.c:dhcpipv4ll_available_cb(), dhcp ipconfig set
> to AUTO.
>
> ??? Now if user tries to configure manual IP, it fails.
>
> ??? As per current code, dhcp stop function (__connman_dhcp_stop) will not
> be called for IPv5.
>
>
>
> ??? Signed-off-by: Rahul Jain <[email protected]>
> diff --git a/src/network.c b/src/network.c
>
> index c3a7cbf..c910afd 100644
>
> --- a/src/network.c
>
> +++ b/src/network.c
>
> @@ -1872,12 +1872,15 @@ int __connman_network_clear_ipconfig(struct
> connman_network *network,
>
> ??case CONNMAN_IPCONFIG_METHOD_OFF:
>
> ??case CONNMAN_IPCONFIG_METHOD_FIXED:
>
> ???return -EINVAL;
>
> -?case CONNMAN_IPCONFIG_METHOD_AUTO:
>
> -??release_dhcpv6(network);
>
> -??break;
>
> ??case CONNMAN_IPCONFIG_METHOD_MANUAL:
>
> ???__connman_ipconfig_address_remove(ipconfig);
>
> ???break;
>
> +?case CONNMAN_IPCONFIG_METHOD_AUTO:
>
> +??release_dhcpv6(network);
>
> +??if (type == CONNMAN_IPCONFIG_TYPE_IPV6)
>
> +???break;
>
> +??// incase ipconfig->type == CONNMAN_IPCONFIG_TYPE_IPV4
No // comments please. Check our codingstyle document.
>
> +??/* fall through */
>
> ??case CONNMAN_IPCONFIG_METHOD_DHCP:
>
> ???remove_dhcp_timeout(network);
>
> ???__connman_dhcp_stop(ipconfig_ipv4);
>
>
>
>
>
>
>
> _______________________________________________
> connman mailing list
> [email protected]
> https://lists.01.org/mailman/listinfo/connman
>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 34, Issue 5
**************************************
