Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [Question]: Scan schedule (Daniel Wagner)
2. Re: [PATCH] ipconfig: Incase of Manual IP Configuration,
saving Gateway information during network switch (Daniel Wagner)
3. Re: [PATCH] [dnsproxy] Simplified udp_server_event()
(Daniel Wagner)
----------------------------------------------------------------------
Message: 1
Date: Sat, 25 Aug 2018 17:14:34 +0200
From: Daniel Wagner <[email protected]>
To: M?ns Zigher <[email protected]>
Cc: [email protected]
Subject: Re: [Question]: Scan schedule
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi M?ns,
On 08/23/2018 11:44 AM, M?ns Zigher wrote:
> I am developing an application that is using the dbus api. The
> application will setup the wifi for the unit. I am struggling a bit to
> see the best practice for making sure we have fully updated list of
> services. I know I can configure connman to automatically scan by
> using?BackgroundScanning which is by default set to true. Is the best
> practice to let connman manage the scanning or should my application
> trigger a scan whenever needed. The default scan schedule for connman is
> not enough as I see it but I know you can setup a scan schedule in
> wpa_supplicant but it looks like connman is starting wpa_supplicant so I
> am not sure how to change this default scan schedule that connman is
> setting up. Any comments are appreciated.
The theory is that the application/user shouldn't worry about scanning.
Even ConnMan shouldn't worry about this. Unfortunately, wpa_supplicant
doesn't do the full job. That's why ConnMan's wpa_supplicant plugin is
so complex (a mess).
Obviously, there are scenarios where you want to tell ConnMan do a scan
now. But you should not constantly tell ConnMan to do a scan. I am sure
this will have some nasty side effects.
Alternatively, you could give iwd a try. Though the current plugin is
only supported the very basic stuff. Needs some more work.
Thanks,
Daniel
------------------------------
Message: 2
Date: Sat, 25 Aug 2018 17:50:12 +0200
From: Daniel Wagner <[email protected]>
To: [email protected]
Cc: "[email protected]" <[email protected]>, AMIT KUMAR JAISWAL
<[email protected]>, Craig McQueen
<[email protected]>
Subject: Re: [PATCH] ipconfig: Incase of Manual IP Configuration,
saving Gateway information during network switch
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Rahul,
You getting better with the patch submission. I really appreciate your
effort!
On 08/23/2018 01:55 PM, Rahul Jain wrote:
> Subject: [PATCH] ipconfig: Incase of Manual IP Configuration, saving Gateway
> information during network switch
This seems to be a repetition of the emails subject. I usually send my
changes out with 'git format-patch' and 'git send-email'.
Anyway, try to trip the subject a bit. Just mention what you change.
Maybe something like 'Save gateway information'
> [Problem] If user use manual IP configuration while connect with
> network(suppose wired).
> Then during network switch (suppose from wired to wireless), gateway will not
> be saved into
> /var/lib/connman respective profile settings.
> So when user come back to earlier network(suppose wired again),
> then connection will fail as connman does not have gateway(wrong gateway as
> 0.0.0.0) to connect.
>
> [Solution] When device switch from wired to wireless network, gateway
> information was missed
> to be saved into /var/lib/connman respective profile. So during Network switch
> service_save()->__connman_ipconfig_save() will not remove "IPV4.gateway" key
> from respective profile settings file.
Format your commit message so that you don't exceed the 80 chars per line.
> Signed-off-by: Rahul Jain <[email protected]>
We don't do Signed-off-by at this project.
> ---
> src/ipconfig.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/src/ipconfig.c b/src/ipconfig.c
> index 2565773..a2e398d 100644
> --- a/src/ipconfig.c
> +++ b/src/ipconfig.c
> @@ -2346,8 +2346,6 @@ int __connman_ipconfig_save(struct connman_ipconfig
> *ipconfig,
> if (ipconfig->address->gateway)
> g_key_file_set_string(keyfile, identifier,
> key, ipconfig->address->gateway);
> - else
> - g_key_file_remove_key(keyfile, identifier, key, NULL);
> g_free(key);
The g_key_file_remove_key() has been added by Craig: 60facabb03a9
("ipconfig: Remove IPv4.gateway key in settings if gateway is not
configured").
I am not sure if I am really understand the problem you want to fix. The
code you are deleting seems quite reasonable. If gateway is valid
(!NULL) save it, otherwise remove it. (The code above these lines should
probably do the same but that's a different story).
Does the initial network have a proper configuration, that is it
contains a valid gateway? If so why is it missing when we reach
__connman_ipfconfig_save()? Do we call __connman_ipconfig_save() too late?
Thanks,
Daniel
------------------------------
Message: 3
Date: Sat, 25 Aug 2018 17:53:54 +0200
From: Daniel Wagner <[email protected]>
To: Slava Monich <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH] [dnsproxy] Simplified udp_server_event()
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Slava,
Patch applied.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 34, Issue 14
***************************************
