Send connman mailing list submissions to
connman@lists.01.org
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
connman-requ...@lists.01.org
You can reach the person managing the list at
connman-ow...@lists.01.org
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH 2/2] service: Remove __connman_service_get_order()
(Daniel Wagner)
2. Re: [PATCH] plugins: ethernet: get rid of truncate warning
(Marcus Folkesson)
----------------------------------------------------------------------
Message: 1
Date: Wed, 29 Aug 2018 20:54:41 +0200
From: Daniel Wagner <w...@monom.org>
To: Slava Monich <slava.mon...@jolla.com>
Cc: connman@lists.01.org
Subject: Re: [PATCH 2/2] service: Remove __connman_service_get_order()
Message-ID: <a3cf70ad-6263-bcd1-0be9-31725278a...@monom.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi Slava,
Both patches applied.
On 08/29/2018 04:43 PM, Slava Monich wrote:
> It doesn't do anything that's not done by set_split_routing()
> and its return value was never used.
No idea what Patrik wanted to do with that function. Anyway, it was
doing nothing for a long time so no need to keep it around.
Thanks!
Daniel
------------------------------
Message: 2
Date: Wed, 29 Aug 2018 20:56:21 +0200
From: Marcus Folkesson <marcus.folkes...@gmail.com>
To: Daniel Wagner <w...@monom.org>
Cc: connman@lists.01.org
Subject: Re: [PATCH] plugins: ethernet: get rid of truncate warning
Message-ID: <20180829185621.ga1...@gmail.com>
Content-Type: text/plain; charset="utf-8"
Hi Daniel,
On Wed, Aug 29, 2018 at 08:37:43PM +0200, Daniel Wagner wrote:
> Hi Marcus,
>
> On 08/27/2018 02:32 PM, Marcus Folkesson wrote:
> > The buffer will never be truncated in reality, but it is the only
> > warning during compile... so get rid of it.
>
> I suppose this is a very new gcc?
>
Not the most recent, but still pretty new:
gcc (GCC) 8.1.1 20180531
> >
> > The ethtool_cmd.phy_address used as dsaport is an __u8, so a `char` is
> > sufficient.
> >
> > Use `char` as dsaport to not make snprintf nervous about truncating
> > something.
> >
> > Warning:
> > ----------------------->8-----------------------------------
> >
> > plugins/ethernet.c: In function ?ethernet_newlink?:
> > plugins/ethernet.c:208:52: warning: ?__builtin___snprintf_chk? output may
> > be truncated before the last format character [-Wformat-truncation=]
> > snprintf(group, sizeof(group), "p%02x_%03x_cable", dsaport, vid);
> > ^
> > In file included from /usr/include/stdio.h:862,
> > from plugins/ethernet.c:31:
> > /usr/include/bits/stdio2.h:64:10: note: ?__builtin___snprintf_chk? output
> > between 14 and 17 bytes into a destination of size 16
> > return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > __bos (__s), __fmt, __va_arg_pack ());
> > ----------------------->8-----------------------------------
> >
> > Signed-off-by: Marcus Folkesson <marcus.folkes...@gmail.com>
>
> Patch applied. I dropped the SoB because we don't do it here.
Thanks, saw you mail about v2 :-)
>
> Thanks,
> Daniel
Best regards,
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL:
<http://lists.01.org/pipermail/connman/attachments/20180829/dfaab84e/attachment-0001.asc>
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list
connman@lists.01.org
https://lists.01.org/mailman/listinfo/connman
------------------------------
End of connman Digest, Vol 34, Issue 20
***************************************
