Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. Issues in vpn l2tp and pptp plugins (Artem Yamshanov)


----------------------------------------------------------------------

Message: 1
Date: Sun, 3 Feb 2019 12:32:58 +0700
From: Artem Yamshanov <[email protected]>
To: [email protected]
Subject: Issues in vpn l2tp and pptp plugins
Message-ID:
        <caoxm6vjv3khgna7bszdcag0g0plbqp1x2se1mgdqkp33eqm...@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"

Hi!

I have found some bug in vpn l2tp and pptp plugins: logfd is not append to
connman-ppp-option.conf, it leads to extra output ("Plugin /usr/lib64/
connman/scripts/libppp-plugin.so loaded.") to xl2tpd or pptp and it brakes
PPP connection.

Patch is pretty simple:
--- a/vpn/plugins/l2tp.c
+++ b/vpn/plugins/l2tp.c
@@ -382,6 +382,7 @@ static int write_pppd_option(struct vpn_provider
*provider, int fd)

  l2tp_write_option(fd, "nodetach", NULL);
  l2tp_write_option(fd, "lock", NULL);
+ l2tp_write_option(fd, "logfd", "2");
  l2tp_write_option(fd, "usepeerdns", NULL);
  l2tp_write_option(fd, "noipdefault", NULL);
  l2tp_write_option(fd, "noauth", NULL);
--- a/vpn/plugins/pptp.c
+++ b/vpn/plugins/pptp.c
@@ -453,6 +453,7 @@ static int run_connect(struct vpn_provider *provider,

  connman_task_add_argument(task, "nodetach", NULL);
  connman_task_add_argument(task, "lock", NULL);
+ connman_task_add_argument(task, "logfd", "2");
  connman_task_add_argument(task, "usepeerdns", NULL);
  connman_task_add_argument(task, "noipdefault", NULL);
  connman_task_add_argument(task, "noauth", NULL);

I have tried to report about this bug on https://01.org/connman, but it
looks like it does not provide public registration now.
I also tried to ask the question at #connman channel, but I was not able to
get an answer (I do not use IRC bouncer and live in GMT+7, so it was
predictable).

Thanks!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: 
<http://lists.01.org/pipermail/connman/attachments/20190203/2a28a663/attachment-0001.html>

------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 40, Issue 2
**************************************

Reply via email to