Send connman mailing list submissions to
        [email protected]

To subscribe or unsubscribe via the World Wide Web, visit
        https://lists.01.org/mailman/listinfo/connman
or, via email, send a message with subject or body 'help' to
        [email protected]

You can reach the person managing the list at
        [email protected]

When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."


Today's Topics:

   1. [PATCH] Fix faulty error handling in inet.c (Matthias Berndt)
   2. [Patch][gsupplicant]Added support for auth type "ttls" abd
      phase 2 value "GTC" incase of 802.1x Security for Peap (Rahul Jain)


----------------------------------------------------------------------

Message: 1
Date: Mon, 18 Feb 2019 00:56:57 +0100
From: Matthias Berndt <[email protected]>
To: [email protected]
Subject: [PATCH] Fix faulty error handling in inet.c
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"; Format="flowed"

[PATCH] Fix faulty error handling in inet.c


Hi,

I was recently trying to run connman on postmarketOS, and it crashed 
while setting up the routes for the wifi connection. I ran it again in 
gdb and while I couldn't get a full stacktrace, I did see that it 
crashes because it passes a NULL pointer to freeaddrinfo.

So I took a look at the source code and went through all the calls to 
that function in connman. There aren't that many, and they all have 
error handling code to prevent this - except for one. The attached 
patch should fix it.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-error-handling.patch
Type: text/x-patch
Size: 556 bytes
Desc: not available
URL: 
<http://lists.01.org/pipermail/connman/attachments/20190218/115ab859/attachment-0001.patch>

------------------------------

Message: 2
Date: Mon, 18 Feb 2019 17:54:17 +0530
From: Rahul Jain <[email protected]>
To: "[email protected]" <[email protected]>
Cc: AMIT KUMAR JAISWAL <[email protected]>, Bhaskar Dutta
        <[email protected]>
Subject: [Patch][gsupplicant]Added support for auth type "ttls" abd
        phase 2 value "GTC" incase of 802.1x Security for Peap
Message-ID:
        <20190218122417epcms5p2a121164ebfd96fc35f8654c9eb0dc783@epcms5p2>
Content-Type: text/plain; charset="utf-8"

Dear Daniel,

From: Rahul Jain <[email protected]>
Date: Mon, 18 Feb 2019 17:53:16 +0530
Subject: [PATCH] [Patch][gsupplicant]Added support for auth type ttls abd
 phase 2 value GTC incase of 802.1x Security for Peap

Signed-off-by: Rahul Jain <[email protected]>
---
 gsupplicant/supplicant.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gsupplicant/supplicant.c b/gsupplicant/supplicant.c
index b814b32..da8c52e 100644
--- a/gsupplicant/supplicant.c
+++ b/gsupplicant/supplicant.c
@@ -4698,7 +4698,9 @@ static void add_network_security_peap(DBusMessageIter 
*dict,
 
        }
 
-       if (g_str_has_prefix(ssid->phase2_auth, "EAP-")) {
+       if(g_strcmp0(ssid->phase2_auth, "GTC") == 0 && g_strcmp0(ssid->eap, 
"ttls") == 0)
+               phase2_auth = g_strdup_printf("autheap=%s", ssid->phase2_auth);
+       else if (g_str_has_prefix(ssid->phase2_auth, "EAP-")) {
                phase2_auth = g_strdup_printf("autheap=%s",
                                        ssid->phase2_auth + strlen("EAP-"));
        } else
-- 
2.7.4




------------------------------

Subject: Digest Footer

_______________________________________________
connman mailing list
[email protected]
https://lists.01.org/mailman/listinfo/connman


------------------------------

End of connman Digest, Vol 40, Issue 8
**************************************

Reply via email to