Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] vpnc: Inform VPN agent about authentication errors
(Jussi Laakkonen)
2. [PATCH] l2tp: Cancel queued VPN agent msg when disconnected
(Jussi Laakkonen)
3. [PATCH] l2tp: Inform VPN agent about authentication errors
(Jussi Laakkonen)
----------------------------------------------------------------------
Date: Wed, 23 Oct 2019 17:12:28 +0300
From: Jussi Laakkonen <[email protected]>
Subject: [PATCH] vpnc: Inform VPN agent about authentication errors
To: [email protected]
Message-ID: <[email protected]>
Send "VpnAgent.AuthFailure" to VPN agent if there are authentication
errors to indicate that previous login has failed and new credentials
are required to be given. Authentication errors are detected from the
output of VPNC process in io_channel_cb().
---
vpn/plugins/vpnc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vpn/plugins/vpnc.c b/vpn/plugins/vpnc.c
index 808c36cd..8927a6f7 100644
--- a/vpn/plugins/vpnc.c
+++ b/vpn/plugins/vpnc.c
@@ -723,6 +723,9 @@ static int request_input_credentials(struct vc_private_data
*data,
connman_dbus_dict_open(&iter, &dict);
+ if (vpn_provider_get_authentication_errors(data->provider))
+ vpn_agent_append_auth_failure(&dict, data->provider, NULL);
+
request_input_append_to_dict(data->provider, &dict,
request_input_append_password,
"VPNC.IPSec.Secret");
--
2.20.1
------------------------------
Date: Wed, 23 Oct 2019 17:15:22 +0300
From: Jussi Laakkonen <[email protected]>
Subject: [PATCH] l2tp: Cancel queued VPN agent msg when disconnected
To: [email protected]
Message-ID: <[email protected]>
Queued VPN agent messages must be canceled if the plugin timeouts
without starting the process. This fixes the issue of having multiple
VPN agent queries stacked on another in such scenario, where L2TP is
awaiting for user input.
---
vpn/plugins/l2tp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/vpn/plugins/l2tp.c b/vpn/plugins/l2tp.c
index ff5f08b9..91137aae 100644
--- a/vpn/plugins/l2tp.c
+++ b/vpn/plugins/l2tp.c
@@ -795,7 +795,12 @@ static int l2tp_error_code(struct vpn_provider *provider,
int exit_code)
static void l2tp_disconnect(struct vpn_provider *provider)
{
+ if (!provider)
+ return;
+
vpn_provider_set_string(provider, "L2TP.Password", NULL);
+
+ connman_agent_cancel(provider);
}
static struct vpn_driver vpn_driver = {
--
2.20.1
------------------------------
Date: Wed, 23 Oct 2019 17:17:43 +0300
From: Jussi Laakkonen <[email protected]>
Subject: [PATCH] l2tp: Inform VPN agent about authentication errors
To: [email protected]
Message-ID: <[email protected]>
Send "VpnAgent.AuthFailure" to VPN agent if there are authentication
errors to indicate that previous login has failed and new credentials
are required to be given. The authentication errors with L2TP are
recorded when in notify function (l2tp_notify()) auth error is given
as reason -> vpn.c:vpn_nofity() calls vpn_provider_indicate_error().
---
vpn/plugins/l2tp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/vpn/plugins/l2tp.c b/vpn/plugins/l2tp.c
index 91137aae..2255daaa 100644
--- a/vpn/plugins/l2tp.c
+++ b/vpn/plugins/l2tp.c
@@ -605,6 +605,9 @@ static int request_input(struct vpn_provider *provider,
connman_dbus_dict_open(&iter, &dict);
+ if (vpn_provider_get_authentication_errors(provider))
+ vpn_agent_append_auth_failure(&dict, provider, NULL);
+
vpn_agent_append_user_info(&dict, provider, "L2TP.User");
vpn_agent_append_host_and_name(&dict, provider);
--
2.20.1
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 48, Issue 30
***************************************
