Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] openvpn: Use correct error value in VPN agent credential reply
(Jussi Laakkonen)
2. RE: simpler reproduction of connman error (Thomas Green)
----------------------------------------------------------------------
Date: Thu, 21 Nov 2019 14:45:16 +0200
From: Jussi Laakkonen <[email protected]>
Subject: [PATCH] openvpn: Use correct error value in VPN agent
credential reply
To: [email protected]
Message-ID: <[email protected]>
Use the error value set earlier instead of always reporting back EACCES
to vpn-provider.c:connect_cb().
---
vpn/plugins/openvpn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/vpn/plugins/openvpn.c b/vpn/plugins/openvpn.c
index 0f15bc37..262e1088 100644
--- a/vpn/plugins/openvpn.c
+++ b/vpn/plugins/openvpn.c
@@ -721,7 +721,7 @@ static void request_input_credentials_reply(DBusMessage
*reply,
return;
err:
- ov_connect_done(data, EACCES);
+ ov_connect_done(data, err);
}
static int request_credentials_input(struct ov_private_data *data)
--
2.20.1
------------------------------
Date: Fri, 22 Nov 2019 00:11:53 +0000
From: Thomas Green <[email protected]>
Subject: RE: simpler reproduction of connman error
To: connman <[email protected]>, Daniel Wagner <[email protected]>,
"[email protected]" <[email protected]>
Message-ID: <[email protected]
prd04.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_BYAPR04MB509613
CE732F97DBC6827F939F490BYAPR04MB5096namp_"
--_000_BYAPR04MB509613CE732F97DBC6827F939F490BYAPR04MB5096namp_
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
Has anyone in the list been able to look at this? I=92d appreciate some he=
lp.
Tom
Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=3D550986> for Window=
s 10
From: Thomas Green<mailto:[email protected]>
Sent: Friday, November 15, 2019 10:33 AM
To: Daniel Wagner<mailto:[email protected]>; [email protected]<mailto:g@berylliu=
m.lan>
Cc: [email protected]<mailto:[email protected]>
Subject: RE: simpler reproduction of connman error
Daniel,
My apologies for not posting to the list originally.
Attached is a new log, with further the further instrumentation. As you no=
tice on line 798 of the log, in __connman_ipconfig_save, the gateway is bei=
ng saved correctly. The next time ipconfig_save is called, all ipv4 entrie=
s have been cleared. As a result what is currently in the configuration fi=
le except for the gateway is re-saved. As I trace the log, I'm not sure if=
having all the ipv4 members cleared is really what is supposed to happen.
You said to also use gdb and give you a stack trace. Where would you like =
to see the trace from?
Tom
-----Original Message-----
From: Daniel Wagner [mailto:[email protected]]
Sent: Thursday, November 14, 2019 2:22 AM
To: Thomas Green <[email protected]>; [email protected]
Cc: [email protected]
Subject: Re: simpler reproduction of connman error
[EXTERNAL]
Please don't drop the mailing list. This is the last time I'll say this.
On Wed, Nov 13, 2019 at 05:01:10PM +0000, Thomas Green wrote:
> Here are two logs that capture the problem. One is much longer (we have =
a lot of wireless APs) and one that is a little more focused.
Here is when the config is reloaded triggered by the last connect. As you c=
an see the gateway is not set.
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_load() ip=
config 0x715e50 identifier ethernet_0008720978d7_cable
connmand[2761]: ../connman-1.37/src/inet.c:connman_inet_set_address() index=
3 address 10.20.187.10 prefix_len 24
connmand[2761]: ../connman-1.37/src/inet.c:__connman_inet_modify_address() =
cmd 0x14 flags 0x104 index 3 family 2 address 10.20.187.10 peer (null) pref=
ixlen 24 broadcast (null)
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_gateway_a=
dd()
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_gateway_a=
dd() type 1 gw (null) peer (null)
connmand[2761]: ../connman-1.37/src/connection.c:__connman_connection_gatew=
ay_add() service 0x705850 index 3 gateway 0.0.0.0 vpn ip (null) type 1
connmand[2761]: ../connman-1.37/src/service.c:connman_service_ref_debug() 0=
x705850 ref 2 by ../connman-1.37/src/connection.c:403:add_gateway()
So no suprise the gateway is not set. The question is why ipconfig is updat=
ed.
I starred for a while at the log but I couldn't really trace what's really =
the source of the gateway update which set it's to NULL. I suggest you inst=
rument the code at __connman_ipconfig_gateway_add(), __connman_ipconfig_loa=
d(), __connman_ipconfig_save() and __connman_ipconfig_set_gateway(). Also y=
ou might want add a breakpoint with gdb and post the stack trace.
Thanks,
Daniel
_______________________________________________
connman mailing list -- [email protected] To unsubscribe send an email t=
o [email protected]
--_000_BYAPR04MB509613CE732F97DBC6827F939F490BYAPR04MB5096namp_
Content-Type: text/html; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
<html xmlns:o=3D"urn:schemas-microsoft-com:office:office" xmlns:w=3D"urn:sc=
hemas-microsoft-com:office:word" xmlns:m=3D"http://schemas.microsoft.com/of=
fice/2004/12/omml" xmlns=3D"http://www.w3.org/TR/REC-html40";>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DWindows-1=
252">
<meta name=3D"Generator" content=3D"Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang=3D"EN-US" link=3D"blue" vlink=3D"#954F72">
<div class=3D"WordSection1">
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Has anyone in the list been able to look at this?&nb=
sp; I=92d appreciate some help.</p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Tom</p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal">Sent from <a href=3D"https://go.microsoft.com/fwlink=
/?LinkId=3D550986">
Mail</a> for Windows 10</p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<div style=3D"mso-element:para-border-div;border:none;border-top:solid #E1E=
1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class=3D"MsoNormal" style=3D"border:none;padding:0in"><b>From: </b><a hr=
ef=3D"mailto:[email protected]";>Thomas Green</a><br>
<b>Sent: </b>Friday, November 15, 2019 10:33 AM<br>
<b>To: </b><a href=3D"mailto:[email protected]";>Daniel Wagner</a>; <a href=3D"=
mailto:[email protected]";>
[email protected]</a><br>
<b>Cc: </b><a href=3D"mailto:[email protected]";>[email protected]</a>=
<br>
<b>Subject: </b>RE: simpler reproduction of connman error</p>
</div>
<p class=3D"MsoNormal"><o:p> </o:p></p>
<p class=3D"MsoNormal" style=3D"margin-bottom:12.0pt">Daniel,<br>
<br>
My apologies for not posting to the list originally.<br>
<br>
Attached is a new log, with further the further instrumentation. As y=
ou notice on line 798 of the log, in __connman_ipconfig_save, the gateway i=
s being saved correctly. The next time ipconfig_save is called, all i=
pv4 entries have been cleared. As a result
what is currently in the configuration file except for the gateway is re-s=
aved. As I trace the log, I'm not sure if having all the ipv4 members=
cleared is really what is supposed to happen.<br>
<br>
You said to also use gdb and give you a stack trace. Where would you =
like to see the trace from?<br>
<br>
Tom<br>
<br>
<br>
-----Original Message-----<br>
From: Daniel Wagner [<a href=3D"mailto:[email protected]";>mailto:[email protected]=
g</a>] <br>
Sent: Thursday, November 14, 2019 2:22 AM<br>
To: Thomas Green <[email protected]>; [email protected]<br>
Cc: [email protected]<br>
Subject: Re: simpler reproduction of connman error<br>
<br>
[EXTERNAL] <br>
<br>
Please don't drop the mailing list. This is the last time I'll say this.<br=
>
<br>
On Wed, Nov 13, 2019 at 05:01:10PM +0000, Thomas Green wrote:<br>
> Here are two logs that capture the problem. One is much longer (=
we have a lot of wireless APs) and one that is a little more focused.
<br>
<br>
Here is when the config is reloaded triggered by the last connect. As you c=
an see the gateway is not set.<br>
<br>
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_load() ip=
config 0x715e50 identifier ethernet_0008720978d7_cable<br>
connmand[2761]: ../connman-1.37/src/inet.c:connman_inet_set_address() index=
3 address 10.20.187.10 prefix_len 24<br>
connmand[2761]: ../connman-1.37/src/inet.c:__connman_inet_modify_address() =
cmd 0x14 flags 0x104 index 3 family 2 address 10.20.187.10 peer (null) pref=
ixlen 24 broadcast (null)<br>
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_gateway_a=
dd()<br>
connmand[2761]: ../connman-1.37/src/ipconfig.c:__connman_ipconfig_gateway_a=
dd() type 1 gw (null) peer (null)<br>
connmand[2761]: ../connman-1.37/src/connection.c:__connman_connection_gatew=
ay_add() service 0x705850 index 3 gateway 0.0.0.0 vpn ip (null) type 1<br>
connmand[2761]: ../connman-1.37/src/service.c:connman_service_ref_debug() 0=
x705850 ref 2 by ../connman-1.37/src/connection.c:403:add_gateway()<br>
<br>
So no suprise the gateway is not set. The question is why ipconfig is updat=
ed.<br>
<br>
I starred for a while at the log but I couldn't really trace what's really =
the source of the gateway update which set it's to NULL. I suggest you inst=
rument the code at __connman_ipconfig_gateway_add(), __connman_ipconfig_loa=
d(), __connman_ipconfig_save() and
__connman_ipconfig_set_gateway(). Also you might want add a breakpoint wit=
h gdb and post the stack trace.<br>
<br>
Thanks,<br>
Daniel<br>
<br>
_______________________________________________<br>
connman mailing list -- [email protected] To unsubscribe send an email t=
o [email protected]<o:p></o:p></p>
<p class=3D"MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>
--_000_BYAPR04MB509613CE732F97DBC6827F939F490BYAPR04MB5096namp_--
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 49, Issue 26
***************************************
