Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: Impossible to retry when entering wrong password with connmanctl.
(Daniel Wagner)
2. [PATCH] iwd: Propogate invalid key on connection attempt failure
(Daniel Wagner)
3. [PATCH] wireguard: Clear plugin data pointer on disconnect
(Daniel Wagner)
4. [PATCH] vpn: Remove unused type member (Daniel Wagner)
5. Wifi Scan Issues and Static IP for Wlan0 (chaitanya cherukuri)
6. Re: Connman 1.37 source code different in YOCTO
(chaitanya cherukuri)
----------------------------------------------------------------------
Date: Wed, 5 Feb 2020 09:28:00 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: Impossible to retry when entering wrong password with
connmanctl.
To: Maxime Roussin-Bélanger <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=iso-8859-1
On Mon, Feb 03, 2020 at 11:47:41AM -0500, Maxime Roussin-Bélanger wrote:
> https://drive.google.com/open?id=1TESYkngpIRK-QtyRxdaCXZN-5sdReFzO
After sending out the 'ReportError' in
connman_agent_report_error_full(), we keep going the state machine:
../connman-1.37/src/agent.c:connman_agent_report_error_full() agent
0x55abc416f0 sender :1.16 context 0x55abc355f0 path /net/connman/connmanctl1528
../connman-1.37/src/agent.c:connman_agent_queue_message() driver 0x557d20cc88
../connman-1.37/src/service.c:connman_service_ref_debug() 0x55abc355f0 ref 2 by
../connman-1.37/src/service.c:7438:agent_context_ref()
../connman-1.37/src/service.c:service_save() service 0x55abc355f0 new 1
../connman-1.37/src/connection.c:__connman_connection_update_gateway() default
0x55abc296b0
../connman-1.37/src/network.c:__connman_network_disconnect() network
0x55abc354c0
And then later the cancel request is send out (due to the state
machine entering disconnect state)
../connman-1.37/src/agent.c:connman_agent_cancel() context 0x55abc355f0
../connman-1.37/src/agent.c:connman_agent_cancel() cancel request 0x55abc349c0
../connman-1.37/src/agent.c:send_cancel_request() send cancel req to :1.16
/net/connman/connmanctl1528 iface net.connman.Agent
But there is nothing wierd about this. All looks good. I don't see
what's going wrong :(
------------------------------
Date: Wed, 5 Feb 2020 20:40:06 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] iwd: Propogate invalid key on connection attempt
failure
To: [email protected]
Cc: Daniel Wagner <[email protected]>, Maxime Roussin-Bélanger
<[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8
Currently all connection attempts are reported as
CONNMAN_NETWORK_ERROR_CONNECT_FAIL. When the user enters an wrong
passphrase the upper layers wont reset the passphrase unless
CONNMAN_NETWORK_ERROR_INVALID_KEY is reported. This prevents the user
to enter a new passphrase.
Unfortunately, when the passphrase is correct but the connect attempt
fails with 'Failed', ConnMan will reset the passphrase. But this
behavoir is way better then not being able to provide the correct
passphrase.
Reported-by: Maxime Roussin-Bélanger <[email protected]>
---
plugins/iwd.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index 7b5d9b92d658..39879f6f8c87 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -241,7 +241,11 @@ static void cm_network_connect_cb(DBusMessage *message,
void *user_data)
return;
DBG("%s connect failed: %s", path, dbus_error);
- connman_network_set_error(iwdn->network,
+ if (!strcmp(dbus_error, "net.connman.iwd.Failed"))
+ connman_network_set_error(iwdn->network,
+ CONNMAN_NETWORK_ERROR_INVALID_KEY);
+ else
+ connman_network_set_error(iwdn->network,
CONNMAN_NETWORK_ERROR_CONNECT_FAIL);
return;
}
--
2.25.0
------------------------------
Date: Wed, 5 Feb 2020 20:43:03 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] wireguard: Clear plugin data pointer on disconnect
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Message-ID: <[email protected]>
The private data should be cleared on disconnect to avoid an invalid
access. For example the user could call disconnect twice which leads
to a crash.
---
vpn/plugins/wireguard.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/vpn/plugins/wireguard.c b/vpn/plugins/wireguard.c
index 061be789fa59..de2dbda3878e 100644
--- a/vpn/plugins/wireguard.c
+++ b/vpn/plugins/wireguard.c
@@ -375,6 +375,10 @@ static void wg_disconnect(struct vpn_provider *provider)
struct wireguard_info *info;
info = vpn_provider_get_plugin_data(provider);
+ if (!info)
+ return;
+ vpn_provider_set_plugin_data(provider, NULL);
+
wg_del_device(info->device.name);
g_free(info);
--
2.25.0
------------------------------
Date: Wed, 5 Feb 2020 20:43:54 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] vpn: Remove unused type member
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Message-ID: <[email protected]>
There is no setter for the VPN type member. Remove it since it has no
functional use.
---
vpn/vpn-provider.c | 1 -
vpn/vpn-provider.h | 6 ------
2 files changed, 7 deletions(-)
diff --git a/vpn/vpn-provider.c b/vpn/vpn-provider.c
index fd5fd91078ca..d104ed87260a 100644
--- a/vpn/vpn-provider.c
+++ b/vpn/vpn-provider.c
@@ -2978,7 +2978,6 @@ void vpn_provider_driver_unregister(struct
vpn_provider_driver *driver)
struct vpn_provider *provider = value;
if (provider && provider->driver &&
- provider->driver->type == driver->type &&
g_strcmp0(provider->driver->name,
driver->name) == 0) {
provider->driver = NULL;
diff --git a/vpn/vpn-provider.h b/vpn/vpn-provider.h
index af8c97780f01..0275d51a4d9e 100644
--- a/vpn/vpn-provider.h
+++ b/vpn/vpn-provider.h
@@ -37,11 +37,6 @@ extern "C" {
* @short_description: Functions for handling providers
*/
-enum vpn_provider_type {
- VPN_PROVIDER_TYPE_UNKNOWN = 0,
- VPN_PROVIDER_TYPE_VPN = 1,
-};
-
enum vpn_provider_state {
VPN_PROVIDER_STATE_UNKNOWN = 0,
VPN_PROVIDER_STATE_IDLE = 1,
@@ -146,7 +141,6 @@ typedef void (* vpn_provider_password_cb_t) (struct
vpn_provider *provider,
struct vpn_provider_driver {
const char *name;
- enum vpn_provider_type type;
int (*probe) (struct vpn_provider *provider);
int (*remove) (struct vpn_provider *provider);
int (*connect) (struct vpn_provider *provider,
--
2.25.0
------------------------------
Date: Wed, 5 Feb 2020 15:12:34 -0500
From: chaitanya cherukuri <[email protected]>
Subject: Wifi Scan Issues and Static IP for Wlan0
To: [email protected]
Message-ID:
<CALVd-wO1r3phefF4-=tALUYRs_0_=e1=nadp4kdhf4qmowz...@mail.gmail.com>
Content-Type: multipart/alternative;
boundary="00000000000099a71d059dd9c73d"
--00000000000099a71d059dd9c73d
Content-Type: text/plain; charset="UTF-8"
Hello,
I'm using connman version 1.36 and wpa_supplicant 2.36.
I have a couple of issues with wifi scan and setting static IP address for
wlan0 interface, could you please help me resolve this?
1. When I scan periodically ( every 10seconds), connman hangs up. Is there any
configuration in connman or wpa_supplicant that can resolve this?
2. When the connected wireless network goes out of range or when i power
off the wireless router to which I'm connected, wifi scan hangs up. this is
the error message that I receive
*"Error /net/connman/technology/wifi: Did not receive a reply. Possible
causes include: the remote application did not send a reply, the message
bus security policy blocked the re."*
3. How do I set up a static IP for wlan0 interface?
Thanks,
Chaitanya
--00000000000099a71d059dd9c73d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr">Hello,<br><br>I'm using connman version 1.36 and wpa_s=
upplicant 2.36.<div><br>I have a couple of issues with wifi scan<span class=
=3D"gmail_default" style=3D"font-family:"comic sans ms",sans-seri=
f;color:rgb(61,133,198)"></span><span class=3D"gmail_default" style=3D""><f=
ont color=3D"#000000" face=3D"arial, sans-serif">=C2=A0and setting static I=
P address for wlan0 interface</font></span><span class=3D"gmail_default" st=
yle=3D"font-family:"comic sans ms",sans-serif;color:rgb(61,133,19=
8)"></span>, could <span class=3D"gmail_default" style=3D"font-family:"=
;comic sans ms",sans-serif;color:rgb(61,133,198)"></span><span class=
=3D"gmail_default" style=3D""><font color=3D"#000000" face=3D"arial, sans-s=
erif">you=C2=A0</font></span>please help me resolve this?<br><br></div><div=
>1.=C2=A0 When I scan periodically ( every 10seconds), connman hangs up. Is=
there<span class=3D"gmail_default" style=3D""><font color=3D"#000000" face=
=3D"arial, sans-serif">=C2=A0any configuration in connman or wpa_supplicant=
that can resolve this?</font></span><span class=3D"gmail_default" style=3D=
"font-family:"comic sans ms",sans-serif;color:rgb(61,133,198)"></=
span><span class=3D"gmail_default" style=3D"font-family:"comic sans ms=
",sans-serif;color:rgb(61,133,198)"></span><br><br>2.=C2=A0 When the c=
onnected wireless network goes out of range or when i power off the wireles=
s router to which <span class=3D"gmail_default" style=3D"font-family:"=
comic sans ms",sans-serif;color:rgb(61,133,198)"></span>I'm connec=
ted, wifi scan hangs up. this is the error message that I receive<br><i>&qu=
ot;Error /net/connman/technology/wifi: Did not receive a reply. Possible ca=
uses include: the remote application did not send a reply, the message bus =
security policy blocked the re."</i><div><i><br></i></div><div><span c=
lass=3D"gmail_default" style=3D"font-style:italic;font-family:"comic s=
ans ms",sans-serif;color:rgb(61,133,198)"></span><span class=3D"gmail_=
default" style=3D""><font color=3D"#000000" face=3D"arial, sans-serif">3. H=
ow do I set up a static IP for wlan0 interface?</font></span><span class=3D=
"gmail_default" style=3D"font-style:italic;font-family:"comic sans ms&=
quot;,sans-serif;color:rgb(61,133,198)"></span><br><div><br><div class=3D"g=
mail_default" style=3D""><span style=3D"font-family:"comic sans ms&quo=
t;,sans-serif;color:rgb(61,133,198)"></span><font color=3D"#000000" face=3D=
"arial, sans-serif">Thanks,</font></div><div class=3D"gmail_default" style=
=3D""><font face=3D"arial, sans-serif" color=3D"#000000">Chaitanya</font></=
div><br></div></div></div></div>
--00000000000099a71d059dd9c73d--
------------------------------
Date: Wed, 5 Feb 2020 18:59:47 -0500
From: chaitanya cherukuri <[email protected]>
Subject: Re: Connman 1.37 source code different in YOCTO
To: Daniel Wagner <[email protected]>
Cc: [email protected]
Message-ID:
<calvd-wodecqun97ekxeyc_ujvelskdptw3fqsgwmkrdz9+8...@mail.gmail.com>
Content-Type: multipart/alternative;
boundary="000000000000323111059ddcf4f3"
--000000000000323111059ddcf4f3
Content-Type: text/plain; charset="UTF-8"
Hi Daniel,
On Sun, Feb 2, 2020, 9:58 AM Daniel Wagner <[email protected]> wrote:
> Hi Chaitanya,
>
> On Thu, Jan 30, 2020 at 04:04:55PM -0500, chaitanya cherukuri wrote:
> > I observed the connman 1.37 source code that YOCTO uses is different
> > from the source code in
> > https://kernel.googlesource.com/pub/scm/network/connman/connman/.
> > To be more precise, I cannot find ipv4ll.c file in YOCTO source code.
>
> That is strange. I checkout out the above repository and find the file:
>
> $ find -name ipv4ll.c
> ./gdhcp/ipv4ll.c
>
> I also cheked Yocto's ConnMan recipe:
>
>
> https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-connectivity/connman/connman/
>
> There are no funky changes or patches on top. Not sure how ipv4ll.c
> get's lost. Do you have some sort of license clearing robot removing
> files in post processing? Anyway, the upstream mirror looks ok.
>
I don't have any robot or post processing scripts to remove the files.
> Thank you for confirming that upstream mirror is ok.
>
> I enabled the wlan0 interface but did not connect to any network. I
> > see my log if filled with these messages:
> > wlcore: firmware booted (Rev 6.3.10.0.142)
> > IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready
> > wlcore: down
> >
> > I didn't see this behavior on connman 1.35 version,
>
> wlcore message is the driver message. This is not from ConnMan. Did
> you upgrade the complete Yocto distribution? If so, did you upgrade
> the kernel and wpa_supplicant as well? I ask because I don't think
> ConnMan is making troubles. It's more likely an upgrade of the kernel
> or wpa_supplicant breaks your setup.
>
> Enable the debug level on ConnMan side by setting the environment
> variable CONNMAN_SUPPLICANT_DEBUG=1 and enabling the connman log
> 'connmand -n -d'. Furthermore, there is iwmon from the iwd project
> which is an excellent debugging tool for looking at the kernel nl80211
> interface. You can monitor all the traffic between wpa_supplicant and
> the kernel.
>
I didn't upgrade the complete Yocto distribution. I only upgraded connman
and wpa_supplicant. I figured that the older version of wpa_supplicant was
also installed and was causing the problems. I will use iwmon for
monitoring traffic between wpa_supplicant and kernel. Can I use
wpa_supplicant version 2.6 for both connman 1.36? Can I replace
wpa_supplicant with iwd for scanning?
Thanks,
> Daniel
>
--000000000000323111059ddcf4f3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div dir=3D"auto"><div>Hi Daniel,<br><br><div class=3D"gma=
il_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Sun, Feb 2, 2020, 9:58 A=
M Daniel Wagner <<a href=3D"mailto:[email protected]"; rel=3D"noreferrer nor=
eferrer" target=3D"_blank">[email protected]</a>> wrote:<br></div><blockquo=
te class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc so=
lid;padding-left:1ex">Hi Chaitanya,<br>
<br>
On Thu, Jan 30, 2020 at 04:04:55PM -0500, chaitanya cherukuri wrote:<br>
> I observed the connman 1.37 source code that YOCTO uses is different<b=
r>
> from the source code in<br>
> <a href=3D"https://kernel.googlesource.com/pub/scm/network/connman/con=
nman/" rel=3D"noreferrer noreferrer noreferrer noreferrer" target=3D"_blank=
">https://kernel.googlesource.com/pub/scm/network/connman/connman/</a>.<br>
> To be more precise, I cannot find ipv4ll.c file in YOCTO source code.<=
br>
<br>
That is strange. I checkout out the above repository and find the file:<br>
<br>
$ find -name ipv4ll.c<br>
./gdhcp/ipv4ll.c<br>
<br>
I also cheked Yocto's ConnMan recipe:<br>
<br>
<a href=3D"https://git.yoctoproject.org/cgit.cgi/poky/plain/meta/recipes-co=
nnectivity/connman/connman/" rel=3D"noreferrer noreferrer noreferrer norefe=
rrer" target=3D"_blank">https://git.yoctoproject.org/cgit.cgi/poky/plain/me=
ta/recipes-connectivity/connman/connman/</a><br>
<br>
There are no funky changes or patches on top. Not sure how ipv4ll.c<br>
get's lost. Do you have some sort of license clearing robot removing<br=
>
files in post processing? Anyway, the upstream mirror looks ok.<br></blockq=
uote></div></div><div dir=3D"auto"><br></div><div dir=3D"auto"><div class=
=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8=
ex;border-left:1px #ccc solid;padding-left:1ex">I don't have any robot =
or post processing scripts to remove the files. Thank you for confirming th=
at upstream mirror is ok.<br></blockquote></div></div><div dir=3D"auto"><br=
></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gm=
ail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-le=
ft:1ex">
> I enabled the wlan0 interface but did not connect to any network. I<br=
>
> see my log if filled with these messages:<br>
>=C2=A0 =C2=A0 wlcore: firmware booted (Rev 6.3.10.0.142)<br>
>=C2=A0 =C2=A0 IPv6: ADDRCONF(NETDEV_UP): wlan0: link is not ready<br>
>=C2=A0 =C2=A0 wlcore: down<br>
> <br>
> I didn't see this behavior on connman 1.35 version,<br>
<br>
wlcore message is the driver message. This is not from ConnMan. Did<br>
you upgrade the complete Yocto distribution? If so, did you upgrade<br>
the kernel and wpa_supplicant as well? I ask because I don't think<br>
ConnMan is making troubles. It's more likely an upgrade of the kernel<b=
r>
or wpa_supplicant breaks your setup.<br>
<br>
Enable the debug level on ConnMan side by setting the environment<br>
variable CONNMAN_SUPPLICANT_DEBUG=3D1 and enabling the connman log<br>
'connmand -n -d'. Furthermore, there is iwmon from the iwd project<=
br>
which is an excellent debugging tool for looking at the kernel nl80211<br>
interface. You can monitor all the traffic between wpa_supplicant and<br>
the kernel.<br></blockquote></div></div><div dir=3D"auto"><br></div><div di=
r=3D"auto"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"></bloc=
kquote></div></div><div dir=3D"auto">=C2=A0I didn't upgrade the complet=
e Yocto distribution. I only upgraded connman and wpa_supplicant. I figured=
that the older version of wpa_supplicant was also installed and was causin=
g the problems. I will use iwmon for monitoring traffic between wpa_supplic=
ant and kernel. Can I use wpa_supplicant version 2.6 for both connman 1.36?=
Can I replace wpa_supplicant with iwd for scanning?</div><div dir=3D"auto"=
><br></div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">
Thanks,<br>
Daniel<br>
</blockquote></div></div></div>
</div>
--000000000000323111059ddcf4f3--
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 52, Issue 7
**************************************
