Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [PATCH] iwd: Propogate invalid key on connection attempt failure
(Daniel Wagner)
2. Re: [PATCH] wireguard: Clear plugin data pointer on disconnect
(Daniel Wagner)
3. Re: [PATCH] vpn: Remove unused type member (Daniel Wagner)
4. Re: [PATCH] inet: Append correct attribute type for RTA_DST
(Daniel Wagner)
5. [PATCH] ipconfig: Use prefix in store_{set|get}_int()
(Daniel Wagner)
6. Re: [PATCH] ipconfig: Use prefix in store_{set|get}_int()
(Daniel Wagner)
7. [PATCH] iwd: Propagete signal strength values (Daniel Wagner)
8. [PATCH] mnlg: Define NETLINK socket options (Daniel Wagner)
----------------------------------------------------------------------
Date: Fri, 7 Feb 2020 08:59:34 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] iwd: Propogate invalid key on connection attempt
failure
To: [email protected]
Cc: Maxime Roussin-Bélanger <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
patch applied.
------------------------------
Date: Fri, 7 Feb 2020 08:59:49 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] wireguard: Clear plugin data pointer on
disconnect
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
patch applied.
------------------------------
Date: Fri, 7 Feb 2020 09:00:00 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] vpn: Remove unused type member
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
patch applied.
------------------------------
Date: Fri, 7 Feb 2020 09:00:10 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] inet: Append correct attribute type for RTA_DST
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
patch applied.
------------------------------
Date: Fri, 7 Feb 2020 09:42:25 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] ipconfig: Use prefix in store_{set|get}_int()
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Message-ID: <[email protected]>
The prefix/key pair should be used when writing or reading the integer
values.
Fixes: e72c871ab44c ("ipconfig: Refactor keyfile store and load operations")
---
src/ipconfig.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 6ae2bf54b6a2..915c082399c4 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -166,7 +166,7 @@ static void store_set_int(struct ipconfig_store *store,
return;
pk = g_strdup_printf("%s%s", store->prefix, key);
- g_key_file_set_integer(store->file, store->group, key, val);
+ g_key_file_set_integer(store->file, store->group, pk, val);
g_free(pk);
}
@@ -176,7 +176,7 @@ static int store_get_int(struct ipconfig_store *store,
const char *key)
char *pk;
pk = g_strdup_printf("%s%s", store->prefix, key);
- val = g_key_file_get_integer(store->file, store->group, key, 0);
+ val = g_key_file_get_integer(store->file, store->group, pk, 0);
g_free(pk);
return val;
--
2.25.0
------------------------------
Date: Fri, 7 Feb 2020 09:45:01 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] ipconfig: Use prefix in store_{set|get}_int()
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
patch applied.
------------------------------
Date: Fri, 7 Feb 2020 09:58:50 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] iwd: Propagete signal strength values
To: [email protected]
Cc: Daniel Wagner <[email protected]>, Maxime Roussin-Bélanger
<[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8
The connman_network_set_strength() setter is not propagating the new
value.
Reported-by: Maxime Roussin-Bélanger <[email protected]>
---
plugins/iwd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/plugins/iwd.c b/plugins/iwd.c
index 39879f6f8c87..bf6a2c261041 100644
--- a/plugins/iwd.c
+++ b/plugins/iwd.c
@@ -972,6 +972,7 @@ static void _update_signal_strength(const char *path,
int16_t signal_strength)
connman_network_set_strength(iwdn->network,
calculate_strength(signal_strength));
+ connman_network_update(iwdn->network);
}
static void ordered_networks_cb(DBusMessage *message, void *user_data)
--
2.25.0
------------------------------
Date: Fri, 7 Feb 2020 13:13:42 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] mnlg: Define NETLINK socket options
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Message-ID: <[email protected]>
Older kernel headers are missing definition for NETLINK_CAP_ACK and
NETLINK_EXT_ACK. Add them so that ConnMan can be build on older
kernels as well.
Furthermore, the WireGuard project has been backported to older
kernels such as the LTS v4.4 kernel.
It's far from ideal but those definition don't hurt too much so we add
them here for the time being.
Reported by Christian Hewitt.
---
src/shared/mnlg.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/src/shared/mnlg.c b/src/shared/mnlg.c
index 6b02059d4490..1399ce40e3d5 100644
--- a/src/shared/mnlg.c
+++ b/src/shared/mnlg.c
@@ -28,6 +28,12 @@
#define ARRAY_SIZE(a) (sizeof(a)/sizeof((a)[0]))
#endif
+#ifndef NETLINK_CAP_ACK
+#define NETLINK_CAP_ACK 10
+#endif
+#ifndef NETLINK_EXT_ACK
+#define NETLINK_EXT_ACK 11
+#endif
struct mnlg_socket {
struct mnl_socket *nl;
--
2.25.0
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 52, Issue 10
***************************************
