Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. Re: [RFC PATCH] ipconfig: cleanup ipdevice gateway fields
(Daniel Wagner)
2. [PATCH v2] ipconfig: cleanup ipdevice gateway fields
(Sergey Matyukevich)
3. Re: connman wifi disconnect problem ([email protected])
4. Re: [PATCH] iptables: Fix incorrect code ([email protected])
5. Re: Get World-Class Assignment Help at a Reasonable budget.
([email protected])
6. Re: Connect With Experts For Do My Homework Service
([email protected])
7. Re: ipv6 test web page down ([email protected])
8. Re: [PATCH v2] ipconfig: cleanup ipdevice gateway fields
(Daniel Wagner)
9. Re: connman wifi disconnect problem (KeithG)
----------------------------------------------------------------------
Date: Wed, 30 Sep 2020 09:10:46 +0200
From: Daniel Wagner <[email protected]>
Subject: Re: [RFC PATCH] ipconfig: cleanup ipdevice gateway fields
To: Sergey Matyukevich <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Sergey,
On Tue, Sep 29, 2020 at 07:30:39PM +0300, Sergey Matyukevich wrote:
> Suggested commit fixes runtime update of WiFi service. For instance,
> consider the following use-case:
>
> - cellular and WiFi technologies are enabled
> - WiFi is a preferred technology
> - EnableOnlineCheck is enabled
> - WiFi service is described by a service file
> - WiFi service is in ONLINE state
>
> When access point is modified in WiFi service file, connman detects
> those changes and performs WiFi service reconfiguration. However
> updated WiFi service never reaches ONLINE state.
>
> The root cause is in a stalled gateway value returned by
> __connman_ipconfig_get_gateway_from_index in
> wispr_route_request function. Online check fails since previous
> gateway address is used for the new access point.
>
> Looking at ipconfig code, it turns out that ipdevice->ipv[46]_gateway
> fields are not cleaned up when IPv[46] system network configuration is
> cleared. Suggested fix is to cleanup IPv4/IPv6 gateways in ipdevice
> whenever IPv4/IPv6 system network configuration is cleared.
Sounds reasonable. I haven't tested it but just looked stared at the
code.
> ---
> src/ipconfig.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/src/ipconfig.c b/src/ipconfig.c
> index 915c0823..21a2c41d 100644
> --- a/src/ipconfig.c
> +++ b/src/ipconfig.c
> @@ -1647,6 +1647,11 @@ int __connman_ipconfig_enable(struct connman_ipconfig
> *ipconfig)
> connman_ipaddress_clear(ipdevice->config_ipv4->system);
>
> __connman_ipconfig_unref(ipdevice->config_ipv4);
> +
> + if (ipdevice->ipv4_gateway) {
> + g_free(ipdevice->ipv4_gateway);
> + ipdevice->ipv4_gateway = NULL;
> + }
No need to check for NULL pointer. g_free() is doing it.
I suggested we apply the updated patch and see who is starting complain :)
Thanks,
Daniel
------------------------------
Date: Wed, 30 Sep 2020 10:56:44 +0300
From: Sergey Matyukevich <[email protected]>
Subject: [PATCH v2] ipconfig: cleanup ipdevice gateway fields
To: [email protected]
Cc: Sergey Matyukevich <[email protected]>
Message-ID: <[email protected]>
Suggested commit fixes runtime updates for WiFi service. For instance,
consider the following use-case:
- cellular and WiFi technologies are enabled
- WiFi is a preferred technology
- EnableOnlineCheck is enabled
- WiFi service is described by a service file
- WiFi service is in ONLINE state
When access point is modified in WiFi service file, connman detects
those changes and performs WiFi service reconfiguration. However
updated WiFi service never reaches ONLINE state.
The root cause is in a stalled gateway value returned by
__connman_ipconfig_get_gateway_from_index in wispr_route_request
function. Online check fails since previous gateway address is used
for the new access point.
Looking at ipconfig code, it turns out that ipdevice->ipv[46]_gateway
fields are not cleaned up when IPv[46] system network configuration
is cleared. Suggested fix is to cleanup ipdevice IPv4/IPv6 gateways
whenever IPv4/IPv6 system network configuration is cleared.
---
v1 -> v2
- address review comments: remove NULL check before g_free
src/ipconfig.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/src/ipconfig.c b/src/ipconfig.c
index 915c0823..a1073a75 100644
--- a/src/ipconfig.c
+++ b/src/ipconfig.c
@@ -1647,6 +1647,9 @@ int __connman_ipconfig_enable(struct connman_ipconfig
*ipconfig)
connman_ipaddress_clear(ipdevice->config_ipv4->system);
__connman_ipconfig_unref(ipdevice->config_ipv4);
+
+ g_free(ipdevice->ipv4_gateway);
+ ipdevice->ipv4_gateway = NULL;
}
if (type == CONNMAN_IPCONFIG_TYPE_IPV6 &&
@@ -1657,6 +1660,9 @@ int __connman_ipconfig_enable(struct connman_ipconfig
*ipconfig)
connman_ipaddress_clear(ipdevice->config_ipv6->system);
__connman_ipconfig_unref(ipdevice->config_ipv6);
+
+ g_free(ipdevice->ipv6_gateway);
+ ipdevice->ipv6_gateway = NULL;
}
if (type == CONNMAN_IPCONFIG_TYPE_IPV4)
@@ -1719,6 +1725,10 @@ int __connman_ipconfig_disable(struct connman_ipconfig
*ipconfig)
connman_ipaddress_clear(ipdevice->config_ipv4->system);
__connman_ipconfig_unref(ipdevice->config_ipv4);
ipdevice->config_ipv4 = NULL;
+
+ g_free(ipdevice->ipv4_gateway);
+ ipdevice->ipv4_gateway = NULL;
+
return 0;
}
@@ -1728,6 +1738,10 @@ int __connman_ipconfig_disable(struct connman_ipconfig
*ipconfig)
connman_ipaddress_clear(ipdevice->config_ipv6->system);
__connman_ipconfig_unref(ipdevice->config_ipv6);
ipdevice->config_ipv6 = NULL;
+
+ g_free(ipdevice->ipv6_gateway);
+ ipdevice->ipv6_gateway = NULL;
+
return 0;
}
------------------------------
Date: Wed, 30 Sep 2020 08:04:50 -0000
From: [email protected]
Subject: Re: connman wifi disconnect problem
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Custom psychology research writing services have become very popular among
students seeking Psychology Assignment Writing Services and psychology essay
writing services.
https://researchpapers247.com/psychology-assignment-writing-services-2/
------------------------------
Date: Wed, 30 Sep 2020 08:05:09 -0000
From: [email protected]
Subject: Re: [PATCH] iptables: Fix incorrect code
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
There is a reliable Healthcare Assignment Writing Service that is very popular
for students in search of healthcare coursework writing services and nursing
essay writing help services.
https://researchpapers247.com/healthcare-assignment-writing-service/
------------------------------
Date: Wed, 30 Sep 2020 08:05:28 -0000
From: [email protected]
Subject: Re: Get World-Class Assignment Help at a Reasonable budget.
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
There are many theology & religion coursework writing services and Religious
Research Writing Services to choose from for those stuck with their religion
assignment writing services and theology essay writing help services.
https://researchpapers247.com/religious-research-writing-services/
------------------------------
Date: Wed, 30 Sep 2020 08:05:47 -0000
From: [email protected]
Subject: Re: Connect With Experts For Do My Homework Service
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Medical coursework writing service seekers have been on the rise lately since
most learners need Medical Research Paper Services, nursing research writing
services and medical essay writing services.
https://researchpapers247.com/medical-research-paper-services/
------------------------------
Date: Wed, 30 Sep 2020 08:06:11 -0000
From: [email protected]
Subject: Re: ipv6 test web page down
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="utf-8"
Seeking psychology research writing services are very common nowadays since
there are very many students in need of Psychology Coursework Writing Services
and psychology assignment writing services.
https://researchpapers247.com/psychology-coursework-writing-service/
------------------------------
Date: Wed, 30 Sep 2020 13:01:12 +0200
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH v2] ipconfig: cleanup ipdevice gateway fields
To: Sergey Matyukevich <[email protected]>
Cc: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Sergey,
On Wed, Sep 30, 2020 at 10:56:44AM +0300, Sergey Matyukevich wrote:
> Suggested commit fixes runtime updates for WiFi service. For instance,
> consider the following use-case:
>
> - cellular and WiFi technologies are enabled
> - WiFi is a preferred technology
> - EnableOnlineCheck is enabled
> - WiFi service is described by a service file
> - WiFi service is in ONLINE state
>
> When access point is modified in WiFi service file, connman detects
> those changes and performs WiFi service reconfiguration. However
> updated WiFi service never reaches ONLINE state.
>
> The root cause is in a stalled gateway value returned by
> __connman_ipconfig_get_gateway_from_index in wispr_route_request
> function. Online check fails since previous gateway address is used
> for the new access point.
>
> Looking at ipconfig code, it turns out that ipdevice->ipv[46]_gateway
> fields are not cleaned up when IPv[46] system network configuration
> is cleared. Suggested fix is to cleanup ipdevice IPv4/IPv6 gateways
> whenever IPv4/IPv6 system network configuration is cleared.
Patch applied. I trimmed the commit message slightly. Hope that is okay.
Thanks,
Daniel
------------------------------
Date: Wed, 30 Sep 2020 07:40:43 -0500
From: KeithG <[email protected]>
Subject: Re: connman wifi disconnect problem
To: Daniel Wagner <[email protected]>
Cc: "Ryll, Jan (GED-SDD2)" <[email protected]>, "[email protected]"
<[email protected]>
Message-ID:
<cag17s_ne7wsbh22gyqfhwkn0e_jeh_igu0dmdyywfohxf_k...@mail.gmail.com>
Content-Type: multipart/alternative;
boundary="000000000000d6c72405b087351a"
--000000000000d6c72405b087351a
Content-Type: text/plain; charset="UTF-8"
Daniel,
Hmmm, Agent as in 'connmanctl> agent on'?
Which distro are you using? On the RPIs, I do not believe that raspbian
(whatever it is called now) has kernel support for iwd so I don't believe
that it is a candidate for an investigation. I could be wrong, though and
the current version might. I do have 2 laptops with Arch on them right now
and can install something else on one of them. I find it strange that all
Arch Linux installs fail in this test and would like to see if a different
distro may behave differently. It would be preferable that it run on an
RPi, but I could put it on the laptop...
Keith
On Wed, Sep 30, 2020 at 1:25 AM Daniel Wagner <[email protected]> wrote:
> > Looking at this a bit more. Arch patches connman-polkit.conf when the
> > package is built. This is the patch:
> > $ cat allow_group_network.diff
> > --- a/src/connman-polkit.conf 2010-11-05 12:09:04.285423955 -0200
> > +++ b/src/connman-polkit.conf 2010-11-05 12:10:53.041423934 -0200
> > @@ -5,6 +5,9 @@
> > <allow own="net.connman"/>
> > <allow send_interface="net.connman.Agent"/>
> > </policy>
> > + <policy group="network">
> > + <allow send_interface="net.connman.Agent"/>
> > + </policy>
> > <policy context="default">
> > <allow send_destination="net.connman"/>
> > </policy>
> >
> > Could this be a culprit?
>
> This controls access to the Agent API. As far I can tell, the problems
> you describe are not related to the Agent (yet).
>
--000000000000d6c72405b087351a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
<div dir=3D"ltr"><div>Daniel,</div><div><br></div><div>Hmmm, Agent as in &#=
39;connmanctl> agent on'? <br></div><div><br></div><div>Which distro=
are you using? On the RPIs, I do not believe that raspbian (whatever it is=
called now) has kernel support for iwd so I don't believe that it is a=
candidate for an investigation. I could be wrong, though and the current v=
ersion might. I do have 2 laptops with Arch on them right now and can insta=
ll something else on one of them. I find it strange that all Arch Linux ins=
talls fail in this test and would like to see if a different distro may beh=
ave differently. It would be preferable that it run on an RPi, but I could =
put it on the laptop...</div><div><br></div><div>Keith<br></div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Sep=
30, 2020 at 1:25 AM Daniel Wagner <<a href=3D"mailto:[email protected]";>wa=
[email protected]</a>> wrote:<br></div><blockquote class=3D"gmail_quote" styl=
e=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);paddin=
g-left:1ex">> Looking at this a bit more.=C2=A0 Arch patches connman-pol=
kit.conf when=C2=A0 the<br>
> package is built. This is the patch:<br>
> $ cat allow_group_network.diff<br>
> --- a/src/connman-polkit.conf=C2=A0 =C2=A02010-11-05 12:09:04.28542395=
5 -0200<br>
> +++ b/src/connman-polkit.conf=C2=A0 =C2=A02010-11-05 12:10:53.04142393=
4 -0200<br>
> @@ -5,6 +5,9 @@<br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <allow own=3D"net.connman&qu=
ot;/><br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <allow send_interface=3D"net=
.connman.Agent"/><br>
>=C2=A0 =C2=A0 =C2=A0 </policy><br>
> +=C2=A0 =C2=A0 <policy group=3D"network"><br>
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0<allow send_interface=3D"net.connm=
an.Agent"/><br>
> +=C2=A0 =C2=A0 </policy><br>
>=C2=A0 =C2=A0 =C2=A0 <policy context=3D"default"><br>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 <allow send_destination=3D"n=
et.connman"/><br>
>=C2=A0 =C2=A0 =C2=A0 </policy><br>
> <br>
> Could this be a culprit?<br>
<br>
This controls access to the Agent API. As far I can tell, the problems<br>
you describe are not related to the Agent (yet).<br>
</blockquote></div>
--000000000000d6c72405b087351a--
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 59, Issue 33
***************************************
