Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. ODP: [PATCH] Bugfixes (Boleslaw Tokarski)
2. Re: gdhcp: Make DHCP client timeouts suspend aware (Denis Kenzior)
----------------------------------------------------------------------
Date: Fri, 11 Dec 2020 11:52:23 +0000
From: Boleslaw Tokarski <[email protected]>
Subject: ODP: [PATCH] Bugfixes
To: Daniel Wagner <[email protected]>
Cc: "[email protected]" <[email protected]>
Message-ID: <[email protected]
prd06.prod.outlook.com>
Content-Type: multipart/alternative; boundary="_000_AM6PR06MB4945A4
BC885DBEF9A8479A98E0CA0AM6PR06MB4945eurp_"
--_000_AM6PR06MB4945A4BC885DBEF9A8479A98E0CA0AM6PR06MB4945eurp_
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
Hi,
Thanks, I'll try using git send-email next time.
Regards,
Boles=B3aw Tokarski
--_000_AM6PR06MB4945A4BC885DBEF9A8479A98E0CA0AM6PR06MB4945eurp_
Content-Type: text/html; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
<html>
<head>
<meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3Diso-8859-=
2">
<style type=3D"text/css" style=3D"display:none;"> P {margin-top:0;margin-bo=
ttom:0;} </style>
</head>
<body dir=3D"ltr">
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Hi,</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Thanks, I'll try using git send-email next time.</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
<br>
</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Regards,</div>
<div style=3D"font-family: Calibri, Arial, Helvetica, sans-serif; font-size=
: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">
Boles=B3aw Tokarski<br>
</div>
</body>
</html>
--_000_AM6PR06MB4945A4BC885DBEF9A8479A98E0CA0AM6PR06MB4945eurp_--
------------------------------
Date: Wed, 9 Dec 2020 10:11:43 -0600
From: Denis Kenzior <[email protected]>
Subject: Re: gdhcp: Make DHCP client timeouts suspend aware
To: Daniel Wagner <[email protected]>, "Holesch, Simon (GED-SDD1)"
<[email protected]>
Cc: "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
On 12/11/20 4:11 AM, Daniel Wagner wrote:
> On Thu, Dec 10, 2020 at 10:42:40AM +0000, Holesch, Simon (GED-SDD1) wrote:
>> Here are the relevant parts of RFC 2131:
>>> 4.4.5 Reacquisition and expiration
>>> If no DHCPACK arrives before time T2, the client moves to REBINDING
>>> state and sends (via broadcast) a DHCPREQUEST message to extend its
>>> lease.
>>> [...]
>>> If the lease expires before the client receives a DHCPACK, the client
>>> moves to INIT state, MUST immediately stop any other network
>>> processing and requests network initialization parameters as if the
>>> client were uninitialized.
>>
>> One option would be to use CLOCK_BOOTTIME (instead of
>> CLOCK_BOOTTIME_ALARM, see timer_create(2)), which continues to run
>> during suspend, but doesn't wake up the system. But I'm not aware of a
>> way to prevent the client to use the IP address right after wakeup.
>> That's why I used the CLOCK_BOOTTIME_ALARM clock.
>
> In this case the DHCP code needs to be made aware of the power state
> transitions. In hindsight, CLOCK_BOOTTIME_ALARM was not the best
> choice.
Just curious what you have in mind? How would knowing the power state help?
>
> Anyway, I think the best way forward is to either revert the commit or
> change it to use the original clock id. This will give some time to
> figure out how to teach the DHCP the power states.
Perhaps setting valid_lft on the address and having the kernel take it away
automagically is the ticket. That way CLOCK_BOOTTIME can be used...
Regards,
-Denis
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 62, Issue 18
***************************************
