Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH] service: Fix integer type for online check interval
(Daniel Wagner)
2. Re: [PATCH] service: Fix integer type for online check interval
(Daniel Wagner)
3. Re: [PATCH] service: Add online to ready transition feature
(Daniel Wagner)
----------------------------------------------------------------------
Date: Mon, 22 Feb 2021 09:18:21 +0100
From: Daniel Wagner <[email protected]>
Subject: [PATCH] service: Fix integer type for online check interval
To: [email protected]
Cc: Daniel Wagner <[email protected]>
Message-ID: <[email protected]>
Make all online check interval varables unsigned int
to avoid comparing int with unsinged int.
---
src/service.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/service.c b/src/service.c
index 99a52022b80b..dfb5a93c22ec 100644
--- a/src/service.c
+++ b/src/service.c
@@ -136,8 +136,8 @@ struct connman_service {
bool wps;
bool wps_advertizing;
guint online_timeout;
- int online_check_interval_ipv4;
- int online_check_interval_ipv6;
+ unsigned int online_check_interval_ipv4;
+ unsigned int online_check_interval_ipv6;
bool do_split_routing;
bool new_service;
bool hidden_service;
@@ -6260,7 +6260,7 @@ int __connman_service_online_check_failed(struct
connman_service *service,
enum connman_ipconfig_type type)
{
GSourceFunc redo_func;
- int *interval;
+ unsigned int *interval;
if (type == CONNMAN_IPCONFIG_TYPE_IPV4) {
interval = &service->online_check_interval_ipv4;
--
2.30.1
------------------------------
Date: Mon, 22 Feb 2021 09:19:52 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] service: Fix integer type for online check
interval
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
On Mon, Feb 22, 2021 at 09:18:21AM +0100, Daniel Wagner wrote:
> Make all online check interval varables unsigned int
> to avoid comparing int with unsinged int.
Patch applied.
------------------------------
Date: Mon, 22 Feb 2021 09:21:57 +0100
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH] service: Add online to ready transition feature
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<[email protected]>
Cc: "[email protected]" <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=us-ascii
Hi Emmanuel,
On Mon, Feb 15, 2021 at 04:56:50PM +0000, VAUTRIN Emmanuel (Canal Plus
Prestataire) wrote:
> WARNING: Experimental feature!!!
> Global config option, which allows keeping calling the online check
> request to guarantee that end-to-end connectivity is still successful.
> If not, the default service transitions to READY state, enabling another
> service to become the default one, in replacement.
Can you resend, maybe attach it, as the patch seemed to be whitespace
damaged. I wanted to test it for a while :)
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 64, Issue 14
***************************************
