Send connman mailing list submissions to
[email protected]
To subscribe or unsubscribe via email, send a message with subject or
body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of connman digest..."
Today's Topics:
1. [PATCH 0/1] start online check even if service is not the default service
(Christophe Ronco)
2. [PATCH 1/1] service: start online check even if service is not the
default service
(Christophe Ronco)
3. RE: [PATCH 0/1] start online check even if service is not the default
service
(VAUTRIN Emmanuel (Canal Plus Prestataire))
4. Re: [PATCH 0/1] start online check even if service is not the default
service
(Daniel Wagner)
----------------------------------------------------------------------
Date: Thu, 29 Apr 2021 15:01:29 +0200
From: Christophe Ronco <[email protected]>
Subject: [PATCH 0/1] start online check even if service is not the
default service
To: [email protected], [email protected]
Cc: Christophe Ronco <[email protected]>
Message-ID: <[email protected]>
Hi,
I have a platform with Ethernet and WiFi and I usually use Connman 1.36. I have
recently upgraded to Connman 1.38.
When preferred technology service is back, it does not go to Online state as it
was doing with Connman 1.36.
I think this is easier to explain with an example:
I start platform with a WiFi service configured and Ethernet cable plugged. My
preferred technologies are:
PreferredTechnologies = ethernet, wifi, cellular
1) After boot, wired service is online, WiFi service is not configured
2) Unplug Eth cable
=> WiFi is set to online
3) Re-plug Ethernet cable
=>WiFi stays online, Wired service is Ready.
I think that online check is not started in this case. I assume it comes from
changes done in patch e600366f603590b01449b34a8215efde54f566dd.
I have fixed that by starting online check for all services, not only for
default service.
With the fix, at step 3, Wired service becomes Online and WiFi service becomes
ready.
Best Regards,
Christophe Ronco
Christophe Ronco (1):
service: start online check even if service is not the default service
src/service.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.25.1
------------------------------
Date: Thu, 29 Apr 2021 15:01:30 +0200
From: Christophe Ronco <[email protected]>
Subject: [PATCH 1/1] service: start online check even if service is
not the default service
To: [email protected], [email protected]
Cc: Christophe Ronco <[email protected]>
Message-ID: <[email protected]>
This was the standard behavior before patch
e600366f603590b01449b34a8215efde54f566dd.
---
src/service.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/service.c b/src/service.c
index 2f497d10..fd149169 100644
--- a/src/service.c
+++ b/src/service.c
@@ -1430,10 +1430,12 @@ static void address_updated(struct connman_service
*service,
service == connman_service_get_default()) {
nameserver_remove_all(service, type);
nameserver_add_all(service, type);
- start_online_check(service, type);
__connman_timeserver_sync(service);
}
+
+ if (is_connected(service->state))
+ start_online_check(service, type);
}
static struct connman_stats *stats_get(struct connman_service *service)
--
2.25.1
------------------------------
Date: Thu, 29 Apr 2021 14:42:38 +0000
From: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<[email protected]>
Subject: RE: [PATCH 0/1] start online check even if service is not the
default service
To: Christophe Ronco <[email protected]>, "[email protected]"
<[email protected]>, "[email protected]" <[email protected]>
Message-ID: <[email protected]
prd02.prod.outlook.com>
Content-Type: text/plain; charset="iso-8859-1"
Hi Christophe,
> I have a platform with Ethernet and WiFi and I usually use Connman 1.36.
> I have recently upgraded to Connman 1.38.
By our side, we have integrated ConnMan on devices with a similar setup.
> When preferred technology service is back, it does not go to Online state
> as it was doing with Connman 1.36.
I have provided several fixes / changes related to the online state,
after the 1.38, maybe you can check them and try to test
with the master on HEAD, hoping it will solve your problem.
Best Regards,
Emmanuel
------------------------------
Date: Fri, 30 Apr 2021 08:12:45 +0200
From: Daniel Wagner <[email protected]>
Subject: Re: [PATCH 0/1] start online check even if service is not the
default service
To: "VAUTRIN Emmanuel (Canal Plus Prestataire)"
<[email protected]>, Christophe Ronco
<[email protected]>, "[email protected]" <[email protected]>,
"[email protected]" <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=utf-8; format=flowed
Hi,
On 29.04.21 16:42, VAUTRIN Emmanuel (Canal Plus Prestataire) wrote:
>> I have a platform with Ethernet and WiFi and I usually use Connman 1.36.
>> I have recently upgraded to Connman 1.38.
> By our side, we have integrated ConnMan on devices with a similar setup.
The current release is v1.39 and as Emmanuel points out there were
several fixes regarding online checks. Please give the latest release a go.
Thanks,
Daniel
------------------------------
Subject: Digest Footer
_______________________________________________
connman mailing list -- [email protected]
To unsubscribe send an email to [email protected]
------------------------------
End of connman Digest, Vol 66, Issue 35
***************************************
