On 04/04/2016 06:02 PM, Brian (bex) Exelbierd wrote:
This affects adb-utils and ADB kickstart files.
Should we move the Kube unite file (lines 73-103) of
https://github.com/projectatomic/adb-atomic-developer-bundle/blob/master/build_tools/kickstarts/centos-7-adb-vagrant.ks
to the adb-utils RPM?
These lines control the creation of the kubernetes unit file.
These types of changes should live in kickstart file. adb-utils is
about the additional scripts or configurations we need on top of
kickstart file. IMO if the changes are required to fix the base
distribution configurations it should be part of kickstart file.
I understand that the boundary between kickstart file and adb-utils are
kind of blurry. For the same reason I was skeptical giving a generic
name i.e. adb-utils (i.e. utils) and had a chat with Praveen about it.
I am not sure if I would be able to clearly define the boundary between
the two. But would like to keep the kickstart file independent of
adb-utils and things like system configuration related to creation of a
functional image should live in the kickstart file. The extra magic
which is might be complicated and should be done after the image boots
up successfully should be done in adb-utils.
regards,
bex
L#73-103 was a workaround for an upstream issue and the the fix was sent
to upstream and was merged. However I am not sure which version of K8s
has the fix. We need to check if the stock K8s has the fix.
_______________________________________________
Container-tools mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/container-tools
_______________________________________________
Container-tools mailing list
[email protected]
https://www.redhat.com/mailman/listinfo/container-tools
