On Wed, Oct 4, 2017 at 12:00 AM, Burr Sutter <[email protected]> wrote:
> > > On Tue, Oct 3, 2017 at 7:11 PM, Hardy Ferentschik <[email protected]> > wrote: > >> Hi, >> >> On Tue, 03-Oct-2017 16:35, Burr Sutter wrote: >> > But profile “bar” does not exist until start is called >> >> The global '--profile bar' option will implicitly create the profile >> when used with the config an addon command. If you want to configure a >> given profile >> prior to start you will need to use these commands with this option. >> >> How in your example do you expect minishift to now to what profile to >> associate the >> config changes? How would Minishift know that you want to configure a >> profile bar? >> >> As mentioned on the issue comment, maybe a different behaviour for >> 'minishift profile set bar' >> makes sense. Atm you get an error message if the profile does not exist. >> One cold argue >> it should create an empty profile. Whether there should be an explicit >> 'minishift profile create bar' >> is debatable. Either way, your examples would still be wrong and would >> need >> to be preceded with a minishift profile [set|create]. >> > > so our docs are horrible. > It was the first iteration of the docs which got merged with the code. I agree that I could have written a better doc, but at that point getting the code ready was in my mind. and the usability is counter intuitive :-) > Lets discuss that. The current implementation is backward compatible and we have tried to keep the usability similar to the previous Minishift. As part of the feature we have introduced one global flag "--profile" and "profile set", "profile list", "profile delete" commands. As a single line suggestion I would suggest that you should just use "--profile <profile name>" to the commands you have been using with previous Minishift releases and you should be good to go. For example: how do you start a minishift instance. $ minishift config set memory 4GB $ minishift config set CPU 2 $ minishift start Now with profile you need to just add --profile to the above commands and it would work as expected i.e. $ minishift --profile xyz config set memory 4GB $ minishift --profile xyz config set CPU 2 $ minishift --profile xyz start There are few things not implemented yet e.g. a global cache for profiles and few other things as these are planned as followup tasks. So you can expect it to improve gradually. The most important thing for us was to maintain the isolation between instances. I understand that users might want to have global settings also which we can discuss and implement in future if required. But what we have in the first iteration of profiles is a result of our intention where we wanted to be 100% backward compatible and for the same reason we have kept few features as follow up tasks. Thanks for your feedback till now and I would encourage you to let us know if you think things are bad for you. We will take action items to fix stuff as we go for sure. -Lala > > >> >> --Hardy >> >> >> > >> > I think there should be a >> > Minishift profile create that matches delete >> > Then all other commands work inside of that profile context. >> > >> > >> > On Tue, Oct 3, 2017 at 9:21 AM Hardy Ferentschik <[email protected]> >> > wrote: >> > >> > > On Tue, 03-Oct-2017 14:28, Burr Sutter wrote: >> > > > any thoughts how the workaround for addons + profiles? >> > > >> > > See the comments on the issue you created. You are using the commands >> > > wrong. You >> > > issue 'config set' and 'addon enable' commands against the currently >> > > active profile, but then >> > > you start a new profile. If you want to set the config and add-ons >> prior >> > > to starting the profile >> > > you need to do something like: >> > > >> > > $ minishift --profile bar addon enable anyuid >> > > >> > > resp >> > > >> > > $ minishift --profile test config set memory 6144 >> > > >> > > --Hardy >> > > >> > > >> > > > _______________________________________________ > Container-tools mailing list > [email protected] > https://www.redhat.com/mailman/listinfo/container-tools > >
_______________________________________________ Container-tools mailing list [email protected] https://www.redhat.com/mailman/listinfo/container-tools
