+1, that was me being lazy when I wrote the plugin.
- Brett
On 26/08/2006, at 12:02 PM, Jeremy Whitlock wrote:
Hi All,
I started working on this today and I have run into a few things
that I
would like you to be aware of just in case you have a better way of
handling
the situation.
As I was going through and creating the modello for
ReleaseDescriptor, used
to replace the ReleaseConfiguration, I ran into an issue where some
of the
things that are currently stored in the ReleaseConfiguration, but not
necessarily persisted to the release properties file, that cannot
be stored
in a modello file. I have done some researching and I do think
that these
items do not necessarily need to be in the ReleaseDescriptor. The
problem
is that the release plugin still needs to get access to these
things, like
the Settings object, to perform the release. That being said, my
plan is to
refactor and pass these objects to the proper methods where they
are needed
and not worry about storing them in the ReleaseDescriptor. Does
anyone see
any problem with this or have any suggestions in the matter?
Take care,
Jeremy
P.S. - To see what I am speaking of, open the "
org.apache.maven.plugins.release.config.ReleaseConfiguration" file
and look
at all local member variables that are not capable of being stored
in a
class created by modello. (For example: The Settings, List and Map
objects) If you have time, look at how they are used and get back
to me.
