==================================================================
  Please DO NOT REPLY to this mail or send email to the developers
  about this bug. Please follow-up to Bugzilla using this link:
    http://bugs.contribs.org/show_bug.cgi?id=8713

  Have you checked the Frequently Asked Questions (FAQ)?
    http://wiki.contribs.org/SME_Server:Documentation:FAQ

  Please also take the time to read the following useful guide:
    http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
==================================================================

            Bug ID: 8713
           Summary: NFR: make affa3 AutoUnmount recognize external drive
                    mounted by disk label
    Classification: Contribs
           Product: SME Contribs
           Version: 9.0
          Hardware: ---
                OS: ---
            Status: UNCONFIRMED
          Severity: normal
          Priority: P3
         Component: smeserver-affa (unmaintained)
          Assignee: [email protected]
          Reporter: [email protected]
        QA Contact: [email protected]

Created attachment 4874
  --> http://bugs.contribs.org/attachment.cgi?id=4874&action=edit
Patch to /sbin/affa in order to enable check for external disk label before
unmount

Overview
========

If the AutomountDevice parameter in an affa3 backup config file does not point
to a device node (eg. /dev/sdb1) but to a disk label (eg.
/dev/disk/by-label/backupdisk) linked to this device node, the external drive
is not unmounted after the backup job is done.

Reproduce
=========

[root@sme ~]# grep Automount /etc/affa/backup-test.conf 
AutomountDevice=/dev/disk/by-label/backupdisk
AutomountPoint=/mnt/backupdisk

after external drive (USB, ext3, labeled "backupdisk") is plugged in:

[root@sme ~]# ls -l /dev/disk/by-label/backupdisk 
lrwxrwxrwx 1 root root 10  3. Dez 17:07 /dev/disk/by-label/backupdisk ->
../../sdb1

affa log after job finishes:
[root@sme ~]# grep Check /var/log/affa/backup-test.log
[...]: Check mounted: /dev/disk/by-label/backupdisk /mnt/backupdisk. Result: no

Actual Results
==============

As the log entry indicates, the isMounted check in /sbin/affa gives a wrong
result. Consequently, the external drive is not unmounted.

Expected Results
================

External drive should unmount after affa job is done.

Affa version
============

smeserver-affa-3.2.2.1-0.noarch

Possible Solution
=================

See attached patch:
I have implemented an additional function in /sbin/affa to check if the
external drive is mounted based on a disk label and map the label to a device
node name before the /sbin/affa script tries to unmount the drive.

Im an not sure who is currently maintaining the affa contrib (wiki says it is
currently unmaintained), but maybe this is useful for people still using the
contrib. I am of course open for discussion.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at http://lists.contribs.org/mailman/public/contribteam/

Reply via email to