==================================================================
  Please DO NOT REPLY to this mail or send email to the developers
  about this bug. Please follow-up to Bugzilla using this link:
    http://bugs.contribs.org/show_bug.cgi?id=7555

  Have you checked the Frequently Asked Questions (FAQ)?
    http://wiki.contribs.org/SME_Server:Documentation:FAQ

  Please also take the time to read the following useful guide:
    http://www.chiark.greenend.org.uk/~sgtatham/bugs.html
==================================================================

--- Comment #10 from Stephane de Labrusse <[email protected]> ---
Hi Mats, glad to see you around :)


I saw some issues (sorry in advance)

a)the file /usr/share/smeserver-vacation/check_vacation_dates.sh is not
executable

# ll /usr/share/smeserver-vacation/check_vacation_dates.sh
-rw-r--r-- 1 root root 1303  4 sept. 12:17
/usr/share/smeserver-vacation/check_vacation_dates.sh

either you can take this example in the specfile
http://wiki.contribs.org/.spec_file_notes#.25install

or simply like this 

http://wiki.contribs.org/.spec_file_notes#.25attr.28755.2Croot.2Croot.29_.2Fetc.2Fe-smith.2Fsql.2Finit.2Fsme8admin


it could look like this

/sbin/e-smith/genfilelist $RPM_BUILD_ROOT \
     --file '/usr/local/bin/vacation' 'attr(0755,root,root)' \
     --file '/usr/share/smeserver-vacation/check_vacation_dates.sh'
'attr(0755,root,root)' \
     > %{name}-%{version}-filelist

b) you missed translation to en-us, please add them to
/etc/e-smith/locale/en-us/etc/e-smith/web/functions/uservacations

I mean to :

VACATION_FROM (YYYYMMDD)
VACATION_TO (YYYYMMDD)

c)the cron path is not standard, you should use /sbin/e-smith/


d)the cron is written in bash, it should be written in perl, what do you think
of that ? (of course it is workable after you set it executable)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at http://lists.contribs.org/mailman/public/contribteam/

Reply via email to