https://bugs.contribs.org/show_bug.cgi?id=9073
--- Comment #8 from Charlie Brady
<[email protected]> ---
(In reply to Jean-Philippe Pialasse from comment #7)
> Charlie,
>
> if you have no more comment I will apply this patch to cvs and build
There are still security problems with the current version of the patch, as the
script will be running with groupid set to 'root', so will be able to write to
group writable files/directories with group set to 'root'.
The solution is to switch both uid and gid before creating the file. If you do
this, you also won't need to chown the file.
Note when switching uid/gid, you should also check that the switch succeeded -
otherwise the process would still be running as root.
A minor issue is that calling 'die' in user interface code isn't ideal - it
means that the user would see a white screen, rather than text explaining that
something went wrong. Since we never expect to see those cases, and there are
lots of use of 'die' in the server-manager code already, I don't think this is
critical to fix.
--
You are receiving this mail because:
You are the QA Contact for the bug.
_______________________________________________
Mail for each SME Contribs bug report
To unsubscribe, e-mail [email protected]
Searchable archive at https://lists.contribs.org/mailman/public/contribteam/
